From 1af32ecbf49626aceffbb2f1e2f2406f4d1f03e3 Mon Sep 17 00:00:00 2001
From: Bubka <858858+Bubka@users.noreply.github.com>
Date: Mon, 10 Oct 2022 11:21:42 +0200
Subject: [PATCH] Set icon filename generation as a helper function

---
 app/Helpers/Helpers.php    | 20 ++++++++++++++++++++
 app/Models/TwoFAccount.php |  3 ++-
 config/app.php             |  2 +-
 3 files changed, 23 insertions(+), 2 deletions(-)
 create mode 100644 app/Helpers/Helpers.php

diff --git a/app/Helpers/Helpers.php b/app/Helpers/Helpers.php
new file mode 100644
index 00000000..142d2960
--- /dev/null
+++ b/app/Helpers/Helpers.php
@@ -0,0 +1,20 @@
+<?php
+
+namespace App\Helpers;
+
+use Illuminate\Support\Str;
+
+class Helpers
+{
+    /**
+     * Generate a unique filename
+     * 
+     * @param string $ids twofaccount ids to delete
+     * 
+     * @return string The filename
+     */
+    public static function getUniqueFilename(string $extension): string
+    {
+        return Str::random(40).'.'.$extension;
+    }
+}
diff --git a/app/Models/TwoFAccount.php b/app/Models/TwoFAccount.php
index af912dec..72a8eb06 100644
--- a/app/Models/TwoFAccount.php
+++ b/app/Models/TwoFAccount.php
@@ -29,6 +29,7 @@
 use ParagonIE\ConstantTime\Base32;
 use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\Http;
+use App\Helpers\Helpers;
 
 class TwoFAccount extends Model implements Sortable
 {
@@ -537,7 +538,7 @@ private function storeImageAsIcon(string $url)
     {
         try {
             $path_parts = pathinfo($url);
-            $newFilename = Str::random(40).'.'.$path_parts['extension'];
+            $newFilename = Helpers::getUniqueFilename($path_parts['extension']);  //Str::random(40).'.'.$path_parts['extension'];
             $imageFile = self::IMAGELINK_STORAGE_PATH . $newFilename;
 
             try {
diff --git a/config/app.php b/config/app.php
index 856e40dc..ad91f22e 100644
--- a/config/app.php
+++ b/config/app.php
@@ -232,7 +232,7 @@
         'QrCode' => App\Facades\QrCode::class,
         'Groups' => App\Facades\Groups::class,
         'TwoFAccounts' => App\Facades\TwoFAccounts::class,
-        
+        'Helpers' => App\Helpers\Helpers::class,
     ],
 
 ];