diff --git a/app/Api/v1/Controllers/IconController.php b/app/Api/v1/Controllers/IconController.php index 9cd884ae..961c4b2e 100644 --- a/app/Api/v1/Controllers/IconController.php +++ b/app/Api/v1/Controllers/IconController.php @@ -62,7 +62,7 @@ class IconController extends Controller : 'regular'; $icon = LogoLib::driver($iconCollection)->getIcon($validated['service'], $variant); - + return $icon ? response()->json(['filename' => $icon], 201) : response()->json(null, 204); diff --git a/app/Api/v1/Requests/IconFetchRequest.php b/app/Api/v1/Requests/IconFetchRequest.php index cfba5a22..4887933d 100644 --- a/app/Api/v1/Requests/IconFetchRequest.php +++ b/app/Api/v1/Requests/IconFetchRequest.php @@ -31,7 +31,7 @@ class IconFetchRequest extends FormRequest 'sometimes', 'required', 'string', - ] + ], ]; if ($this->input('iconCollection', null) === 'selfh') { diff --git a/app/Console/Commands/Install.php b/app/Console/Commands/Install.php index 77bafcaa..b1213db6 100644 --- a/app/Console/Commands/Install.php +++ b/app/Console/Commands/Install.php @@ -1,4 +1,5 @@ error(sprintf('%s record%s could not be fixed, see log above for details.', $error, $error > 1 ? 's' : '')); } - //$this->line('Task completed'); + // $this->line('Task completed'); } else { $this->components->warn('No fix applied.'); $this->line('You can re-run this command at any time to fix inconsistent records.'); diff --git a/app/Http/Controllers/Auth/PersonalAccessTokenController.php b/app/Http/Controllers/Auth/PersonalAccessTokenController.php index 2057dc55..21cea2e3 100644 --- a/app/Http/Controllers/Auth/PersonalAccessTokenController.php +++ b/app/Http/Controllers/Auth/PersonalAccessTokenController.php @@ -2,9 +2,9 @@ namespace App\Http\Controllers\Auth; -use Laravel\Passport\Http\Controllers\PersonalAccessTokenController as PassportPatController; use Illuminate\Http\Request; use Illuminate\Support\Facades\Gate; +use Laravel\Passport\Http\Controllers\PersonalAccessTokenController as PassportPatController; use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException; class PersonalAccessTokenController extends PassportPatController @@ -12,7 +12,6 @@ class PersonalAccessTokenController extends PassportPatController /** * Get all of the personal access tokens for the authenticated user. * - * @param \Illuminate\Http\Request $request * @return \Illuminate\Database\Eloquent\Collection|\Illuminate\Http\JsonResponse */ public function forUser(Request $request) @@ -20,14 +19,13 @@ class PersonalAccessTokenController extends PassportPatController if (Gate::denies('manage-pat')) { throw new AccessDeniedHttpException(__('errors.unsupported_with_sso_only')); } - + return parent::forUser($request); } /** * Create a new personal access token for the user. * - * @param \Illuminate\Http\Request $request * @return \Laravel\Passport\PersonalAccessTokenResult|\Illuminate\Http\JsonResponse */ public function store(Request $request) @@ -42,7 +40,6 @@ class PersonalAccessTokenController extends PassportPatController /** * Delete the given token. * - * @param \Illuminate\Http\Request $request * @param string $tokenId * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse */ @@ -54,6 +51,4 @@ class PersonalAccessTokenController extends PassportPatController return parent::destroy($request, $tokenId); } - - -} \ No newline at end of file +} diff --git a/app/Http/Controllers/Auth/WebAuthnManageController.php b/app/Http/Controllers/Auth/WebAuthnManageController.php index 90bfce93..1bbbf127 100644 --- a/app/Http/Controllers/Auth/WebAuthnManageController.php +++ b/app/Http/Controllers/Auth/WebAuthnManageController.php @@ -21,7 +21,7 @@ class WebAuthnManageController extends Controller if (Gate::denies('manage-webauthn-credentials')) { throw new AccessDeniedHttpException(__('errors.unsupported_with_sso_only')); } - + $allUserCredentials = $request->user()->webAuthnCredentials()->WhereEnabled()->get(); return response()->json($allUserCredentials, 200); @@ -52,7 +52,7 @@ class WebAuthnManageController extends Controller public function delete(Request $request, $credential) { Log::info('Deletion of security device requested'); - + if (Gate::denies('manage-webauthn-credentials')) { throw new AccessDeniedHttpException(__('errors.unsupported_with_sso_only')); } diff --git a/app/Http/Middleware/CustomCreateFreshApiToken.php b/app/Http/Middleware/CustomCreateFreshApiToken.php index 95b98cc6..8a5a83c1 100644 --- a/app/Http/Middleware/CustomCreateFreshApiToken.php +++ b/app/Http/Middleware/CustomCreateFreshApiToken.php @@ -2,7 +2,7 @@ namespace App\Http\Middleware; -use Laravel\Passport\Http\Middleware\CreateFreshApiToken as CreateFreshApiToken; +use Laravel\Passport\Http\Middleware\CreateFreshApiToken; class CustomCreateFreshApiToken extends CreateFreshApiToken { diff --git a/app/Http/Requests/WebauthnAttestationRequest.php b/app/Http/Requests/WebauthnAttestationRequest.php index f193a643..30802d25 100644 --- a/app/Http/Requests/WebauthnAttestationRequest.php +++ b/app/Http/Requests/WebauthnAttestationRequest.php @@ -20,11 +20,11 @@ class WebauthnAttestationRequest extends AttestationRequest { throw new AccessDeniedHttpException(__('errors.unsupported_with_sso_only')); } - + /** * Determine if the user is authorized to make this request. */ - public function authorize(?WebAuthnAuthenticatable $user): bool + public function authorize(?WebAuthnAuthenticatable $user) : bool { return (bool) $user && Gate::allows('manage-webauthn-credentials'); } diff --git a/app/Http/Requests/WebauthnAttestedRequest.php b/app/Http/Requests/WebauthnAttestedRequest.php index b22be57f..5aeef1f9 100644 --- a/app/Http/Requests/WebauthnAttestedRequest.php +++ b/app/Http/Requests/WebauthnAttestedRequest.php @@ -20,11 +20,11 @@ class WebauthnAttestedRequest extends AttestedRequest { throw new AccessDeniedHttpException(__('errors.unsupported_with_sso_only')); } - + /** * Determine if the user is authorized to make this request. */ - public function authorize(?WebAuthnAuthenticatable $user): bool + public function authorize(?WebAuthnAuthenticatable $user) : bool { return (bool) $user && Gate::allows('manage-webauthn-credentials'); } diff --git a/app/Providers/Socialite/OpenId.php b/app/Providers/Socialite/OpenId.php index 652a3150..20076108 100644 --- a/app/Providers/Socialite/OpenId.php +++ b/app/Providers/Socialite/OpenId.php @@ -3,7 +3,6 @@ namespace App\Providers\Socialite; use GuzzleHttp\RequestOptions; -use Illuminate\Http\Request; use Laravel\Socialite\Two\ProviderInterface; use SocialiteProviders\Manager\OAuth2\AbstractProvider; use SocialiteProviders\Manager\OAuth2\User; diff --git a/app/Services/Auth/ReverseProxyGuard.php b/app/Services/Auth/ReverseProxyGuard.php index 75ace2f2..84d7caa9 100644 --- a/app/Services/Auth/ReverseProxyGuard.php +++ b/app/Services/Auth/ReverseProxyGuard.php @@ -49,7 +49,7 @@ class ReverseProxyGuard implements Guard try { $identifier['id'] = request()->server($remoteUserHeader) ?? apache_request_headers()[$remoteUserHeader] ?? null; - } catch (\Throwable $e) { //@codeCoverageIgnore + } catch (\Throwable $e) { // @codeCoverageIgnore // Do nothing } diff --git a/app/Services/LogoLib/AbstractLogoLib.php b/app/Services/LogoLib/AbstractLogoLib.php index 247a674f..f3159673 100644 --- a/app/Services/LogoLib/AbstractLogoLib.php +++ b/app/Services/LogoLib/AbstractLogoLib.php @@ -3,7 +3,6 @@ namespace App\Services\LogoLib; use App\Facades\IconStore; -use App\Services\LogoLib\LogoLibInterface; use Illuminate\Support\Facades\Auth; use Illuminate\Support\Facades\Http; use Illuminate\Support\Facades\Log; @@ -38,7 +37,7 @@ abstract class AbstractLogoLib implements LogoLibInterface * @param string|null $variant The theme variant to fetch (light, dark, etc...) * @return string|null The icon filename or null if no logo has been found */ - public function getIcon(?string $serviceName, string $variant = null) : string|null + public function getIcon(?string $serviceName, ?string $variant = null) : ?string { $this->setVariant($variant); $logoFilename = $this->getLogo(strval($serviceName)); @@ -86,7 +85,7 @@ abstract class AbstractLogoLib implements LogoLibInterface protected function strictFetch() : bool { return Auth::user() - ? (bool)Auth::user()->preferences['iconVariantStrictFetch'] + ? (bool) Auth::user()->preferences['iconVariantStrictFetch'] : false; } @@ -122,7 +121,7 @@ abstract class AbstractLogoLib implements LogoLibInterface case 'dark': $suffix = '-dark'; break; - + default: $suffix = ''; break; diff --git a/app/Services/LogoLib/DashboardiconsLogoLib.php b/app/Services/LogoLib/DashboardiconsLogoLib.php index c809be4d..01b68588 100644 --- a/app/Services/LogoLib/DashboardiconsLogoLib.php +++ b/app/Services/LogoLib/DashboardiconsLogoLib.php @@ -2,9 +2,6 @@ namespace App\Services\LogoLib; -use App\Services\LogoLib\AbstractLogoLib; -use App\Services\LogoLib\LogoLibInterface; - class DashboardiconsLogoLib extends AbstractLogoLib implements LogoLibInterface { /** @@ -16,5 +13,4 @@ class DashboardiconsLogoLib extends AbstractLogoLib implements LogoLibInterface * Base url of the icon collection */ protected string $libUrl = 'https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/'; - } diff --git a/app/Services/LogoLib/LogoLibInterface.php b/app/Services/LogoLib/LogoLibInterface.php index 94f84fa2..cff13196 100644 --- a/app/Services/LogoLib/LogoLibInterface.php +++ b/app/Services/LogoLib/LogoLibInterface.php @@ -4,5 +4,5 @@ namespace App\Services\LogoLib; interface LogoLibInterface { - public function getIcon(?string $serviceName, string $variant = null): string|null; -} \ No newline at end of file + public function getIcon(?string $serviceName, ?string $variant = null) : ?string; +} diff --git a/app/Services/LogoLib/LogoLibManager.php b/app/Services/LogoLib/LogoLibManager.php index 1ca19383..158fdaa5 100644 --- a/app/Services/LogoLib/LogoLibManager.php +++ b/app/Services/LogoLib/LogoLibManager.php @@ -13,16 +13,16 @@ class LogoLibManager extends Manager public function createTfaDriver() : TfaLogoLib { - return new TfaLogoLib(); + return new TfaLogoLib; } public function createSelfhDriver() : SelfhLogoLib { - return new SelfhLogoLib(); + return new SelfhLogoLib; } public function createDashboardiconsDriver() : DashboardiconsLogoLib { - return new DashboardiconsLogoLib(); + return new DashboardiconsLogoLib; } } diff --git a/app/Services/LogoLib/SelfhLogoLib.php b/app/Services/LogoLib/SelfhLogoLib.php index 034600cf..43536078 100644 --- a/app/Services/LogoLib/SelfhLogoLib.php +++ b/app/Services/LogoLib/SelfhLogoLib.php @@ -2,9 +2,6 @@ namespace App\Services\LogoLib; -use App\Services\LogoLib\AbstractLogoLib; -use App\Services\LogoLib\LogoLibInterface; - class SelfhLogoLib extends AbstractLogoLib implements LogoLibInterface { /** diff --git a/app/Services/LogoLib/TfaLogoLib.php b/app/Services/LogoLib/TfaLogoLib.php index 29ee85f1..165e72c7 100644 --- a/app/Services/LogoLib/TfaLogoLib.php +++ b/app/Services/LogoLib/TfaLogoLib.php @@ -2,8 +2,6 @@ namespace App\Services\LogoLib; -use App\Services\LogoLib\AbstractLogoLib; -use App\Services\LogoLib\LogoLibInterface; use Illuminate\Support\Collection; use Illuminate\Support\Facades\Http; use Illuminate\Support\Facades\Log; @@ -26,9 +24,6 @@ class TfaLogoLib extends AbstractLogoLib implements LogoLibInterface */ const TFA_JSON_URL = 'https://2fa.directory/api/v3/tfa.json'; - /** - * @var string - */ protected string $libUrl = 'https://raw.githubusercontent.com/2factorauth/twofactorauth/master/img/'; /** @@ -37,7 +32,7 @@ class TfaLogoLib extends AbstractLogoLib implements LogoLibInterface public function __construct() { $this->setTfaCollection(); - } + } /** * Fetch a logo for the given service and save it as an icon @@ -45,7 +40,7 @@ class TfaLogoLib extends AbstractLogoLib implements LogoLibInterface * @param string|null $serviceName Name of the service to fetch a logo for * @return string|null The icon filename or null if no logo has been found */ - public function getIcon(?string $serviceName, string $variant = null) : string|null + public function getIcon(?string $serviceName, ?string $variant = null) : ?string { $logoFilename = $this->getLogo(strval($serviceName)); @@ -74,8 +69,8 @@ class TfaLogoLib extends AbstractLogoLib implements LogoLibInterface */ protected function getLogo(string $serviceName) { - $referenceName = $this->tfas->get($this->sanitizeServiceName(strval($serviceName))); - $logoFilename = $referenceName . '.' . $this->format; + $referenceName = $this->tfas->get($this->sanitizeServiceName(strval($serviceName))); + $logoFilename = $referenceName . '.' . $this->format; $cachedFilename = $this->cachePrefix . $logoFilename; if ($referenceName && ! Storage::disk('logos')->exists($cachedFilename)) { diff --git a/routes/web.php b/routes/web.php index 614a5620..2c51e6ef 100644 --- a/routes/web.php +++ b/routes/web.php @@ -109,7 +109,7 @@ Route::withoutMiddleware([ SetLanguage::class, CustomCreateFreshApiToken::class, ])->get('/up', function () { - //Event::dispatch(new DiagnosingHealth); + // Event::dispatch(new DiagnosingHealth); return view('health', [ 'isSecure' => str_starts_with(config('app.url'), 'https'), ]); diff --git a/tests/Api/v1/Controllers/Auth/UserControllerTest.php b/tests/Api/v1/Controllers/Auth/UserControllerTest.php index 3b467a00..7af307db 100644 --- a/tests/Api/v1/Controllers/Auth/UserControllerTest.php +++ b/tests/Api/v1/Controllers/Auth/UserControllerTest.php @@ -27,7 +27,7 @@ class UserControllerTest extends FeatureTestCase 'locked', ]; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Controllers/GroupControllerTest.php b/tests/Api/v1/Controllers/GroupControllerTest.php index 4ed75e14..a49bd83f 100644 --- a/tests/Api/v1/Controllers/GroupControllerTest.php +++ b/tests/Api/v1/Controllers/GroupControllerTest.php @@ -53,7 +53,7 @@ class GroupControllerTest extends FeatureTestCase private const NEW_GROUP_NAME = 'MyNewGroup'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Controllers/IconControllerTest.php b/tests/Api/v1/Controllers/IconControllerTest.php index 6722e632..eab28d09 100644 --- a/tests/Api/v1/Controllers/IconControllerTest.php +++ b/tests/Api/v1/Controllers/IconControllerTest.php @@ -29,7 +29,7 @@ class IconControllerTest extends FeatureTestCase */ protected $user; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Controllers/QrCodeControllerTest.php b/tests/Api/v1/Controllers/QrCodeControllerTest.php index 4d43da6a..3c5cd06a 100644 --- a/tests/Api/v1/Controllers/QrCodeControllerTest.php +++ b/tests/Api/v1/Controllers/QrCodeControllerTest.php @@ -28,7 +28,7 @@ class QrCodeControllerTest extends FeatureTestCase */ protected $twofaccount; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Controllers/SettingControllerTest.php b/tests/Api/v1/Controllers/SettingControllerTest.php index dfec6b49..aa89c506 100644 --- a/tests/Api/v1/Controllers/SettingControllerTest.php +++ b/tests/Api/v1/Controllers/SettingControllerTest.php @@ -45,7 +45,7 @@ class SettingControllerTest extends FeatureTestCase private const USER_DEFINED_SETTING_CHANGED_VALUE = 'mySetting'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Controllers/TwoFAccountControllerTest.php b/tests/Api/v1/Controllers/TwoFAccountControllerTest.php index e2130b64..dc9fc806 100644 --- a/tests/Api/v1/Controllers/TwoFAccountControllerTest.php +++ b/tests/Api/v1/Controllers/TwoFAccountControllerTest.php @@ -233,7 +233,7 @@ class TwoFAccountControllerTest extends FeatureTestCase 'secret' => OtpTestData::SECRET, ]; - public function setUp() : void + protected function setUp() : void { parent::setUp(); @@ -400,7 +400,7 @@ class TwoFAccountControllerTest extends FeatureTestCase ->assertJsonStructure(self::VALID_RESOURCE_STRUCTURE_WITHOUT_SECRET); } - //#[Test] + // #[Test] // public function test_show_twofaccount_with_indeciphered_data_returns_replaced_data() // { // $dbEncryptionService = resolve('App\Services\DbEncryptionService'); diff --git a/tests/Api/v1/Controllers/UserManagerControllerTest.php b/tests/Api/v1/Controllers/UserManagerControllerTest.php index 4b7afb5a..ee47a0bf 100644 --- a/tests/Api/v1/Controllers/UserManagerControllerTest.php +++ b/tests/Api/v1/Controllers/UserManagerControllerTest.php @@ -57,7 +57,7 @@ class UserManagerControllerTest extends FeatureTestCase private const PASSWORD = 'password'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Requests/GroupAssignRequestTest.php b/tests/Api/v1/Requests/GroupAssignRequestTest.php index f58d97e4..04f8ead0 100644 --- a/tests/Api/v1/Requests/GroupAssignRequestTest.php +++ b/tests/Api/v1/Requests/GroupAssignRequestTest.php @@ -37,7 +37,7 @@ class GroupAssignRequestTest extends TestCase { $request = new GroupAssignRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); diff --git a/tests/Api/v1/Requests/GroupStoreRequestTest.php b/tests/Api/v1/Requests/GroupStoreRequestTest.php index a71360cf..21f71e43 100644 --- a/tests/Api/v1/Requests/GroupStoreRequestTest.php +++ b/tests/Api/v1/Requests/GroupStoreRequestTest.php @@ -29,7 +29,7 @@ class GroupStoreRequestTest extends FeatureTestCase const UNIQUE_GROUP_NAME = 'MyGroup'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Api/v1/Requests/IconFetchRequestTest.php b/tests/Api/v1/Requests/IconFetchRequestTest.php index fbcf9e52..39f3883e 100644 --- a/tests/Api/v1/Requests/IconFetchRequestTest.php +++ b/tests/Api/v1/Requests/IconFetchRequestTest.php @@ -56,51 +56,51 @@ class IconFetchRequestTest extends TestCase 'service' => '~string.with-sp3ci@l-ch4rs', ]], 'VALID_SELFH_ICON_COLLECTION' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'selfh', ]], 'VALID_DASHBOARDICONS_ICON_COLLECTION' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'dashboardicons', ]], 'VALID_TFA_ICON_COLLECTION' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'tfa', ]], 'VALID_SELFH_ICON_COLLECTION_WITH_VALID_REGULAR_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'selfh', - 'variant' => 'regular', + 'variant' => 'regular', ]], 'VALID_SELFH_ICON_COLLECTION_WITH_VALID_LIGHT_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'selfh', - 'variant' => 'light', + 'variant' => 'light', ]], 'VALID_SELFH_ICON_COLLECTION_WITH_VALID_DARK_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'selfh', - 'variant' => 'dark', + 'variant' => 'dark', ]], 'VALID_DASHBOARDICONS_ICON_COLLECTION_WITH_VALID_REGULAR_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'dashboardicons', - 'variant' => 'regular', + 'variant' => 'regular', ]], 'VALID_DASHBOARDICONS_ICON_COLLECTION_WITH_VALID_LIGHT_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'dashboardicons', - 'variant' => 'light', + 'variant' => 'light', ]], 'VALID_DASHBOARDICONS_ICON_COLLECTION_WITH_VALID_DARK_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'dashboardicons', - 'variant' => 'dark', + 'variant' => 'dark', ]], 'VALID_TFA_ICON_COLLECTION_WITH_VALID_REGULAR_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'tfa', - 'variant' => 'regular', + 'variant' => 'regular', ]], ]; } @@ -127,22 +127,22 @@ class IconFetchRequestTest extends TestCase 'service' => null, ]], 'NULL_ICON_COLLECTION' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => null, ]], 'NULL_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'tfa', - 'variant' => null, + 'variant' => null, ]], 'EMPTY_ICON_COLLECTION' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => '', ]], 'EMPTY_VARIANT' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'tfa', - 'variant' => '', + 'variant' => '', ]], 'SERVICE_AS_INT' => [[ 'service' => 0, @@ -154,23 +154,23 @@ class IconFetchRequestTest extends TestCase 'service' => [], ]], 'NOT_IN_ICON_COLLECTION_LIST' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'string_not_in_icon_collection_list', ]], 'NOT_IN_SELFH_VARIANT_LIST' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'selfh', - 'variant' => 'string_not_in_selfh_variant_list', + 'variant' => 'string_not_in_selfh_variant_list', ]], 'NOT_IN_DASHBOARDICONS_VARIANT_LIST' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'dashboardicons', - 'variant' => 'string_not_in_dashboardicons_variant_list', + 'variant' => 'string_not_in_dashboardicons_variant_list', ]], 'NOT_IN_TFA_VARIANT_LIST' => [[ - 'service' => 'validWord', + 'service' => 'validWord', 'iconCollection' => 'tfa', - 'variant' => 'string_not_in_tfa_variant_list', + 'variant' => 'string_not_in_tfa_variant_list', ]], ]; } diff --git a/tests/Api/v1/Requests/QrCodeDecodeRequestTest.php b/tests/Api/v1/Requests/QrCodeDecodeRequestTest.php index 2713c247..cabf7dac 100644 --- a/tests/Api/v1/Requests/QrCodeDecodeRequestTest.php +++ b/tests/Api/v1/Requests/QrCodeDecodeRequestTest.php @@ -38,7 +38,7 @@ class QrCodeDecodeRequestTest extends TestCase { $request = new QrCodeDecodeRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -64,7 +64,7 @@ class QrCodeDecodeRequestTest extends TestCase { $request = new QrCodeDecodeRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/SettingStoreRequestTest.php b/tests/Api/v1/Requests/SettingStoreRequestTest.php index a009feeb..95d6b4f3 100644 --- a/tests/Api/v1/Requests/SettingStoreRequestTest.php +++ b/tests/Api/v1/Requests/SettingStoreRequestTest.php @@ -40,7 +40,7 @@ class SettingStoreRequestTest extends FeatureTestCase { $request = new SettingStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -75,7 +75,7 @@ class SettingStoreRequestTest extends FeatureTestCase $request = new SettingStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/SettingUpdateRequestTest.php b/tests/Api/v1/Requests/SettingUpdateRequestTest.php index a7808e89..cc997355 100644 --- a/tests/Api/v1/Requests/SettingUpdateRequestTest.php +++ b/tests/Api/v1/Requests/SettingUpdateRequestTest.php @@ -37,7 +37,7 @@ class SettingUpdateRequestTest extends TestCase { $request = new SettingUpdateRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -67,7 +67,7 @@ class SettingUpdateRequestTest extends TestCase { $request = new SettingUpdateRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountBatchRequestTest.php b/tests/Api/v1/Requests/TwoFAccountBatchRequestTest.php index 24e182e1..859cb020 100644 --- a/tests/Api/v1/Requests/TwoFAccountBatchRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountBatchRequestTest.php @@ -38,7 +38,7 @@ class TwoFAccountBatchRequestTest extends TestCase { $request = new TwoFAccountBatchRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -50,7 +50,7 @@ class TwoFAccountBatchRequestTest extends TestCase { $request = new TwoFAccountBatchRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountExportRequestTest.php b/tests/Api/v1/Requests/TwoFAccountExportRequestTest.php index cf9a20bd..422d9dcf 100644 --- a/tests/Api/v1/Requests/TwoFAccountExportRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountExportRequestTest.php @@ -37,7 +37,7 @@ class TwoFAccountExportRequestTest extends TestCase { $request = new TwoFAccountExportRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -85,7 +85,7 @@ class TwoFAccountExportRequestTest extends TestCase { $request = new TwoFAccountExportRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountImportRequestTest.php b/tests/Api/v1/Requests/TwoFAccountImportRequestTest.php index 3d3e105f..09388da5 100644 --- a/tests/Api/v1/Requests/TwoFAccountImportRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountImportRequestTest.php @@ -37,7 +37,7 @@ class TwoFAccountImportRequestTest extends TestCase { $request = new TwoFAccountImportRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -61,7 +61,7 @@ class TwoFAccountImportRequestTest extends TestCase { $request = new TwoFAccountImportRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountIndexRequestTest.php b/tests/Api/v1/Requests/TwoFAccountIndexRequestTest.php index f43d5917..5c10c4f8 100644 --- a/tests/Api/v1/Requests/TwoFAccountIndexRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountIndexRequestTest.php @@ -38,7 +38,7 @@ class TwoFAccountIndexRequestTest extends TestCase { $request = new TwoFAccountIndexRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -50,7 +50,7 @@ class TwoFAccountIndexRequestTest extends TestCase { $request = new TwoFAccountIndexRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountReorderRequestTest.php b/tests/Api/v1/Requests/TwoFAccountReorderRequestTest.php index 97f78f67..958ddf6a 100644 --- a/tests/Api/v1/Requests/TwoFAccountReorderRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountReorderRequestTest.php @@ -37,7 +37,7 @@ class TwoFAccountReorderRequestTest extends TestCase { $request = new TwoFAccountReorderRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -64,7 +64,7 @@ class TwoFAccountReorderRequestTest extends TestCase { $request = new TwoFAccountReorderRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountStoreRequestTest.php b/tests/Api/v1/Requests/TwoFAccountStoreRequestTest.php index f8062717..e3ab7159 100644 --- a/tests/Api/v1/Requests/TwoFAccountStoreRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountStoreRequestTest.php @@ -39,7 +39,7 @@ class TwoFAccountStoreRequestTest extends TestCase { $request = new TwoFAccountStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -115,7 +115,7 @@ class TwoFAccountStoreRequestTest extends TestCase { $request = new TwoFAccountStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountUpdateRequestTest.php b/tests/Api/v1/Requests/TwoFAccountUpdateRequestTest.php index e8eb35f4..c4f54846 100644 --- a/tests/Api/v1/Requests/TwoFAccountUpdateRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountUpdateRequestTest.php @@ -39,7 +39,7 @@ class TwoFAccountUpdateRequestTest extends TestCase { $request = new TwoFAccountUpdateRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -91,7 +91,7 @@ class TwoFAccountUpdateRequestTest extends TestCase { $request = new TwoFAccountUpdateRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/TwoFAccountUriRequestTest.php b/tests/Api/v1/Requests/TwoFAccountUriRequestTest.php index 6cde0426..d5a85a4a 100644 --- a/tests/Api/v1/Requests/TwoFAccountUriRequestTest.php +++ b/tests/Api/v1/Requests/TwoFAccountUriRequestTest.php @@ -37,7 +37,7 @@ class TwoFAccountUriRequestTest extends TestCase { $request = new TwoFAccountUriRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -68,7 +68,7 @@ class TwoFAccountUriRequestTest extends TestCase { $request = new TwoFAccountUriRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/UserManagerPromoteRequestTest.php b/tests/Api/v1/Requests/UserManagerPromoteRequestTest.php index 3f730d17..6e7920ff 100644 --- a/tests/Api/v1/Requests/UserManagerPromoteRequestTest.php +++ b/tests/Api/v1/Requests/UserManagerPromoteRequestTest.php @@ -37,7 +37,7 @@ class UserManagerPromoteRequestTest extends TestCase { $request = new UserManagerPromoteRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -70,7 +70,7 @@ class UserManagerPromoteRequestTest extends TestCase { $request = new UserManagerPromoteRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Api/v1/Requests/UserManagerStoreRequestTest.php b/tests/Api/v1/Requests/UserManagerStoreRequestTest.php index c3b75e00..aadd1632 100644 --- a/tests/Api/v1/Requests/UserManagerStoreRequestTest.php +++ b/tests/Api/v1/Requests/UserManagerStoreRequestTest.php @@ -43,7 +43,7 @@ class UserManagerStoreRequestTest extends FeatureTestCase $request = new UserManagerStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -83,7 +83,7 @@ class UserManagerStoreRequestTest extends FeatureTestCase $request = new UserManagerStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Data/CommonDataProvider.php b/tests/Data/CommonDataProvider.php index 1749a62c..f9524f1f 100644 --- a/tests/Data/CommonDataProvider.php +++ b/tests/Data/CommonDataProvider.php @@ -11,9 +11,13 @@ use App\Services\LogoLib\TfaLogoLib; final class CommonDataProvider { const TFA_URL = 'https://raw.githubusercontent.com/2factorauth/twofactorauth/master/img/*'; + const SELFH_URL_ROOT = 'https://cdn.jsdelivr.net/gh/selfhst/icons/'; + const SELFH_URL = self::SELFH_URL_ROOT . '*'; + const DASHBOARDICONS_URL_ROOT = 'https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/'; + const DASHBOARDICONS_URL = self::DASHBOARDICONS_URL_ROOT . '*'; public static function iconsCollectionProvider() : array @@ -22,7 +26,7 @@ final class CommonDataProvider 'TFA' => [[ 'name' => 'tfa', 'class' => TfaLogoLib::class, - + ]], 'SELFH' => [[ 'name' => 'selfh', @@ -34,5 +38,4 @@ final class CommonDataProvider ]], ]; } - } diff --git a/tests/Feature/Console/FixServiceFieldEncryptionTest.php b/tests/Feature/Console/FixServiceFieldEncryptionTest.php index 5fb66e86..8b8beb40 100644 --- a/tests/Feature/Console/FixServiceFieldEncryptionTest.php +++ b/tests/Feature/Console/FixServiceFieldEncryptionTest.php @@ -32,7 +32,7 @@ class FixServiceFieldEncryptionTest extends FeatureTestCase */ protected $command = '2fauth:fix-service-encryption'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Console/PurgeLogTest.php b/tests/Feature/Console/PurgeLogTest.php index e72ed5cf..c3f45ef3 100644 --- a/tests/Feature/Console/PurgeLogTest.php +++ b/tests/Feature/Console/PurgeLogTest.php @@ -16,7 +16,7 @@ class PurgeLogTest extends FeatureTestCase */ protected $user; - public function setUp() : void + protected function setUp() : void { parent::setUp(); @@ -24,14 +24,14 @@ class PurgeLogTest extends FeatureTestCase } #[Test] - public function test_purgeLog_completes() + public function test_purge_log_completes() { $this->artisan('2fauth:purge-log') ->assertSuccessful(); } #[Test] - public function test_purgeLog_defaults_to_one_year() + public function test_purge_log_defaults_to_one_year() { $oneYearOldLog = AuthLog::factory()->daysAgo(366)->for($this->user, 'authenticatable')->create(); $sixMonthsOldLog = AuthLog::factory()->daysAgo(364)->for($this->user, 'authenticatable')->create(); diff --git a/tests/Feature/Http/Auth/LoginTest.php b/tests/Feature/Http/Auth/LoginTest.php index 3b5489a1..7580c778 100644 --- a/tests/Feature/Http/Auth/LoginTest.php +++ b/tests/Feature/Http/Auth/LoginTest.php @@ -69,7 +69,7 @@ class LoginTest extends FeatureTestCase private const USER_EMAIL = 'john@example.com'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Auth/PasswordControllerTest.php b/tests/Feature/Http/Auth/PasswordControllerTest.php index 5676f656..b08eb0b0 100644 --- a/tests/Feature/Http/Auth/PasswordControllerTest.php +++ b/tests/Feature/Http/Auth/PasswordControllerTest.php @@ -30,7 +30,7 @@ class PasswordControllerTest extends FeatureTestCase private const REVERSE_PROXY_GUARD = 'reverse-proxy-guard'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Auth/RegisterControllerTest.php b/tests/Feature/Http/Auth/RegisterControllerTest.php index e55132ae..b9ea5911 100644 --- a/tests/Feature/Http/Auth/RegisterControllerTest.php +++ b/tests/Feature/Http/Auth/RegisterControllerTest.php @@ -34,7 +34,7 @@ class RegisterControllerTest extends FeatureTestCase private const EMAIL_FILTERING_RULE = '^[A-Za-z0-9._%+-]+@example\.org'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); } diff --git a/tests/Feature/Http/Auth/SocialiteControllerTest.php b/tests/Feature/Http/Auth/SocialiteControllerTest.php index 38f278db..99618a88 100644 --- a/tests/Feature/Http/Auth/SocialiteControllerTest.php +++ b/tests/Feature/Http/Auth/SocialiteControllerTest.php @@ -39,7 +39,7 @@ class SocialiteControllerTest extends FeatureTestCase private const USER_EMAIL = 'john@provider.com'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); @@ -83,7 +83,7 @@ class SocialiteControllerTest extends FeatureTestCase #[Test] public function test_redirect_returns_error_when_sso_provider_client_id_is_missing() { - //Settings::set('enableSso', true); + // Settings::set('enableSso', true); config(['services.github.client_id' => null], true); $response = $this->get('/socialite/redirect/github'); diff --git a/tests/Feature/Http/Auth/UserControllerTest.php b/tests/Feature/Http/Auth/UserControllerTest.php index b1c839e7..bb6bae3a 100644 --- a/tests/Feature/Http/Auth/UserControllerTest.php +++ b/tests/Feature/Http/Auth/UserControllerTest.php @@ -34,7 +34,7 @@ class UserControllerTest extends FeatureTestCase private const PASSWORD = 'password'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Auth/WebAuthnDeviceLostControllerTest.php b/tests/Feature/Http/Auth/WebAuthnDeviceLostControllerTest.php index 49b128ab..07dab852 100644 --- a/tests/Feature/Http/Auth/WebAuthnDeviceLostControllerTest.php +++ b/tests/Feature/Http/Auth/WebAuthnDeviceLostControllerTest.php @@ -32,7 +32,7 @@ class WebAuthnDeviceLostControllerTest extends FeatureTestCase */ protected $user; - public function setUp() : void + protected function setUp() : void { parent::setUp(); @@ -40,7 +40,7 @@ class WebAuthnDeviceLostControllerTest extends FeatureTestCase } #[Test] - public function test_sendRecoveryEmail_sends_notification_on_success() + public function test_send_recovery_email_sends_notification_on_success() { Notification::fake(); diff --git a/tests/Feature/Http/Auth/WebAuthnLoginControllerTest.php b/tests/Feature/Http/Auth/WebAuthnLoginControllerTest.php index 14763dac..c633b8be 100644 --- a/tests/Feature/Http/Auth/WebAuthnLoginControllerTest.php +++ b/tests/Feature/Http/Auth/WebAuthnLoginControllerTest.php @@ -95,7 +95,7 @@ class WebAuthnLoginControllerTest extends FeatureTestCase const ASSERTION_CHALLENGE = 'iXozmynKi+YD2iRvKNbSPA=='; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Auth/WebAuthnManageControllerTest.php b/tests/Feature/Http/Auth/WebAuthnManageControllerTest.php index b8acfd2b..70b35f8a 100644 --- a/tests/Feature/Http/Auth/WebAuthnManageControllerTest.php +++ b/tests/Feature/Http/Auth/WebAuthnManageControllerTest.php @@ -32,7 +32,7 @@ class WebAuthnManageControllerTest extends FeatureTestCase public const CREDENTIAL_ID_RAW = '+VOLFKPY+/FuMI/sJ7gMllK76L3VoRUINj6lL/Z3qDg='; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Auth/WebAuthnRecoveryControllerTest.php b/tests/Feature/Http/Auth/WebAuthnRecoveryControllerTest.php index 276ab2a0..b2d80f1f 100644 --- a/tests/Feature/Http/Auth/WebAuthnRecoveryControllerTest.php +++ b/tests/Feature/Http/Auth/WebAuthnRecoveryControllerTest.php @@ -36,7 +36,7 @@ class WebAuthnRecoveryControllerTest extends FeatureTestCase const CREDENTIAL_ID = '-VOLFKPY-_FuMI_sJ7gMllK76L3VoRUINj6lL_Z3qDg'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Auth/WebAuthnRegisterControllerTest.php b/tests/Feature/Http/Auth/WebAuthnRegisterControllerTest.php index 13b733d1..bd08a6dc 100644 --- a/tests/Feature/Http/Auth/WebAuthnRegisterControllerTest.php +++ b/tests/Feature/Http/Auth/WebAuthnRegisterControllerTest.php @@ -24,7 +24,7 @@ class WebAuthnRegisterControllerTest extends FeatureTestCase */ protected $user; - public function setUp() : void + protected function setUp() : void { parent::setUp(); @@ -32,7 +32,7 @@ class WebAuthnRegisterControllerTest extends FeatureTestCase } #[Test] - public function test_uses_attestation_with_fastRegistration_request() : void + public function test_uses_attestation_with_fast_registration_request() : void { Config::set('webauthn.user_verification', UserVerification::DISCOURAGED); diff --git a/tests/Feature/Http/Middlewares/RejectIfSsoOnlyAndNotForAdminMiddlewareTest.php b/tests/Feature/Http/Middlewares/RejectIfSsoOnlyAndNotForAdminMiddlewareTest.php index bb868fea..ac74bca8 100644 --- a/tests/Feature/Http/Middlewares/RejectIfSsoOnlyAndNotForAdminMiddlewareTest.php +++ b/tests/Feature/Http/Middlewares/RejectIfSsoOnlyAndNotForAdminMiddlewareTest.php @@ -30,7 +30,7 @@ class RejectIfSsoOnlyAndNotForAdminMiddlewareTest extends FeatureTestCase private const PASSWORD = 'password'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Http/Requests/LoginRequestTest.php b/tests/Feature/Http/Requests/LoginRequestTest.php index 203afb8d..70528e29 100644 --- a/tests/Feature/Http/Requests/LoginRequestTest.php +++ b/tests/Feature/Http/Requests/LoginRequestTest.php @@ -37,7 +37,7 @@ class LoginRequestTest extends FeatureTestCase $request = new LoginRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -70,7 +70,7 @@ class LoginRequestTest extends FeatureTestCase $request = new LoginRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Feature/Http/Requests/UserDeleteRequestTest.php b/tests/Feature/Http/Requests/UserDeleteRequestTest.php index 84a6b34f..c55e4c0c 100644 --- a/tests/Feature/Http/Requests/UserDeleteRequestTest.php +++ b/tests/Feature/Http/Requests/UserDeleteRequestTest.php @@ -37,7 +37,7 @@ class UserDeleteRequestTest extends FeatureTestCase { $request = new UserDeleteRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -61,7 +61,7 @@ class UserDeleteRequestTest extends FeatureTestCase { $request = new UserDeleteRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Feature/Http/Requests/UserPatchPwdRequestTest.php b/tests/Feature/Http/Requests/UserPatchPwdRequestTest.php index ae0f6af9..52088895 100644 --- a/tests/Feature/Http/Requests/UserPatchPwdRequestTest.php +++ b/tests/Feature/Http/Requests/UserPatchPwdRequestTest.php @@ -37,7 +37,7 @@ class UserPatchPwdRequestTest extends TestCase { $request = new UserPatchPwdRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -63,7 +63,7 @@ class UserPatchPwdRequestTest extends TestCase { $request = new UserPatchPwdRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Feature/Http/Requests/UserStoreRequestTest.php b/tests/Feature/Http/Requests/UserStoreRequestTest.php index 32917ef2..19ee1a54 100644 --- a/tests/Feature/Http/Requests/UserStoreRequestTest.php +++ b/tests/Feature/Http/Requests/UserStoreRequestTest.php @@ -38,7 +38,7 @@ class UserStoreRequestTest extends FeatureTestCase $request = new UserStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -76,7 +76,7 @@ class UserStoreRequestTest extends FeatureTestCase $request = new UserStoreRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Feature/Http/Requests/WebauthnAssertedRequestTest.php b/tests/Feature/Http/Requests/WebauthnAssertedRequestTest.php index d7068fb8..5a146424 100644 --- a/tests/Feature/Http/Requests/WebauthnAssertedRequestTest.php +++ b/tests/Feature/Http/Requests/WebauthnAssertedRequestTest.php @@ -24,7 +24,7 @@ class WebauthnAssertedRequestTest extends TestCase { $request = new WebauthnAssertedRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -57,7 +57,7 @@ class WebauthnAssertedRequestTest extends TestCase { $request = new WebauthnAssertedRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Feature/Http/Requests/WebauthnRenameRequestTest.php b/tests/Feature/Http/Requests/WebauthnRenameRequestTest.php index 6414cd54..cf177ec9 100644 --- a/tests/Feature/Http/Requests/WebauthnRenameRequestTest.php +++ b/tests/Feature/Http/Requests/WebauthnRenameRequestTest.php @@ -43,7 +43,7 @@ class WebauthnRenameRequestTest extends TestCase { $request = new WebauthnRenameRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertFalse($validator->fails()); @@ -67,7 +67,7 @@ class WebauthnRenameRequestTest extends TestCase { $request = new WebauthnRenameRequest; $request->merge($data); - + $validator = Validator::make($data, $request->rules()); $this->assertTrue($validator->fails()); diff --git a/tests/Feature/Http/SystemControllerTest.php b/tests/Feature/Http/SystemControllerTest.php index 528dad01..6beef2d7 100644 --- a/tests/Feature/Http/SystemControllerTest.php +++ b/tests/Feature/Http/SystemControllerTest.php @@ -28,7 +28,7 @@ class SystemControllerTest extends FeatureTestCase protected $admin; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Models/TwoFAccountModelTest.php b/tests/Feature/Models/TwoFAccountModelTest.php index 178c159d..bf485900 100644 --- a/tests/Feature/Models/TwoFAccountModelTest.php +++ b/tests/Feature/Models/TwoFAccountModelTest.php @@ -43,7 +43,7 @@ class TwoFAccountModelTest extends FeatureTestCase */ protected $helpers; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Notifications/FailedLoginNotificationTest.php b/tests/Feature/Notifications/FailedLoginNotificationTest.php index 541e5a8b..04fba3c8 100644 --- a/tests/Feature/Notifications/FailedLoginNotificationTest.php +++ b/tests/Feature/Notifications/FailedLoginNotificationTest.php @@ -31,7 +31,7 @@ class FailedLoginNotificationTest extends FeatureTestCase */ protected $failedLogin; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Notifications/SignedInWithNewDeviceNotificationTest.php b/tests/Feature/Notifications/SignedInWithNewDeviceNotificationTest.php index e9958473..0ad6dc9e 100644 --- a/tests/Feature/Notifications/SignedInWithNewDeviceNotificationTest.php +++ b/tests/Feature/Notifications/SignedInWithNewDeviceNotificationTest.php @@ -31,7 +31,7 @@ class SignedInWithNewDeviceNotificationTest extends FeatureTestCase */ protected $signedInWithNewDevice; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Notifications/TestEmailSettingNotificationTest.php b/tests/Feature/Notifications/TestEmailSettingNotificationTest.php index 46bd3692..f8bf3eb1 100644 --- a/tests/Feature/Notifications/TestEmailSettingNotificationTest.php +++ b/tests/Feature/Notifications/TestEmailSettingNotificationTest.php @@ -25,7 +25,7 @@ class TestEmailSettingNotificationTest extends FeatureTestCase */ protected $testEmailSettingNotification; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Notifications/WebauthnRecoveryNotificationTest.php b/tests/Feature/Notifications/WebauthnRecoveryNotificationTest.php index ce56e6c0..6df5fcef 100644 --- a/tests/Feature/Notifications/WebauthnRecoveryNotificationTest.php +++ b/tests/Feature/Notifications/WebauthnRecoveryNotificationTest.php @@ -26,7 +26,7 @@ class WebauthnRecoveryNotificationTest extends FeatureTestCase */ protected $webauthnRecoveryNotification; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Permissions/ManagePatPermissionsTest.php b/tests/Feature/Permissions/ManagePatPermissionsTest.php index 7612b5ce..60f6358a 100644 --- a/tests/Feature/Permissions/ManagePatPermissionsTest.php +++ b/tests/Feature/Permissions/ManagePatPermissionsTest.php @@ -32,7 +32,7 @@ class ManagePatPermissionsTest extends FeatureTestCase private const PASSWORD = 'password'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Permissions/ManageWebauthnPermissionsTest.php b/tests/Feature/Permissions/ManageWebauthnPermissionsTest.php index 884b7264..8ac037cb 100644 --- a/tests/Feature/Permissions/ManageWebauthnPermissionsTest.php +++ b/tests/Feature/Permissions/ManageWebauthnPermissionsTest.php @@ -34,7 +34,7 @@ class ManageWebauthnPermissionsTest extends FeatureTestCase private const PASSWORD = 'password'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Services/GroupServiceTest.php b/tests/Feature/Services/GroupServiceTest.php index a403f0a8..50bb0871 100644 --- a/tests/Feature/Services/GroupServiceTest.php +++ b/tests/Feature/Services/GroupServiceTest.php @@ -49,7 +49,7 @@ class GroupServiceTest extends FeatureTestCase private const NEW_GROUP_NAME = 'MyNewGroup'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Services/IconServiceTest.php b/tests/Feature/Services/IconServiceTest.php index dbca0824..bb35f2e3 100644 --- a/tests/Feature/Services/IconServiceTest.php +++ b/tests/Feature/Services/IconServiceTest.php @@ -30,7 +30,7 @@ class IconServiceTest extends FeatureTestCase protected IconService $iconService; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Services/IconStoreServiceTest.php b/tests/Feature/Services/IconStoreServiceTest.php index 7a062494..a751b278 100644 --- a/tests/Feature/Services/IconStoreServiceTest.php +++ b/tests/Feature/Services/IconStoreServiceTest.php @@ -33,7 +33,7 @@ class IconStoreServiceTest extends FeatureTestCase */ protected IconStoreService $iconStore; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Services/LogoLibsTest.php b/tests/Feature/Services/LogoLibsTest.php index b4c0a5d4..5cbcff5f 100644 --- a/tests/Feature/Services/LogoLibsTest.php +++ b/tests/Feature/Services/LogoLibsTest.php @@ -33,7 +33,7 @@ class LogoLibsTest extends FeatureTestCase protected LogoLibInterface $logoLib; - public function setUp() : void + protected function setUp() : void { parent::setUp(); @@ -160,14 +160,14 @@ class LogoLibsTest extends FeatureTestCase #[Test] public function test_getIcon_fallbacks_to_user_preferences_when_variant_is_omitted() { - $user = User::factory()->create(); + $user = User::factory()->create(); $user['preferences->iconVariant'] = 'dark'; $user->save(); Http::preventStrayRequests(); Http::fake([ - CommonDataProvider::SELFH_URL_ROOT . 'svg/myservice.svg' => Http::response(HttpRequestTestData::SVG_LOGO_BODY_VARIANT_REGULAR, 200), - CommonDataProvider::SELFH_URL_ROOT . 'svg/myservice-dark.svg' => Http::response(HttpRequestTestData::SVG_LOGO_BODY_VARIANT_DARK, 200), + CommonDataProvider::SELFH_URL_ROOT . 'svg/myservice.svg' => Http::response(HttpRequestTestData::SVG_LOGO_BODY_VARIANT_REGULAR, 200), + CommonDataProvider::SELFH_URL_ROOT . 'svg/myservice-dark.svg' => Http::response(HttpRequestTestData::SVG_LOGO_BODY_VARIANT_DARK, 200), ]); $this->logoLib = $this->app->make(SelfhLogoLib::class); @@ -198,13 +198,13 @@ class LogoLibsTest extends FeatureTestCase { return [ 'INVALID_VARIANT' => [ - 'not_a_valid_variant' + 'not_a_valid_variant', ], 'NULL_VARIANT' => [ - null + null, ], 'EMPTY_VARIANT' => [ - '' + '', ], ]; } diff --git a/tests/Feature/Services/QrCodeServiceTest.php b/tests/Feature/Services/QrCodeServiceTest.php index 2c762c4b..2f03afc2 100644 --- a/tests/Feature/Services/QrCodeServiceTest.php +++ b/tests/Feature/Services/QrCodeServiceTest.php @@ -30,7 +30,7 @@ class QrCodeServiceTest extends FeatureTestCase private const DECODED_IMAGE = 'otpauth://totp/test@test.com?secret=A4GRFHVIRBGY7UIW'; - public function setUp() : void + protected function setUp() : void { parent::setUp(); } diff --git a/tests/Feature/Services/ReleaseRadarServiceTest.php b/tests/Feature/Services/ReleaseRadarServiceTest.php index 67883f38..c07f3746 100644 --- a/tests/Feature/Services/ReleaseRadarServiceTest.php +++ b/tests/Feature/Services/ReleaseRadarServiceTest.php @@ -23,7 +23,7 @@ class ReleaseRadarServiceTest extends FeatureTestCase { use WithoutMiddleware; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Services/SettingServiceTest.php b/tests/Feature/Services/SettingServiceTest.php index 88e8ae96..7c160199 100644 --- a/tests/Feature/Services/SettingServiceTest.php +++ b/tests/Feature/Services/SettingServiceTest.php @@ -67,7 +67,7 @@ class SettingServiceTest extends FeatureTestCase private const TOTP_FULL_CUSTOM_URI = 'otpauth://totp/' . self::SERVICE . ':' . self::ACCOUNT . '?secret=' . self::SECRET . '&issuer=' . self::SERVICE . '&digits=' . self::DIGITS_CUSTOM . '&period=' . self::PERIOD_CUSTOM . '&algorithm=' . self::ALGORITHM_CUSTOM . '&image=' . OtpTestData::EXTERNAL_IMAGE_URL_ENCODED; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/Services/TwoFAccountServiceTest.php b/tests/Feature/Services/TwoFAccountServiceTest.php index 61a89c80..7932027d 100644 --- a/tests/Feature/Services/TwoFAccountServiceTest.php +++ b/tests/Feature/Services/TwoFAccountServiceTest.php @@ -40,7 +40,7 @@ class TwoFAccountServiceTest extends FeatureTestCase protected $userGroupB; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Feature/ViewTest.php b/tests/Feature/ViewTest.php index 3f8d96cc..b0716e4e 100644 --- a/tests/Feature/ViewTest.php +++ b/tests/Feature/ViewTest.php @@ -15,7 +15,7 @@ use Tests\FeatureTestCase; #[CoversClass(SinglePageController::class)] class ViewTest extends FeatureTestCase { - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Unit/Api/v1/Controllers/GroupControllerTest.php b/tests/Unit/Api/v1/Controllers/GroupControllerTest.php index bcc2193f..2e74fb7e 100644 --- a/tests/Unit/Api/v1/Controllers/GroupControllerTest.php +++ b/tests/Unit/Api/v1/Controllers/GroupControllerTest.php @@ -29,7 +29,7 @@ class GroupControllerTest extends TestCase */ protected $user; - public function setUp() : void + protected function setUp() : void { parent::setUp(); diff --git a/tests/Unit/MigratorTest.php b/tests/Unit/MigratorTest.php index 37f0a4e5..409a29fc 100644 --- a/tests/Unit/MigratorTest.php +++ b/tests/Unit/MigratorTest.php @@ -69,7 +69,7 @@ class MigratorTest extends TestCase protected $fakeTwofaccount; - public function setUp() : void + protected function setUp() : void { parent::setUp();