extern/2FAuth
1
0
Fork 0
mirror of https://github.com/Bubka/2FAuth.git synced 2025-06-14 08:56:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix the TwoFAccount Export feature & add related tests

Browse Source
This commit is contained in:
Bubka 2023-03-08 09:41:57 +01:00
parent af4400a74d
commit 823acde49d
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Services/TwoFAccountService.php
View File

@ -68,6 +68,8 @@ class TwoFAccountService
public static function export($ids) : Collection public static function export($ids) : Collection
{ {
$ids = Helpers::commaSeparatedToArray($ids); $ids = Helpers::commaSeparatedToArray($ids);
$ids = is_array($ids) ? $ids : func_get_args();
$twofaccounts = TwoFAccount::whereIn('id', $ids)->get(); $twofaccounts = TwoFAccount::whereIn('id', $ids)->get();
return $twofaccounts; return $twofaccounts;

35
tests/Feature/Services/TwoFAccountServiceTest.php
View File

@ -230,6 +230,41 @@ class TwoFAccountServiceTest extends FeatureTestCase
$twofaccounts = TwoFAccounts::migrate(MigrationTestData::GOOGLE_AUTH_MIGRATION_URI_WITH_INVALID_DATA); $twofaccounts = TwoFAccounts::migrate(MigrationTestData::GOOGLE_AUTH_MIGRATION_URI_WITH_INVALID_DATA);
} }
/**
* @test
*/
public function test_export_single_id_returns_collection()
{
$twofaccounts = TwoFAccounts::export($this->customTotpTwofaccount->id);
$this->assertContainsOnlyInstancesOf(TwoFAccount::class, $twofaccounts);
$this->assertObjectEquals($this->customTotpTwofaccount, $twofaccounts->first());
}
/**
* @test
*/
public function test_export_comma_separated_ids_returns_collection()
{
$twofaccounts = TwoFAccounts::export($this->customTotpTwofaccount->id . ',' . $this->customHotpTwofaccount->id);
$this->assertContainsOnlyInstancesOf(TwoFAccount::class, $twofaccounts);
$this->assertObjectEquals($this->customTotpTwofaccount, $twofaccounts->first());
$this->assertObjectEquals($this->customHotpTwofaccount, $twofaccounts->last());
}
/**
* @test
*/
public function test_export_array_of_ids_returns_collection()
{
$twofaccounts = TwoFAccounts::export([$this->customTotpTwofaccount->id, $this->customHotpTwofaccount->id]);
$this->assertContainsOnlyInstancesOf(TwoFAccount::class, $twofaccounts);
$this->assertObjectEquals($this->customTotpTwofaccount, $twofaccounts->first());
$this->assertObjectEquals($this->customHotpTwofaccount, $twofaccounts->last());
}
/** /**
* @test * @test
*/ */