From 82e0e90c79ebbfdb1dd320762d77e39202e98a62 Mon Sep 17 00:00:00 2001
From: Bubka <858858+Bubka@users.noreply.github.com>
Date: Fri, 25 Aug 2023 13:49:52 +0200
Subject: [PATCH] Make the APP_URL comment more specific and restrictive

---
 .env.example              | 8 ++++----
 Dockerfile                | 8 ++++----
 docker/docker-compose.yml | 8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/.env.example b/.env.example
index 63006bea..85c3e7f4 100644
--- a/.env.example
+++ b/.env.example
@@ -29,8 +29,8 @@ SITE_OWNER=mail@example.com
 APP_KEY=
 
 
-# This variable must match your installation's external address but keep in mind that
-# it's only used on the command line as a fallback value.
+# This variable must match your installation's external address.
+# Webauthn won't work otherwise.
 
 APP_URL=http://localhost
 
@@ -185,13 +185,13 @@ WEBAUTHN_NAME=2FAuth
 
 
 # Relying Party ID. If null, the device will fill it internally.
-# See https://webauthn-doc.spomky-labs.com/pre-requisites/the-relying-party#how-to-determine-the-relying-party-id
+# See https://webauthn-doc.spomky-labs.com/prerequisites/the-relying-party#how-to-determine-the-relying-party-id
 
 WEBAUTHN_ID=null
 
 # [DEPRECATED]
 # Optional image data in BASE64 (128 bytes maximum) or an image url
-# See https://webauthn-doc.spomky-labs.com/pre-requisites/the-relying-party#relying-party-icon
+# See https://webauthn-doc.spomky-labs.com/prerequisites/the-relying-party#relying-party-icon
 
 # WEBAUTHN_ICON=null
 # [/DEPRECATED]
diff --git a/Dockerfile b/Dockerfile
index 2ae1d32f..099d94a1 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -121,8 +121,8 @@ ENV \
     # If you generate a new one all existing data must be considered LOST.
     # Change it to a string of exactly 32 chars or use command `php artisan key:generate` to generate it
     APP_KEY=SomeRandomStringOf32CharsExactly \
-    # This variable must match your installation's external address but keep in mind that
-    # it's only used on the command line as a fallback value.
+    # This variable must match your installation's external address.
+    # Webauthn won't work otherwise.
     APP_URL=http://localhost \
     # Turn this to true if you want your app to react like a demo.
     # The Demo mode reset the app content every hours and set a generic demo user.
@@ -186,10 +186,10 @@ ENV \
     # Relying Party name, aka the name of the application. If null, defaults to APP_NAME
     WEBAUTHN_NAME=2FAuth \
     # Relying Party ID. If null, the device will fill it internally.
-    # See https://webauthn-doc.spomky-labs.com/pre-requisites/the-relying-party#how-to-determine-the-relying-party-id
+    # See https://webauthn-doc.spomky-labs.com/prerequisites/the-relying-party#how-to-determine-the-relying-party-id
     WEBAUTHN_ID=null \
     # Optional image data in BASE64 (128 bytes maximum) or an image url
-    # See https://webauthn-doc.spomky-labs.com/pre-requisites/the-relying-party#relying-party-icon
+    # See https://webauthn-doc.spomky-labs.com/prerequisites/the-relying-party#relying-party-icon
     WEBAUTHN_ICON=null \
     # Use this setting to control how user verification behave during the
     # WebAuthn authentication flow.
diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml
index ab9ed1b0..a081f250 100644
--- a/docker/docker-compose.yml
+++ b/docker/docker-compose.yml
@@ -21,8 +21,8 @@ services:
       # If you generate a new one all existing data must be considered LOST.
       # Change it to a string of exactly 32 chars or use command `php artisan key:generate` to generate it
       - APP_KEY=SomeRandomStringOf32CharsExactly
-      # This variable must match your installation's external address but keep in mind that
-      # it's only used on the command line as a fallback value.
+      # This variable must match your installation's external address.
+      # Webauthn won't work otherwise.
       - APP_URL=http://localhost
       # Turn this to true if you want your app to react like a demo.
       # The Demo mode reset the app content every hours and set a generic demo user.
@@ -84,10 +84,10 @@ services:
       # Relying Party name, aka the name of the application. If null, defaults to APP_NAME
       - WEBAUTHN_NAME=2FAuth
       # Relying Party ID. If null, the device will fill it internally.
-      # See https://webauthn-doc.spomky-labs.com/pre-requisites/the-relying-party#how-to-determine-the-relying-party-id
+      # See https://webauthn-doc.spomky-labs.com/prerequisites/the-relying-party#how-to-determine-the-relying-party-id
       - WEBAUTHN_ID=null
       # Optional image data in BASE64 (128 bytes maximum) or an image url
-      # See https://webauthn-doc.spomky-labs.com/pre-requisites/the-relying-party#relying-party-icon
+      # See https://webauthn-doc.spomky-labs.com/prerequisites/the-relying-party#relying-party-icon
       - WEBAUTHN_ICON=null
       # Use this setting to control how user verification behave during the
       # WebAuthn authentication flow.