extern/2FAuth
1
0
Fork 0
mirror of https://github.com/Bubka/2FAuth.git synced 2025-02-16 18:31:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary try|catch

Browse Source
This commit is contained in:
Bubka 2020-01-26 21:49:39 +01:00
parent 5531c0e7e1
commit c6b7c4e495
1 changed files with 33 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/Http/Controllers/TwoFAccountController.php
View File

@ -58,12 +58,9 @@ public function store(Request $request)
*/ */
public function show($id) public function show($id)
{ {
try {
$twofaccount = TwoFAccount::FindOrFail($id); $twofaccount = TwoFAccount::FindOrFail($id);
return response()->json($twofaccount, 200); return response()->json($twofaccount, 200);
} catch (\Exception $e) {
return response()->json( ['message' => 'not found' ], 404);
}
} }
@ -95,8 +92,6 @@ public function update(Request $request, $id)
'service' => 'required', 'service' => 'required',
]); ]);
try {
$twofaccount = TwoFAccount::FindOrFail($id); $twofaccount = TwoFAccount::FindOrFail($id);
if( $twofaccount->type === 'hotp' ) { if( $twofaccount->type === 'hotp' ) {
@ -129,12 +124,6 @@ public function update(Request $request, $id)
return response()->json($twofaccount, 200); return response()->json($twofaccount, 200);
} }
catch (\Exception $e) {
return response()->json( ['message' => 'not found' ] , 404);
}
}
/** /**
@ -145,7 +134,6 @@ public function update(Request $request, $id)
*/ */
public function destroy($id) public function destroy($id)
{ {
try {
$twofaccount = TwoFAccount::FindOrFail($id); $twofaccount = TwoFAccount::FindOrFail($id);
@ -156,16 +144,10 @@ public function destroy($id)
Storage::delete($storedIcon); Storage::delete($storedIcon);
} }
// delete account
$twofaccount->delete(); $twofaccount->delete();
return response()->json(null, 204); return response()->json(null, 204);
}
catch (\Exception $e) {
return response()->json(['message' => 'already gone'], 404);
}
} }
} }