extern/2FAuth
1
0
Fork 0
mirror of https://github.com/Bubka/2FAuth.git synced 2025-06-02 16:25:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change HTTP code returned for routes rejected in reverse proxy setup

Browse Source
This commit is contained in:
Bubka 2023-11-23 12:49:42 +01:00
parent 39bbc8c134
commit ee02fb5d92
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Middleware/RejectIfReverseProxy.php
View File

@ -20,7 +20,7 @@ class RejectIfReverseProxy
return response()->json([ return response()->json([
'message' => __('errors.unsupported_with_reverseproxy'), 'message' => __('errors.unsupported_with_reverseproxy'),
], 400); ], 405);
} }
return $next($request); return $next($request);

4
resources/js_vue3/views/settings/OAuth.vue
View File

@ -46,8 +46,8 @@
}) })
}) })
.catch(error => { .catch(error => {
if( error.response.status === 400 ) { if( error.response.status === 405 ) {
// The backend returns a 400 response for routes with the // The backend returns a 405 response for routes with the
// rejectIfReverseProxy middleware // rejectIfReverseProxy middleware
isRemoteUser.value = true isRemoteUser.value = true
} }

4
resources/js_vue3/views/settings/WebAuthn.vue
View File

@ -94,8 +94,8 @@
credentials.value = response.data credentials.value = response.data
}) })
.catch(error => { .catch(error => {
if( error.response.status === 400 ) { if( error.response.status === 405 ) {
// The backend returns a 400 response for routes with the // The backend returns a 405 response for routes with the
// rejectIfReverseProxy middleware // rejectIfReverseProxy middleware
isRemoteUser.value = true isRemoteUser.value = true
} }

6
tests/Feature/Http/Auth/WebAuthnManageControllerTest.php
View File

@ -136,7 +136,7 @@ class WebAuthnManageControllerTest extends FeatureTestCase
{ {
$response = $this->actingAs($this->user, 'reverse-proxy-guard') $response = $this->actingAs($this->user, 'reverse-proxy-guard')
->json('GET', '/webauthn/credentials') ->json('GET', '/webauthn/credentials')
->assertStatus(400); ->assertStatus(405);
} }
/** /**
@ -146,7 +146,7 @@ class WebAuthnManageControllerTest extends FeatureTestCase
{ {
$response = $this->actingAs($this->user, 'reverse-proxy-guard') $response = $this->actingAs($this->user, 'reverse-proxy-guard')
->json('PATCH', '/webauthn/credentials/fqsdfqsdf/name') ->json('PATCH', '/webauthn/credentials/fqsdfqsdf/name')
->assertStatus(400); ->assertStatus(405);
} }
/** /**
@ -156,7 +156,7 @@ class WebAuthnManageControllerTest extends FeatureTestCase
{ {
$response = $this->actingAs($this->user, 'reverse-proxy-guard') $response = $this->actingAs($this->user, 'reverse-proxy-guard')
->json('DELETE', '/webauthn/credentials/dcnskldjnkljsrn') ->json('DELETE', '/webauthn/credentials/dcnskldjnkljsrn')
->assertStatus(400); ->assertStatus(405);
} }
/** /**