Fix and complete tests

This commit is contained in:
Bubka
2022-03-31 08:38:35 +02:00
parent 5eee3de134
commit ee22e24cf1
34 changed files with 1179 additions and 227 deletions

View File

@@ -93,9 +93,11 @@ class UserController extends Controller
Artisan::call('passport:install --force');
Artisan::call('config:clear');
}
// @codeCoverageIgnoreStart
catch (\Throwable $e) {
return response()->json(['message' => __('errors.user_deletion_failed')], 400);
}
// @codeCoverageIgnoreEnd
return response()->json(null, 204);
}

View File

@@ -47,19 +47,4 @@ class WebAuthnDeviceLostController extends Controller
{
return response()->json(['message' => __('auth.webauthn.account_recovery_email_sent')]);
}
/**
* Get the response for a failed account recovery link.
*
* @param \Illuminate\Http\Request $request
* @param string $response
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
* @throws \Illuminate\Validation\ValidationException
*/
protected function sendRecoveryLinkFailedResponse(Request $request, string $response)
{
throw ValidationException::withMessages(['email' => [trans($response)]]);
}
}

View File

@@ -30,7 +30,7 @@ class WebAuthnLoginController extends Controller
public function options(Request $request)
{
// Since 2FAuth is single user designed we fetch the user instance
// and merge its email address to the request. This let Larapass validated
// and merge its email address to the request. This let Larapass validate
// the request against a user instance without the need to ask the visitor
// for an email address.
//
@@ -57,6 +57,8 @@ class WebAuthnLoginController extends Controller
*/
public function login(Request $request)
{
$request->validate($this->assertionRules());
if ($request->has('response')) {
$response = $request->response;

View File

@@ -59,6 +59,8 @@ class WebAuthnRecoveryController extends Controller
* @param string $response
*
* @return \Illuminate\Http\JsonResponse
*
* @codeCoverageIgnore - already covered by larapass test
*/
protected function sendRecoveryResponse(Request $request, string $response): JsonResponse
{
@@ -73,6 +75,8 @@ class WebAuthnRecoveryController extends Controller
*
* @return \Illuminate\Http\JsonResponse|void
* @throws \Illuminate\Validation\ValidationException
*
* @codeCoverageIgnore - already covered by larapass test
*/
protected function sendRecoveryFailedResponse(Request $request, string $response): JsonResponse
{