extern/KasmVNC
1
0
Fork 0
mirror of https://github.com/kasmtech/KasmVNC.git synced 2024-11-21 23:53:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Complain about missing read permissions once, as it's a typical config mistake

Browse Source
This commit is contained in:
Lauri Kasanen 2023-01-16 15:01:57 +02:00
parent 90afa1f005
commit 895b6b5697
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
common/rfb/VNCSConnectionST.cxx
View File

@ -64,7 +64,7 @@ VNCSConnectionST::VNCSConnectionST(VNCServerST* server_, network::Socket *s,
needsPermCheck(false), pointerEventTime(0),
clientHasCursor(false),
accessRights(AccessDefault), startTime(time(0)), frameTracking(false),
udpFramesSinceFull(0)
udpFramesSinceFull(0), complainedAboutNoViewRights(false)
{
setStreams(&sock->inStream(), &sock->outStream());
peerEndpoint.buf = sock->getPeerEndpoint();
@ -1308,8 +1308,14 @@ void VNCSConnectionST::writeFramebufferUpdate()
}
}
if (!(accessRights & AccessView))
if (!(accessRights & AccessView)) {
if (!complainedAboutNoViewRights) {
complainedAboutNoViewRights = true;
vlog.error("User %s has no read permissions. If this is not intended, grant them permissions with kasmvncpasswd or via the API",
user);
}
return;
}
// Updates often consists of many small writes, and in continuous
// mode, we will also have small fence messages around the update. We

1
common/rfb/VNCSConnectionST.h
View File

@ -324,6 +324,7 @@ namespace rfb {
bool frameTracking;
uint32_t udpFramesSinceFull;
bool complainedAboutNoViewRights;
};
}
#endif