KASM-3119 correct code review issues on MR

This commit is contained in:
mattmcclaskey 2022-09-07 12:54:07 +00:00
parent 3e3462a4de
commit a5b9d75d63
2 changed files with 4 additions and 4 deletions

View File

@ -23,7 +23,7 @@ fail_on_gcc_12() {
if gcc --version | head -1 | grep -q 12; then if gcc --version | head -1 | grep -q 12; then
cat >&2 <<EOF cat >&2 <<EOF
Error: gcc 12 detected. It has a bug causing the build to fall because of a Error: gcc 12 detected. It has a bug causing the build to fail because of a
-Warray-bounds bug. Please use gcc 11 in the build Dockerfile: -Warray-bounds bug. Please use gcc 11 in the build Dockerfile:
ENV CC=gcc-11 ENV CC=gcc-11
ENV CXX=g++-11 ENV CXX=g++-11
@ -44,7 +44,7 @@ cd /tmp
# default to the version of x in Ubuntu 18.04, otherwise caller will need to specify # default to the version of x in Ubuntu 18.04, otherwise caller will need to specify
XORG_VER=${XORG_VER:-"1.19.6"} XORG_VER=${XORG_VER:-"1.19.6"}
XORG_PATCH=$(echo "$XORG_VER" | grep -Po '^\d.\d+' | sed 's#\.##') XORG_PATCH=$(echo "$XORG_VER" | grep -Po '^\d.\d+' | sed 's#\.##')
wget --no-check-certificate https://www.x.org/archive/individual/xserver/xorg-server-${XORG_VER}.tar.bz2 wget https://www.x.org/archive/individual/xserver/xorg-server-${XORG_VER}.tar.bz2
#git clone https://kasmweb@bitbucket.org/kasmtech/kasmvnc.git #git clone https://kasmweb@bitbucket.org/kasmtech/kasmvnc.git
#cd kasmvnc #cd kasmvnc

View File

@ -1422,8 +1422,8 @@ static uint8_t ownerapi(ws_ctx_t *ws_ctx, const char *in, const char * const use
if (!decname[0]) if (!decname[0])
goto nope; goto nope;
uint64_t mask = 0; uint64_t mask = 0;
uint8_t myread = 0; uint8_t myread = 0;
param = parse_get(args, "read", &len); param = parse_get(args, "read", &len);
if (len && isalpha(param[0])) { if (len && isalpha(param[0])) {