extern/KasmVNC
1
0
Fork 0
mirror of https://github.com/kasmtech/KasmVNC.git synced 2024-11-22 08:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle pixel formats with odd shift values

Browse Source 
Our fast paths assume that each channel fits in to a separate byte.
That means the shift needs to be a multiple of 8. Start actually
checking this so that a client cannot trip us up and possibly cause
incorrect code exection.

Issue found by Pavel Cheremushkin from Kaspersky Lab.
This commit is contained in:
Pierre Ossman 2019-10-02 16:06:08 +02:00 committed by Lauri Kasanen
parent ae6cbd19e9
commit ed73ac2aa7
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/rfb/PixelFormat.cxx
View File

@ -205,6 +205,12 @@ bool PixelFormat::is888(void) const
return false; return false;
if (blueMax != 255) if (blueMax != 255)
return false; return false;
if ((redShift & 0x7) != 0)
return false;
if ((greenShift & 0x7) != 0)
return false;
if ((blueShift & 0x7) != 0)
return false;
return true; return true;
} }