From 8f193bc914ef7d3ab77a64409ed1510220566171 Mon Sep 17 00:00:00 2001
From: Markus Fleschutz <markus@fleschutz.de>
Date: Sun, 12 Sep 2021 21:33:46 +0200
Subject: [PATCH] Update check-symlinks.ps1

---
 Data/scripts.csv           |  2 +-
 README.md                  |  2 +-
 Scripts/check-symlinks.ps1 | 18 ++++++++----------
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/Data/scripts.csv b/Data/scripts.csv
index 7393f27c..71ac336d 100644
--- a/Data/scripts.csv
+++ b/Data/scripts.csv
@@ -29,7 +29,7 @@ check-mac-address.ps1, checks the given MAC address for validity
 check-ping.ps1, checks the ping latency to the internet
 check-subnet-mask.ps1, checks the given subnet mask for validity
 check-swap-space.ps1, checks the swap space for free space left
-check-symlinks.ps1, checks every symlink in the given directory tree
+check-symlinks.ps1, checks every symlink in a directory tree
 check-weather.ps1, checks the current weather for critical values
 check-windows-system-files.ps1, checks the validity of the Windows system files 
 check-xml-file.ps1, checks the given XML file for validity
diff --git a/README.md b/README.md
index 59bb487d..a5cf0def 100644
--- a/README.md
+++ b/README.md
@@ -142,7 +142,7 @@ Mega Collection of PowerShell Scripts
 | [cd-up3.ps1](Scripts/cd-up3.ps1)                     | Change the working directory to three directory levels up          | [Help](Docs/cd-up3.ps1.md)              |
 | [cd-up4.ps1](Scripts/cd-up4.ps1)                     | Change the working directory to four directory levels up           | [Help](Docs/cd-up4.ps1.md)              |
 | [cd-videos.ps1](Scripts/cd-videos.ps1)               | Change the working directory to the user's videos folder           | [Help](Docs/cd-videos.ps1.md)           |
-| [check-symlinks.ps1](Scripts/check-symlinks.ps1)     | Checks every symlink in the given directory tree                   | [Help](Docs/check-symlinks.ps1.md)      |
+| [check-symlinks.ps1](Scripts/check-symlinks.ps1)     | Checks every symlink in a directory tree                           | [Help](Docs/check-symlinks.ps1.md)      |
 | [check-xml-file.ps1](Scripts/check-xml-file.ps1)     | Checks the given XML file for validity                             | [Help](Docs/check-xml-file.ps1.md)      |
 | [clear-recycle-bin.ps1](Scripts/clear-recycle-bin.ps1) | Removes the content of the recycle bin folder (can not be undo!) | [Help](Docs/clear-recycle-bin.ps1.md)   |
 | [copy-photos-sorted.ps1](Scripts/copy-photos-sorted.ps1) | Copy image files sorted by year and month                     | [Help](Docs/copy-photos-sorted.ps1.md)  |
diff --git a/Scripts/check-symlinks.ps1 b/Scripts/check-symlinks.ps1
index bfec9578..e27738a3 100755
--- a/Scripts/check-symlinks.ps1
+++ b/Scripts/check-symlinks.ps1
@@ -1,8 +1,8 @@
 <#
 .SYNOPSIS
-	check-symlinks.ps1 [<dir-tree>]
+	check-symlinks.ps1 [<DirTree>]
 .DESCRIPTION
-	Checks every symlink in the given directory tree.
+	Checks every symlink in a directory tree
 .EXAMPLE
 	PS> .\check-symlinks.ps1 C:\MyApp
 .LINK
@@ -13,13 +13,11 @@
 
 param([string]$DirTree = "")
 
-if ($DirTree -eq "" ) {
-	$DirTree = read-host "Enter the path to the directory tree"
-}
-
 try {
+	if ($DirTree -eq "" ) { $DirTree = read-host "Enter the path to the directory tree" }
+
 	write-progress "Checking symlinks in $DirTree..."
-	[int]$SymlinksTotal = [int]$SymlinksBroken = 0
+	[int]$NumTotal = [int]$NumBroken = 0
 	Get-ChildItem $DirTree -recurse  | Where { $_.Attributes -match "ReparsePoint" } | ForEach-Object {
 		$Symlink = $_.FullName
 		$Target = ($_ | Select-Object -ExpandProperty Target -ErrorAction Ignore)
@@ -28,13 +26,13 @@ try {
 			$item = Get-Item $path -ErrorAction Ignore
 			if (!$item) {
 				write-warning "Broken symlink: $Symlink -> $Target"
-				$SymlinksBroken++
+				$NumBroken++
 			}
 		}
-		$SymlinksTotal++
+		$NumTotal++
 	}
 
-	"✔️  found $SymlinksTotal symlinks total, $SymlinksBroken symlinks are broken"
+	"✔️ $NumBroken out of $NumTotal symlinks are broken in 📂$DirTree"
 	exit $SymlinksBroken
 } catch {
 	write-error "⚠️ Error in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])"