From c5fa0b574dbbafbdc6fb9128197ca9844b047133 Mon Sep 17 00:00:00 2001
From: Markus Fleschutz <markus@fleschutz.de>
Date: Wed, 14 Apr 2021 13:44:59 +0200
Subject: [PATCH] Improve list-random-passwords.ps1

---
 Scripts/list-random-passwords.ps1 | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/Scripts/list-random-passwords.ps1 b/Scripts/list-random-passwords.ps1
index d835f6e0..698882ad 100755
--- a/Scripts/list-random-passwords.ps1
+++ b/Scripts/list-random-passwords.ps1
@@ -12,23 +12,18 @@ $Lines = 24
 $MinCharCode = 33
 $MaxCharCode = 126
 
-function GeneratePassword {
-	$Generator = New-Object System.Random
-	for ($i = 0; $i -lt $PasswordLength; $i++) {
-		$Result += [char]$Generator.next($MinCharCode,$MaxCharCode)
-	}
-	return $Result
-}
-
 try {
 	write-output ""
+	$Generator = New-Object System.Random
 	for ($j = 0; $j -lt $Lines; $j++) {
 		$Line = ""
 		for ($k = 0; $k -lt $Columns; $k++) {
-			$Line += GeneratePassword
+			for ($i = 0; $i -lt $PasswordLength; $i++) {
+				$Line += [char]$Generator.next($MinCharCode,$MaxCharCode)
+			}
 			$Line += "   "
 		}
-		write-output $Line
+		write-output "$Line"
 	}
 	write-output ""
 	exit 0