From cda05d0c9ba5082e9355569d517002d012b1e61d Mon Sep 17 00:00:00 2001 From: Markus Fleschutz Date: Tue, 16 Feb 2021 10:03:20 +0100 Subject: [PATCH] Improved error handling --- Misc/FAQ.md | 10 +++++----- Scripts/MD5.ps1 | 2 +- Scripts/SHA1.ps1 | 2 +- Scripts/SHA256.ps1 | 2 +- Scripts/add-firewall-rules.ps1 | 2 +- Scripts/alert.ps1 | 2 +- Scripts/check-ipv4-address.ps1 | 2 +- Scripts/check-ipv6-address.ps1 | 2 +- Scripts/check-mac-address.ps1 | 2 +- Scripts/check-symlinks.ps1 | 2 +- Scripts/check-xml-file.ps1 | 2 +- Scripts/clean-branch.ps1 | 2 +- Scripts/close-program.ps1 | 2 +- Scripts/configure-git.ps1 | 2 +- Scripts/csv-to-text.ps1 | 2 +- Scripts/decrypt-file.ps1 | 2 +- Scripts/display-time.ps1 | 2 +- Scripts/download.ps1 | 2 +- Scripts/encrypt-file.ps1 | 2 +- Scripts/generate-qrcode.ps1 | 2 +- Scripts/hibernate.ps1 | 2 +- Scripts/inspect-exe.ps1 | 2 +- Scripts/list-anagrams.ps1 | 2 +- Scripts/list-automatic-variables.ps1 | 2 +- Scripts/list-clipboard.ps1 | 2 +- Scripts/list-cmdlets.ps1 | 2 +- Scripts/list-current-timezone.ps1 | 2 +- Scripts/list-earthquakes.ps1 | 2 +- Scripts/list-empty-dirs.ps1 | 2 +- Scripts/list-empty-files.ps1 | 2 +- Scripts/list-environment-variables.ps1 | 2 +- Scripts/list-files.ps1 | 2 +- Scripts/list-formatted.ps1 | 2 +- Scripts/list-installed-software.ps1 | 2 +- Scripts/list-logbook.ps1 | 2 +- Scripts/list-modules.ps1 | 2 +- Scripts/list-news.ps1 | 2 +- Scripts/list-os-releases.ps1 | 2 +- Scripts/list-printers.ps1 | 2 +- Scripts/list-processes.ps1 | 2 +- Scripts/list-random-passwords.ps1 | 2 +- Scripts/list-random-pins.ps1 | 2 +- Scripts/list-scripts.ps1 | 2 +- Scripts/list-timezones.ps1 | 2 +- Scripts/list-unused-files.ps1 | 2 +- Scripts/list-user-groups.ps1 | 2 +- Scripts/locate-city.ps1 | 2 +- Scripts/locate-ipaddress.ps1 | 4 ++-- Scripts/locate-zip-code.ps1 | 2 +- Scripts/make-install.ps1 | 2 +- Scripts/moon.ps1 | 2 +- Scripts/mute-audio.ps1 | 2 +- Scripts/new-email.ps1 | 2 +- Scripts/next-joke.ps1 | 2 +- Scripts/open-browser.ps1 | 2 +- Scripts/open-calculator.ps1 | 2 +- Scripts/open-email-client.ps1 | 2 +- Scripts/play-beep.ps1 | 2 +- Scripts/poweroff.ps1 | 2 +- Scripts/query-smart-data.ps1 | 2 +- Scripts/reboot.ps1 | 2 +- Scripts/remove-empty-dirs.ps1 | 2 +- Scripts/search-files.ps1 | 2 +- Scripts/send-email.ps1 | 2 +- Scripts/send-tcp.ps1 | 2 +- Scripts/send-udp.ps1 | 2 +- Scripts/set-timer.ps1 | 2 +- Scripts/set-wallpaper.ps1 | 2 +- Scripts/simulate-matrix.ps1 | 2 +- Scripts/smart-data2csv.ps1 | 2 +- Scripts/speak-date.ps1 | 2 +- Scripts/speak-english.ps1 | 2 +- Scripts/speak-file.ps1 | 2 +- Scripts/speak-german.ps1 | 2 +- Scripts/speak-joke.ps1 | 2 +- Scripts/speak-test.ps1 | 2 +- Scripts/speak-text.ps1 | 2 +- Scripts/speak-time.ps1 | 2 +- Scripts/switch-branch.ps1 | 2 +- Scripts/switch-shelly1.ps1 | 2 +- Scripts/take-screenshot.ps1 | 2 +- Scripts/take-screenshots.ps1 | 2 +- Scripts/train-dns-cache.ps1 | 2 +- Scripts/translate-file.ps1 | 2 +- Scripts/translate-text.ps1 | 2 +- Scripts/turn-volume-down.ps1 | 2 +- Scripts/turn-volume-up.ps1 | 2 +- Scripts/txt2wav.ps1 | 2 +- Scripts/unmute-audio.ps1 | 2 +- Scripts/visualize-dir-tree.ps1 | 2 +- Scripts/voice-control.ps1 | 2 +- Scripts/wakeup.ps1 | 2 +- Scripts/weather-alert.ps1 | 2 +- Scripts/weather-report.ps1 | 4 ++-- Scripts/weather-worldwide.ps1 | 2 +- Scripts/weather.ps1 | 4 ++-- Scripts/write-big.ps1 | 2 +- Scripts/write-blue.ps1 | 4 ++-- Scripts/write-braille.ps1 | 2 +- Scripts/write-green.ps1 | 2 +- Scripts/write-logbook.ps1 | 2 +- Scripts/write-morse-code.ps1 | 2 +- Scripts/write-red.ps1 | 2 +- Scripts/write-rot13.ps1 | 2 +- Scripts/write-typewriter.ps1 | 2 +- Scripts/write-uppercase.ps1 | 2 +- Scripts/write-vertical.ps1 | 2 +- Scripts/zip-dir.ps1 | 2 +- 108 files changed, 116 insertions(+), 116 deletions(-) diff --git a/Misc/FAQ.md b/Misc/FAQ.md index 0482e05a..63e051a6 100644 --- a/Misc/FAQ.md +++ b/Misc/FAQ.md @@ -68,15 +68,15 @@ How to write good PowerShell Scripts? Each PowerShell script should follow the 10 golden rules: 1. the filename should be named `-.ps1` -2. the first line reads `#!/bin/powershell` to support PowerShell on Linux -3. the script has execute file permissions (chmod a+rx ) to support PowerShell on Linux +2. the first line reads `#!/bin/powershell` (to support Linux) +3. the script has execute file permissions: chmod a+rx (to support Linux) 4. provide a comment-based help with syntax, description, link, author, and license 5. check the requirements (e.g. #Requires -RunAsAdministrator, or #Requires -Version 3) 6. prefer command-line options, else ask the user -7. use `Set-StrictMode -Version Latest` to enable additional error checking +7. recommended is `Set-StrictMode -Version Latest` to enable additional error checking 8. for readibility use UpperCamelCase for variables and functions, lowerCamelCase for everything else -9. on error call write-error with keyword "ERROR:" (required by log parser) and exit the error code (mostly 1) -10. on success call write-host -foregroundColor green with keyword "DONE" and call exit 0 +9. on error call write-error with keyword "ERROR:" (to support log parsers) and exit the error code (mostly 1) +10. on success exit with error code 0 (exit 0) Your Question is not answered here? ----------------------------------- diff --git a/Scripts/MD5.ps1 b/Scripts/MD5.ps1 index 54edeae6..0c2e939a 100755 --- a/Scripts/MD5.ps1 +++ b/Scripts/MD5.ps1 @@ -16,6 +16,6 @@ try { write-output "MD5 hash is" $Result.Hash exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/SHA1.ps1 b/Scripts/SHA1.ps1 index fdb98a3d..2b09352b 100755 --- a/Scripts/SHA1.ps1 +++ b/Scripts/SHA1.ps1 @@ -17,6 +17,6 @@ try { write-output "SHA1 hash is" $Result.Hash exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/SHA256.ps1 b/Scripts/SHA256.ps1 index 12b69517..a252abbc 100755 --- a/Scripts/SHA256.ps1 +++ b/Scripts/SHA256.ps1 @@ -17,6 +17,6 @@ try { write-output "SHA256 hash is:" $Result.Hash exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/add-firewall-rules.ps1 b/Scripts/add-firewall-rules.ps1 index fad13dda..eec327bf 100755 --- a/Scripts/add-firewall-rules.ps1 +++ b/Scripts/add-firewall-rules.ps1 @@ -49,6 +49,6 @@ try { Start-Process powershell -Verb runAs -ArgumentList "-command & {$command} $arg" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/alert.ps1 b/Scripts/alert.ps1 index 34728aa0..63f8ca1a 100755 --- a/Scripts/alert.ps1 +++ b/Scripts/alert.ps1 @@ -18,6 +18,6 @@ try { exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/check-ipv4-address.ps1 b/Scripts/check-ipv4-address.ps1 index 29128e87..c8a9892b 100755 --- a/Scripts/check-ipv4-address.ps1 +++ b/Scripts/check-ipv4-address.ps1 @@ -29,6 +29,6 @@ try { exit 1 } } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/check-ipv6-address.ps1 b/Scripts/check-ipv6-address.ps1 index a2d27783..41759a21 100755 --- a/Scripts/check-ipv6-address.ps1 +++ b/Scripts/check-ipv6-address.ps1 @@ -42,6 +42,6 @@ try { exit 1 } } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/check-mac-address.ps1 b/Scripts/check-mac-address.ps1 index 0a13d2b9..5f184dc9 100755 --- a/Scripts/check-mac-address.ps1 +++ b/Scripts/check-mac-address.ps1 @@ -30,6 +30,6 @@ try { exit 1 } } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/check-symlinks.ps1 b/Scripts/check-symlinks.ps1 index 0bb874b9..659b2894 100755 --- a/Scripts/check-symlinks.ps1 +++ b/Scripts/check-symlinks.ps1 @@ -31,6 +31,6 @@ try { write-host -foregroundColor green "Done - $SymlinksBroken out of $SymlinksTotal are broken" exit $SymlinksBroken } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/check-xml-file.ps1 b/Scripts/check-xml-file.ps1 index 10e340b8..d20656ca 100755 --- a/Scripts/check-xml-file.ps1 +++ b/Scripts/check-xml-file.ps1 @@ -32,6 +32,6 @@ try { write-host -foregroundColor green "OK - XML file is valid" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/clean-branch.ps1 b/Scripts/clean-branch.ps1 index 998d5e5f..8345792d 100755 --- a/Scripts/clean-branch.ps1 +++ b/Scripts/clean-branch.ps1 @@ -25,6 +25,6 @@ try { exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/close-program.ps1 b/Scripts/close-program.ps1 index 85999550..004da5f9 100755 --- a/Scripts/close-program.ps1 +++ b/Scripts/close-program.ps1 @@ -39,6 +39,6 @@ try { write-host -foregroundColor green "Done - $FullProgramName has been closed ($($Processes.Count) proc)." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/configure-git.ps1 b/Scripts/configure-git.ps1 index 3877a42b..87604ee7 100755 --- a/Scripts/configure-git.ps1 +++ b/Scripts/configure-git.ps1 @@ -36,6 +36,6 @@ try { & git config --list exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/csv-to-text.ps1 b/Scripts/csv-to-text.ps1 index b42f86b4..40989a99 100755 --- a/Scripts/csv-to-text.ps1 +++ b/Scripts/csv-to-text.ps1 @@ -21,6 +21,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/decrypt-file.ps1 b/Scripts/decrypt-file.ps1 index 77e737d5..b9931e83 100755 --- a/Scripts/decrypt-file.ps1 +++ b/Scripts/decrypt-file.ps1 @@ -164,6 +164,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/display-time.ps1 b/Scripts/display-time.ps1 index dc8bacda..ce1fa04a 100755 --- a/Scripts/display-time.ps1 +++ b/Scripts/display-time.ps1 @@ -19,6 +19,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/download.ps1 b/Scripts/download.ps1 index 33e0c766..7d6ca5ec 100755 --- a/Scripts/download.ps1 +++ b/Scripts/download.ps1 @@ -18,6 +18,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/encrypt-file.ps1 b/Scripts/encrypt-file.ps1 index a38888ef..65ce9417 100755 --- a/Scripts/encrypt-file.ps1 +++ b/Scripts/encrypt-file.ps1 @@ -149,6 +149,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/generate-qrcode.ps1 b/Scripts/generate-qrcode.ps1 index bdaf43b1..e689543d 100755 --- a/Scripts/generate-qrcode.ps1 +++ b/Scripts/generate-qrcode.ps1 @@ -32,6 +32,6 @@ try { write-host -foregroundColor green "Done - QR code has been written to $NewFile" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/hibernate.ps1 b/Scripts/hibernate.ps1 index a99b4397..23bd349c 100755 --- a/Scripts/hibernate.ps1 +++ b/Scripts/hibernate.ps1 @@ -13,6 +13,6 @@ try { [System.Windows.Forms.Application]::SetSuspendState("Hibernate", $false, $false); exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/inspect-exe.ps1 b/Scripts/inspect-exe.ps1 index 4eb9444e..2c49b1a9 100755 --- a/Scripts/inspect-exe.ps1 +++ b/Scripts/inspect-exe.ps1 @@ -15,6 +15,6 @@ try { get-childitem $PathToExe | % {$_.VersionInfo} | Select * exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-anagrams.ps1 b/Scripts/list-anagrams.ps1 index 573fba9e..6c3660ac 100755 --- a/Scripts/list-anagrams.ps1 +++ b/Scripts/list-anagrams.ps1 @@ -55,6 +55,6 @@ try { GetPermutations -String $Word | Format-Wide -Column $Columns exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-automatic-variables.ps1 b/Scripts/list-automatic-variables.ps1 index b1612db4..bca980f2 100755 --- a/Scripts/list-automatic-variables.ps1 +++ b/Scripts/list-automatic-variables.ps1 @@ -68,6 +68,6 @@ try { write-output "($($Vars.Count) automatic variables total)" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-clipboard.ps1 b/Scripts/list-clipboard.ps1 index b63c823b..cd9464dc 100755 --- a/Scripts/list-clipboard.ps1 +++ b/Scripts/list-clipboard.ps1 @@ -10,6 +10,6 @@ try { get-clipboard exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-cmdlets.ps1 b/Scripts/list-cmdlets.ps1 index 1e6357a0..312f99f4 100755 --- a/Scripts/list-cmdlets.ps1 +++ b/Scripts/list-cmdlets.ps1 @@ -10,6 +10,6 @@ try { Get-Command -Command-Type cmdlet exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-current-timezone.ps1 b/Scripts/list-current-timezone.ps1 index 4e8887c3..15ed13c6 100755 --- a/Scripts/list-current-timezone.ps1 +++ b/Scripts/list-current-timezone.ps1 @@ -10,6 +10,6 @@ try { get-timezone exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-earthquakes.ps1 b/Scripts/list-earthquakes.ps1 index 7a326ba8..d97463b7 100755 --- a/Scripts/list-earthquakes.ps1 +++ b/Scripts/list-earthquakes.ps1 @@ -15,6 +15,6 @@ try { (Invoke-WebRequest -Uri "https://earthquake.usgs.gov/fdsnws/event/1/query?format=$Format&minmagnitude=$MinMagnitude&orderby=$OrderBy" -UserAgent "curl" ).Content exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-empty-dirs.ps1 b/Scripts/list-empty-dirs.ps1 index 86cfa214..d2b46dd2 100755 --- a/Scripts/list-empty-dirs.ps1 +++ b/Scripts/list-empty-dirs.ps1 @@ -21,6 +21,6 @@ try { write-host -foregroundColor green "Done - found $Count empty directories" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-empty-files.ps1 b/Scripts/list-empty-files.ps1 index 2d5a4004..248ef52e 100755 --- a/Scripts/list-empty-files.ps1 +++ b/Scripts/list-empty-files.ps1 @@ -21,6 +21,6 @@ try { write-host -foregroundColor green "Done - found $Count empty files" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-environment-variables.ps1 b/Scripts/list-environment-variables.ps1 index 7f13c219..d8b1eb77 100755 --- a/Scripts/list-environment-variables.ps1 +++ b/Scripts/list-environment-variables.ps1 @@ -10,6 +10,6 @@ try { Get-ChildItem env: exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-files.ps1 b/Scripts/list-files.ps1 index 5a9f4f49..804ade58 100755 --- a/Scripts/list-files.ps1 +++ b/Scripts/list-files.ps1 @@ -15,6 +15,6 @@ try { Get-ChildItem -path $Folder -recurse | select FullName exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-formatted.ps1 b/Scripts/list-formatted.ps1 index a3be02d5..6b7d1dde 100755 --- a/Scripts/list-formatted.ps1 +++ b/Scripts/list-formatted.ps1 @@ -26,6 +26,6 @@ try { ListDirectory $Dir | format-wide -autoSize exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-installed-software.ps1 b/Scripts/list-installed-software.ps1 index 8b6d9ea0..238da7fd 100755 --- a/Scripts/list-installed-software.ps1 +++ b/Scripts/list-installed-software.ps1 @@ -10,6 +10,6 @@ try { get-itemProperty HKLM:\Software\Microsoft\Windows\CurrentVersion\Uninstall\* | select-object DisplayName,DisplayVersion,InstallDate | format-table -autoSize exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-logbook.ps1 b/Scripts/list-logbook.ps1 index dba82f49..5d243614 100755 --- a/Scripts/list-logbook.ps1 +++ b/Scripts/list-logbook.ps1 @@ -25,6 +25,6 @@ try { write-output "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-modules.ps1 b/Scripts/list-modules.ps1 index dff1b3a4..8c83349b 100755 --- a/Scripts/list-modules.ps1 +++ b/Scripts/list-modules.ps1 @@ -10,6 +10,6 @@ try { get-module | format-table exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-news.ps1 b/Scripts/list-news.ps1 index 8012773d..b654c0c1 100755 --- a/Scripts/list-news.ps1 +++ b/Scripts/list-news.ps1 @@ -20,6 +20,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-os-releases.ps1 b/Scripts/list-os-releases.ps1 index a8169001..635b4622 100755 --- a/Scripts/list-os-releases.ps1 +++ b/Scripts/list-os-releases.ps1 @@ -20,6 +20,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-printers.ps1 b/Scripts/list-printers.ps1 index 15b13121..1218f0e8 100755 --- a/Scripts/list-printers.ps1 +++ b/Scripts/list-printers.ps1 @@ -11,6 +11,6 @@ try { get-WMIObject -Class Win32_Printer -ComputerName $ComputerName | format-table exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-processes.ps1 b/Scripts/list-processes.ps1 index c433e875..715b69d9 100755 --- a/Scripts/list-processes.ps1 +++ b/Scripts/list-processes.ps1 @@ -10,6 +10,6 @@ try { Get-Process | Format-Table -Property Id, @{Label="CPU(s)";Expression={$_.CPU.ToString("N")+"%"};Alignment="Right"}, ProcessName -AutoSize exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-random-passwords.ps1 b/Scripts/list-random-passwords.ps1 index 3c5f6232..9d92a579 100755 --- a/Scripts/list-random-passwords.ps1 +++ b/Scripts/list-random-passwords.ps1 @@ -33,6 +33,6 @@ try { write-output "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-random-pins.ps1 b/Scripts/list-random-pins.ps1 index 9cdc9130..d68e99eb 100755 --- a/Scripts/list-random-pins.ps1 +++ b/Scripts/list-random-pins.ps1 @@ -29,6 +29,6 @@ try { write-output "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-scripts.ps1 b/Scripts/list-scripts.ps1 index 4129e892..4c19a9c7 100755 --- a/Scripts/list-scripts.ps1 +++ b/Scripts/list-scripts.ps1 @@ -25,6 +25,6 @@ try { ListScripts "$PathToRepo/Data/scripts.csv" | format-table -property Script, Description exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-timezones.ps1 b/Scripts/list-timezones.ps1 index 9bdc5034..49acbc8b 100755 --- a/Scripts/list-timezones.ps1 +++ b/Scripts/list-timezones.ps1 @@ -10,6 +10,6 @@ try { get-timezone -listavailable | format-table -property Id,DisplayName,SupportsDaylightSavingTime exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-unused-files.ps1 b/Scripts/list-unused-files.ps1 index 95f3b770..d5181fae 100755 --- a/Scripts/list-unused-files.ps1 +++ b/Scripts/list-unused-files.ps1 @@ -17,6 +17,6 @@ try { exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/list-user-groups.ps1 b/Scripts/list-user-groups.ps1 index 96dc4982..40188c37 100755 --- a/Scripts/list-user-groups.ps1 +++ b/Scripts/list-user-groups.ps1 @@ -10,6 +10,6 @@ try { Get-LocalGroup exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/locate-city.ps1 b/Scripts/locate-city.ps1 index 53e38f8f..35045201 100755 --- a/Scripts/locate-city.ps1 +++ b/Scripts/locate-city.ps1 @@ -35,6 +35,6 @@ try { write-error "City $City not found" exit 1 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/locate-ipaddress.ps1 b/Scripts/locate-ipaddress.ps1 index acd1db6e..4030164e 100755 --- a/Scripts/locate-ipaddress.ps1 +++ b/Scripts/locate-ipaddress.ps1 @@ -6,7 +6,7 @@ .NOTES Author: Markus Fleschutz / License: CC0 #> -param([string]$IPaddr) +param($IPaddr = "") try { if ($IPaddr -eq "" ) { $IPaddr = read-host "Enter IP address to locate" @@ -15,6 +15,6 @@ try { write-output $result exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/locate-zip-code.ps1 b/Scripts/locate-zip-code.ps1 index c329176f..ee427579 100755 --- a/Scripts/locate-zip-code.ps1 +++ b/Scripts/locate-zip-code.ps1 @@ -40,6 +40,6 @@ try { write-error "Zip-code $ZipCode in country $CountryCode not found" exit 1 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/make-install.ps1 b/Scripts/make-install.ps1 index 6f9ece26..14ebbb38 100755 --- a/Scripts/make-install.ps1 +++ b/Scripts/make-install.ps1 @@ -20,6 +20,6 @@ try { write-host -foregroundColor green "Done - synced to %DST_DIR%" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/moon.ps1 b/Scripts/moon.ps1 index 3f4d7098..92788f00 100755 --- a/Scripts/moon.ps1 +++ b/Scripts/moon.ps1 @@ -10,6 +10,6 @@ try { (Invoke-WebRequest http://wttr.in/Moon -UserAgent "curl" ).Content exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/mute-audio.ps1 b/Scripts/mute-audio.ps1 index 5896402d..e81a53aa 100755 --- a/Scripts/mute-audio.ps1 +++ b/Scripts/mute-audio.ps1 @@ -13,6 +13,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/new-email.ps1 b/Scripts/new-email.ps1 index 27c6bc6f..7f4f7afa 100755 --- a/Scripts/new-email.ps1 +++ b/Scripts/new-email.ps1 @@ -16,6 +16,6 @@ try { Start-Process $URL exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/next-joke.ps1 b/Scripts/next-joke.ps1 index 52063b2e..a21ab7a6 100755 --- a/Scripts/next-joke.ps1 +++ b/Scripts/next-joke.ps1 @@ -18,6 +18,6 @@ try { write-output "$Joke" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/open-browser.ps1 b/Scripts/open-browser.ps1 index 40110731..4c6ad5c1 100755 --- a/Scripts/open-browser.ps1 +++ b/Scripts/open-browser.ps1 @@ -15,6 +15,6 @@ try { Start-Process $URL exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/open-calculator.ps1 b/Scripts/open-calculator.ps1 index 84f57c0e..de8e5e18 100755 --- a/Scripts/open-calculator.ps1 +++ b/Scripts/open-calculator.ps1 @@ -10,6 +10,6 @@ try { start-process calc.exe exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/open-email-client.ps1 b/Scripts/open-email-client.ps1 index 435fa258..84338250 100755 --- a/Scripts/open-email-client.ps1 +++ b/Scripts/open-email-client.ps1 @@ -10,6 +10,6 @@ try { Start-Process "mailto:markus@fleschutz.de" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/play-beep.ps1 b/Scripts/play-beep.ps1 index 7028fbca..8e25ac9e 100755 --- a/Scripts/play-beep.ps1 +++ b/Scripts/play-beep.ps1 @@ -10,6 +10,6 @@ try { [console]::beep(500,300) exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/poweroff.ps1 b/Scripts/poweroff.ps1 index 6e9a3490..b4eff1ef 100755 --- a/Scripts/poweroff.ps1 +++ b/Scripts/poweroff.ps1 @@ -12,6 +12,6 @@ try { Stop-Computer exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/query-smart-data.ps1 b/Scripts/query-smart-data.ps1 index efb0d1eb..83108862 100755 --- a/Scripts/query-smart-data.ps1 +++ b/Scripts/query-smart-data.ps1 @@ -50,6 +50,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/reboot.ps1 b/Scripts/reboot.ps1 index 8025594e..49d62fe2 100755 --- a/Scripts/reboot.ps1 +++ b/Scripts/reboot.ps1 @@ -12,6 +12,6 @@ try { Restart-Computer exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/remove-empty-dirs.ps1 b/Scripts/remove-empty-dirs.ps1 index 666d9bb8..38cf7f59 100755 --- a/Scripts/remove-empty-dirs.ps1 +++ b/Scripts/remove-empty-dirs.ps1 @@ -38,6 +38,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/search-files.ps1 b/Scripts/search-files.ps1 index 42fcf8cb..b8c3a19d 100755 --- a/Scripts/search-files.ps1 +++ b/Scripts/search-files.ps1 @@ -31,6 +31,6 @@ try { ListScripts $Pattern $Path | format-table -property Path,Line,Text exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/send-email.ps1 b/Scripts/send-email.ps1 index 9b539e5c..9c39acdf 100755 --- a/Scripts/send-email.ps1 +++ b/Scripts/send-email.ps1 @@ -23,6 +23,6 @@ try { $smtp.Send($msg) exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/send-tcp.ps1 b/Scripts/send-tcp.ps1 index bff7f334..db07c097 100755 --- a/Scripts/send-tcp.ps1 +++ b/Scripts/send-tcp.ps1 @@ -34,6 +34,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/send-udp.ps1 b/Scripts/send-udp.ps1 index 6d9d8521..795170f3 100755 --- a/Scripts/send-udp.ps1 +++ b/Scripts/send-udp.ps1 @@ -29,6 +29,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/set-timer.ps1 b/Scripts/set-timer.ps1 index 356d0f70..d46a4d84 100755 --- a/Scripts/set-timer.ps1 +++ b/Scripts/set-timer.ps1 @@ -21,6 +21,6 @@ try { write-host -foregroundColor green "Done - $Seconds seconds countdown finished" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/set-wallpaper.ps1 b/Scripts/set-wallpaper.ps1 index 1181a876..123ea3f0 100755 --- a/Scripts/set-wallpaper.ps1 +++ b/Scripts/set-wallpaper.ps1 @@ -58,6 +58,6 @@ try { SetWallPaper -Image $ImageFile -Style $Style exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/simulate-matrix.ps1 b/Scripts/simulate-matrix.ps1 index 6129e56b..3e49fe9a 100755 --- a/Scripts/simulate-matrix.ps1 +++ b/Scripts/simulate-matrix.ps1 @@ -47,6 +47,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/smart-data2csv.ps1 b/Scripts/smart-data2csv.ps1 index 793c3c13..addde45e 100755 --- a/Scripts/smart-data2csv.ps1 +++ b/Scripts/smart-data2csv.ps1 @@ -86,6 +86,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-date.ps1 b/Scripts/speak-date.ps1 index 1ff988fe..929d2ad4 100755 --- a/Scripts/speak-date.ps1 +++ b/Scripts/speak-date.ps1 @@ -11,6 +11,6 @@ try { & ./speak-english.ps1 "Today is $((Get-Date).ToShortDateString())" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-english.ps1 b/Scripts/speak-english.ps1 index 121896a5..8804f06e 100755 --- a/Scripts/speak-english.ps1 +++ b/Scripts/speak-english.ps1 @@ -27,6 +27,6 @@ try { write-error "Sorry, no English text-to-speech (TTS) voice found" exit 1 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-file.ps1 b/Scripts/speak-file.ps1 index dc4ac289..fd4d4645 100755 --- a/Scripts/speak-file.ps1 +++ b/Scripts/speak-file.ps1 @@ -18,6 +18,6 @@ try { $Result = $Voice.Speak($Text) exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-german.ps1 b/Scripts/speak-german.ps1 index bf090735..53f376ae 100755 --- a/Scripts/speak-german.ps1 +++ b/Scripts/speak-german.ps1 @@ -27,6 +27,6 @@ try { write-error "Sorry, no German text-to-speech (TTS) voice found" exit 1 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-joke.ps1 b/Scripts/speak-joke.ps1 index 8554373b..c5d48861 100755 --- a/Scripts/speak-joke.ps1 +++ b/Scripts/speak-joke.ps1 @@ -19,6 +19,6 @@ try { & ./speak-english.ps1 "$Joke" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-test.ps1 b/Scripts/speak-test.ps1 index 8b19fd3f..9e8bdf3b 100755 --- a/Scripts/speak-test.ps1 +++ b/Scripts/speak-test.ps1 @@ -51,6 +51,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-text.ps1 b/Scripts/speak-text.ps1 index 9968c5ed..ad49ec19 100755 --- a/Scripts/speak-text.ps1 +++ b/Scripts/speak-text.ps1 @@ -17,6 +17,6 @@ try { $Result = $Voice.Speak($Text) exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/speak-time.ps1 b/Scripts/speak-time.ps1 index 9c989c3c..ad8ef6c8 100755 --- a/Scripts/speak-time.ps1 +++ b/Scripts/speak-time.ps1 @@ -11,6 +11,6 @@ try { & ./speak-english.ps1 "It's now $((Get-Date).ToShortTimeString())" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/switch-branch.ps1 b/Scripts/switch-branch.ps1 index cb6e2a21..bfe77c25 100755 --- a/Scripts/switch-branch.ps1 +++ b/Scripts/switch-branch.ps1 @@ -34,6 +34,6 @@ try { exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/switch-shelly1.ps1 b/Scripts/switch-shelly1.ps1 index 36fcb02a..6a9b20af 100755 --- a/Scripts/switch-shelly1.ps1 +++ b/Scripts/switch-shelly1.ps1 @@ -24,6 +24,6 @@ try { write-host -foregroundColor green "Done - switched Shelly1 device at $IPaddr to $TurnMode for $Timer second(s)" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/take-screenshot.ps1 b/Scripts/take-screenshot.ps1 index c9e3ed1d..2cbff017 100755 --- a/Scripts/take-screenshot.ps1 +++ b/Scripts/take-screenshot.ps1 @@ -32,6 +32,6 @@ try { TakeScreenshot $FilePath exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/take-screenshots.ps1 b/Scripts/take-screenshots.ps1 index 5be4717c..046edb71 100755 --- a/Scripts/take-screenshots.ps1 +++ b/Scripts/take-screenshots.ps1 @@ -35,6 +35,6 @@ try { } while (1) exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/train-dns-cache.ps1 b/Scripts/train-dns-cache.ps1 index da4a8c59..10b93150 100755 --- a/Scripts/train-dns-cache.ps1 +++ b/Scripts/train-dns-cache.ps1 @@ -28,6 +28,6 @@ try { write-host -foregroundColor green "Done - DNS cache trained with $Count domain names in $TimeInterval seconds" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/translate-file.ps1 b/Scripts/translate-file.ps1 index f6476b46..061f8495 100755 --- a/Scripts/translate-file.ps1 +++ b/Scripts/translate-file.ps1 @@ -24,6 +24,6 @@ try { Start-Process -FilePath "$PathToRepo/Data/trans" -ArgumentList "-i $File -s $SourceLanguage -t $TargetLanguage -e google -brief" -NoNewWindow -Wait exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/translate-text.ps1 b/Scripts/translate-text.ps1 index 85073cb3..f09a8ebd 100755 --- a/Scripts/translate-text.ps1 +++ b/Scripts/translate-text.ps1 @@ -41,6 +41,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/turn-volume-down.ps1 b/Scripts/turn-volume-down.ps1 index 335c1811..c74b285a 100755 --- a/Scripts/turn-volume-down.ps1 +++ b/Scripts/turn-volume-down.ps1 @@ -16,6 +16,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/turn-volume-up.ps1 b/Scripts/turn-volume-up.ps1 index f41c08f4..a90139fc 100755 --- a/Scripts/turn-volume-up.ps1 +++ b/Scripts/turn-volume-up.ps1 @@ -16,6 +16,6 @@ try { write-host -foregroundColor green "Done." exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/txt2wav.ps1 b/Scripts/txt2wav.ps1 index 3284714f..985848f1 100755 --- a/Scripts/txt2wav.ps1 +++ b/Scripts/txt2wav.ps1 @@ -20,6 +20,6 @@ try { $SpeechSynthesizer.Dispose() exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/unmute-audio.ps1 b/Scripts/unmute-audio.ps1 index 349f0490..6a385b43 100755 --- a/Scripts/unmute-audio.ps1 +++ b/Scripts/unmute-audio.ps1 @@ -12,6 +12,6 @@ try { write-host -foregroundColor green "Done" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/visualize-dir-tree.ps1 b/Scripts/visualize-dir-tree.ps1 index cc325cdd..bd3f8a75 100755 --- a/Scripts/visualize-dir-tree.ps1 +++ b/Scripts/visualize-dir-tree.ps1 @@ -40,6 +40,6 @@ try { write-host "($($global:NumDirs) dirs, $($global:NumBytes) bytes total)" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/voice-control.ps1 b/Scripts/voice-control.ps1 index bd4d8da6..fec1aab1 100755 --- a/Scripts/voice-control.ps1 +++ b/Scripts/voice-control.ps1 @@ -53,6 +53,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/wakeup.ps1 b/Scripts/wakeup.ps1 index b60708c0..a5a1f283 100755 --- a/Scripts/wakeup.ps1 +++ b/Scripts/wakeup.ps1 @@ -35,6 +35,6 @@ try { write-host -foregroundColor green "Done - magic packet sent twice to IP $IPaddress (MAC $MACaddress)" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/weather-alert.ps1 b/Scripts/weather-alert.ps1 index 8900d567..429444c6 100755 --- a/Scripts/weather-alert.ps1 +++ b/Scripts/weather-alert.ps1 @@ -33,6 +33,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/weather-report.ps1 b/Scripts/weather-report.ps1 index 69c76877..0aec2572 100755 --- a/Scripts/weather-report.ps1 +++ b/Scripts/weather-report.ps1 @@ -6,12 +6,12 @@ .NOTES Author: Markus Fleschutz / License: CC0 #> -param([string]$GeoLocation = "") # empty means determine automatically +param($GeoLocation = "") # empty means determine automatically try { (invoke-webRequest http://v2d.wttr.in/$GeoLocation -UserAgent "curl" ).Content exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/weather-worldwide.ps1 b/Scripts/weather-worldwide.ps1 index 1aa2f4ca..ca6abb31 100755 --- a/Scripts/weather-worldwide.ps1 +++ b/Scripts/weather-worldwide.ps1 @@ -19,6 +19,6 @@ try { write-output "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/weather.ps1 b/Scripts/weather.ps1 index 878f2801..bfd2eaf8 100755 --- a/Scripts/weather.ps1 +++ b/Scripts/weather.ps1 @@ -6,12 +6,12 @@ .NOTES Author: Markus Fleschutz / License: CC0 #> -param([string]$GeoLocation = "") # empty means determine automatically +param($GeoLocation = "") # empty means determine automatically try { (invoke-webRequest http://wttr.in/$GeoLocation -UserAgent "curl" ).Content exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-big.ps1 b/Scripts/write-big.ps1 index 2f287bae..6fd1618d 100755 --- a/Scripts/write-big.ps1 +++ b/Scripts/write-big.ps1 @@ -412,6 +412,6 @@ try { write-output "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-blue.ps1 b/Scripts/write-blue.ps1 index a7c2ec89..b905379f 100755 --- a/Scripts/write-blue.ps1 +++ b/Scripts/write-blue.ps1 @@ -6,7 +6,7 @@ .NOTES Author: Markus Fleschutz / License: CC0 #> -param([string]$Text = "") +param($Text = "") try { if ($Text -eq "" ) { @@ -15,6 +15,6 @@ try { write-host -foregroundColor blue $Text exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-braille.ps1 b/Scripts/write-braille.ps1 index c4a7f078..01b791ff 100755 --- a/Scripts/write-braille.ps1 +++ b/Scripts/write-braille.ps1 @@ -355,6 +355,6 @@ try { write-output "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-green.ps1 b/Scripts/write-green.ps1 index 68368014..61d0f5e6 100755 --- a/Scripts/write-green.ps1 +++ b/Scripts/write-green.ps1 @@ -15,6 +15,6 @@ try { write-host -foregroundColor green $Text exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-logbook.ps1 b/Scripts/write-logbook.ps1 index 7aa290be..3bd5186d 100755 --- a/Scripts/write-logbook.ps1 +++ b/Scripts/write-logbook.ps1 @@ -20,6 +20,6 @@ try { write-output $Line >> "$PathToRepo/Data/logbook.csv" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-morse-code.ps1 b/Scripts/write-morse-code.ps1 index ee97fc24..5dc47fb6 100755 --- a/Scripts/write-morse-code.ps1 +++ b/Scripts/write-morse-code.ps1 @@ -79,6 +79,6 @@ try { write-host "" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-red.ps1 b/Scripts/write-red.ps1 index a316e713..cd1ef16f 100755 --- a/Scripts/write-red.ps1 +++ b/Scripts/write-red.ps1 @@ -15,6 +15,6 @@ try { write-host -foregroundcolor red $Text exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-rot13.ps1 b/Scripts/write-rot13.ps1 index dd2f9ef1..bab98e42 100755 --- a/Scripts/write-rot13.ps1 +++ b/Scripts/write-rot13.ps1 @@ -29,6 +29,6 @@ try { write-output $Result exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-typewriter.ps1 b/Scripts/write-typewriter.ps1 index 99d8358f..9181405a 100755 --- a/Scripts/write-typewriter.ps1 +++ b/Scripts/write-typewriter.ps1 @@ -21,6 +21,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-uppercase.ps1 b/Scripts/write-uppercase.ps1 index ad3344ca..7ef2bb65 100755 --- a/Scripts/write-uppercase.ps1 +++ b/Scripts/write-uppercase.ps1 @@ -15,6 +15,6 @@ try { write-output $Text.ToUpper() exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/write-vertical.ps1 b/Scripts/write-vertical.ps1 index b533dc71..af0872c8 100755 --- a/Scripts/write-vertical.ps1 +++ b/Scripts/write-vertical.ps1 @@ -18,6 +18,6 @@ try { } exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 } diff --git a/Scripts/zip-dir.ps1 b/Scripts/zip-dir.ps1 index 7eeddbdd..3778fee0 100755 --- a/Scripts/zip-dir.ps1 +++ b/Scripts/zip-dir.ps1 @@ -18,6 +18,6 @@ try { write-host -foregroundColor green "Done - created zip archive $($Directory).zip" exit 0 } catch { - write-error "ERROR in line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" + write-error "ERROR: line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])" exit 1 }