extern/apprise
1
0
Fork 0
mirror of https://github.com/caronc/apprise.git synced 2024-11-21 15:43:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improved hostname verification (#1243)

Browse Source
This commit is contained in:
Chris Caron 2024-11-20 16:26:45 -05:00 committed by GitHub
parent f37dfbf5a1
commit 5441c15a1e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apprise/utils.py
View File

@ -325,7 +325,7 @@ def is_hostname(hostname, ipv4=True, ipv6=True, underscore=True):
labels = hostname.split(".") labels = hostname.split(".")
# ipv4 check # ipv4 check
if len(labels) == 4 and re.match(r'[0-9.]+', hostname): if len(labels) == 4 and re.match(r'^[0-9.]+$', hostname):
return is_ipaddr(hostname, ipv4=ipv4, ipv6=False) return is_ipaddr(hostname, ipv4=ipv4, ipv6=False)
# - RFC 1123 permits hostname labels to start with digits # - RFC 1123 permits hostname labels to start with digits

16
test/test_apprise_utils.py
View File

@ -87,6 +87,22 @@ def test_parse_url_general():
assert result['qsd+'] == {} assert result['qsd+'] == {}
assert result['qsd:'] == {} assert result['qsd:'] == {}
# GitHub Ticket 1234 - Unparseable Hostname
result = utils.parse_url('http://5t4m59hl-34343.euw.devtunnels.ms')
assert result['schema'] == 'http'
assert result['host'] == '5t4m59hl-34343.euw.devtunnels.ms'
assert result['port'] is None
assert result['user'] is None
assert result['password'] is None
assert result['fullpath'] is None
assert result['path'] is None
assert result['query'] is None
assert result['url'] == 'http://5t4m59hl-34343.euw.devtunnels.ms'
assert result['qsd'] == {}
assert result['qsd-'] == {}
assert result['qsd+'] == {}
assert result['qsd:'] == {}
result = utils.parse_url('http://hostname/') result = utils.parse_url('http://hostname/')
assert result['schema'] == 'http' assert result['schema'] == 'http'
assert result['host'] == 'hostname' assert result['host'] == 'hostname'