extern/apprise
1
0
Fork 0
mirror of https://github.com/caronc/apprise.git synced 2025-01-30 09:49:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(pushover): ignore unsupported attachments as intended instead of discarding the entire notification (#650)

Browse Source
This commit is contained in:
Ryan Young 2022-09-30 14:48:55 -07:00 committed by GitHub
parent f1990b14ce
commit e9f040a2d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
apprise/plugins/NotifyPushover.py
View File

@ -432,24 +432,25 @@ class NotifyPushover(NotifyBase):
attach.mimetype,
attach.url(privacy=True)))
return True
attach = None
# If we get here, we're dealing with a supported image.
# Verify that the filesize is okay though.
file_size = len(attach)
if not (file_size > 0
and file_size <= self.attach_max_size_bytes):
else:
# If we get here, we're dealing with a supported image.
# Verify that the filesize is okay though.
file_size = len(attach)
if not (file_size > 0
and file_size <= self.attach_max_size_bytes):
# File size is no good
self.logger.warning(
'Pushover attachment size ({}B) exceeds limit: {}'
.format(file_size, attach.url(privacy=True)))
# File size is no good
self.logger.warning(
'Pushover attachment size ({}B) exceeds limit: {}'
.format(file_size, attach.url(privacy=True)))
return False
return False
self.logger.debug(
'Posting Pushover attachment {}'.format(
attach.url(privacy=True)))
self.logger.debug(
'Posting Pushover attachment {}'.format(
attach.url(privacy=True)))
# Default Header
headers = {