Merge pull request #699 from jmt-gh/698_metadata_downloads_not_created

Update some instances of mkdir to ensureDir (#698)

server/Server.js

@@ -139,6 +139,7 @@ class Server {
     await this.checkUserMediaProgress() // Remove invalid user item progress
     await this.purgeMetadata() // Remove metadata folders without library item
     await this.cacheManager.ensureCachePaths()
+    await this.abMergeManager.ensureDownloadDirPath()
     
     await this.backupManager.init()
     await this.logManager.init()

server/managers/AbMergeManager.js

@@ -16,11 +16,28 @@ class AbMergeManager {
     this.clientEmitter = clientEmitter
 
     this.downloadDirPath = Path.join(global.MetadataPath, 'downloads')
+    this.downloadDirPathExist = false
 
     this.pendingDownloads = []
     this.downloads = []
   }
 
+  async ensureDownloadDirPath() { // Creates download path if necessary and sets owner and permissions
+    if (this.downloadDirPathExist) return
+
+    var pathCreated = false
+    if (!(await fs.pathExists(this.downloadDirPath))) {
+      await fs.mkdir(this.downloadDirPath)
+      pathCreated = true
+    }
+
+    if (pathCreated) {
+      await filePerms.setDefault(this.downloadDirPath)
+    }
+
+    this.downloadDirPathExist = true
+  }
+
   getDownload(downloadId) {
     return this.downloads.find(d => d.id === downloadId)
   }
@@ -76,6 +93,7 @@ class AbMergeManager {
       await fs.mkdir(download.dirpath)
     } catch (error) {
       Logger.error(`[AbMergeManager] Failed to make directory ${download.dirpath}`)
+      Logger.debug(`[AbMergeManager] Make directory error: ${error}`)
       var downloadJson = download.toJSON()
       this.clientEmitter(user.id, 'abmerge_failed', downloadJson)
       return