From 76d668514e20e23672a176992c7276c0fd3326e7 Mon Sep 17 00:00:00 2001 From: advplyr Date: Sat, 25 Jun 2022 11:01:01 -0500 Subject: [PATCH] Fix:Mark as not finished when duration is not set in media progress #771 --- server/controllers/MeController.js | 1 + server/objects/user/MediaProgress.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/server/controllers/MeController.js b/server/controllers/MeController.js index ca257843..01ffccd8 100644 --- a/server/controllers/MeController.js +++ b/server/controllers/MeController.js @@ -57,6 +57,7 @@ class MeController { if (!libraryItem) { return res.status(404).send('Item not found') } + var wasUpdated = req.user.createUpdateMediaProgress(libraryItem, req.body) if (wasUpdated) { await this.db.updateEntity('user', req.user) diff --git a/server/objects/user/MediaProgress.js b/server/objects/user/MediaProgress.js index eb24b1e5..3f13639d 100644 --- a/server/objects/user/MediaProgress.js +++ b/server/objects/user/MediaProgress.js @@ -91,7 +91,7 @@ class MediaProgress { var timeRemaining = this.duration - this.currentTime // If time remaining is less than 5 seconds then mark as finished - if ((this.progress >= 1 || (!isNaN(timeRemaining) && timeRemaining < 5))) { + if ((this.progress >= 1 || (this.duration && !isNaN(timeRemaining) && timeRemaining < 5))) { this.isFinished = true this.finishedAt = Date.now() this.progress = 1