Fix: add extra check for valid names and valid author name #502

This commit is contained in:
advplyr 2022-04-24 18:41:47 -05:00
parent 2e28c9b06d
commit 7717e57c16
2 changed files with 9 additions and 1 deletions

View File

@ -1,3 +1,4 @@
const Logger = require('../../Logger')
const { getId } = require('../../utils/index')
class Author {
@ -19,7 +20,7 @@ class Author {
construct(author) {
this.id = author.id
this.asin = author.asin
this.name = author.name
this.name = author.name || ''
this.description = author.description || null
this.imagePath = author.imagePath
this.relImagePath = author.relImagePath
@ -81,6 +82,10 @@ class Author {
checkNameEquals(name) {
if (!name) return false
if (this.name === null) {
Logger.error(`[Author] Author name is null (${this.id})`)
return false
}
return this.name.toLowerCase() == name.toLowerCase().trim()
}
}

View File

@ -79,6 +79,9 @@ module.exports.parse = (nameString) => {
}
}
// Filter out names that have no first and last
names = names.filter(n => n.first_name || n.last_name)
var namesArray = names.map(a => a.first_name ? `${a.first_name} ${a.last_name}` : a.last_name)
var firstLast = names.length ? namesArray.join(', ') : ''
var lastFirst = names.length ? names.map(a => a.first_name ? `${a.last_name}, ${a.first_name}` : a.last_name).join(', ') : ''