extern/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2024-10-04 17:22:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2742 from mikiher/broken-binary-manager-test

Browse Source 
Fix broken BinaryManager.isBinaryGood test
This commit is contained in:
advplyr 2024-03-14 13:13:59 -05:00 committed by GitHub
commit e6c21c5be1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/server/managers/BinaryManager.test.js
View File

@ -291,6 +291,7 @@ describe('isBinaryGood', () => {
const binaryPath = '/path/to/binary' const binaryPath = '/path/to/binary'
const execCommand = '"' + binaryPath + '"' + ' -version' const execCommand = '"' + binaryPath + '"' + ' -version'
const goodVersions = ['5.1', '6']
beforeEach(() => { beforeEach(() => {
binaryManager = new BinaryManager() binaryManager = new BinaryManager()
@ -306,7 +307,7 @@ describe('isBinaryGood', () => {
it('should return false if binaryPath is falsy', async () => { it('should return false if binaryPath is falsy', async () => {
fsPathExistsStub.resolves(true) fsPathExistsStub.resolves(true)
const result = await binaryManager.isBinaryGood(null) const result = await binaryManager.isBinaryGood(null, goodVersions)
expect(result).to.be.false expect(result).to.be.false
expect(fsPathExistsStub.called).to.be.false expect(fsPathExistsStub.called).to.be.false
@ -316,7 +317,7 @@ describe('isBinaryGood', () => {
it('should return false if binaryPath does not exist', async () => { it('should return false if binaryPath does not exist', async () => {
fsPathExistsStub.resolves(false) fsPathExistsStub.resolves(false)
const result = await binaryManager.isBinaryGood(binaryPath) const result = await binaryManager.isBinaryGood(binaryPath, goodVersions)
expect(result).to.be.false expect(result).to.be.false
expect(fsPathExistsStub.calledOnce).to.be.true expect(fsPathExistsStub.calledOnce).to.be.true
@ -328,7 +329,7 @@ describe('isBinaryGood', () => {
fsPathExistsStub.resolves(true) fsPathExistsStub.resolves(true)
execStub.rejects(new Error('Failed to execute command')) execStub.rejects(new Error('Failed to execute command'))
const result = await binaryManager.isBinaryGood(binaryPath) const result = await binaryManager.isBinaryGood(binaryPath, goodVersions)
expect(result).to.be.false expect(result).to.be.false
expect(fsPathExistsStub.calledOnce).to.be.true expect(fsPathExistsStub.calledOnce).to.be.true
@ -342,7 +343,7 @@ describe('isBinaryGood', () => {
fsPathExistsStub.resolves(true) fsPathExistsStub.resolves(true)
execStub.resolves({ stdout }) execStub.resolves({ stdout })
const result = await binaryManager.isBinaryGood(binaryPath) const result = await binaryManager.isBinaryGood(binaryPath, goodVersions)
expect(result).to.be.false expect(result).to.be.false
expect(fsPathExistsStub.calledOnce).to.be.true expect(fsPathExistsStub.calledOnce).to.be.true
@ -356,7 +357,7 @@ describe('isBinaryGood', () => {
fsPathExistsStub.resolves(true) fsPathExistsStub.resolves(true)
execStub.resolves({ stdout }) execStub.resolves({ stdout })
const result = await binaryManager.isBinaryGood(binaryPath) const result = await binaryManager.isBinaryGood(binaryPath, goodVersions)
expect(result).to.be.false expect(result).to.be.false
expect(fsPathExistsStub.calledOnce).to.be.true expect(fsPathExistsStub.calledOnce).to.be.true
@ -370,7 +371,7 @@ describe('isBinaryGood', () => {
fsPathExistsStub.resolves(true) fsPathExistsStub.resolves(true)
execStub.resolves({ stdout }) execStub.resolves({ stdout })
const result = await binaryManager.isBinaryGood(binaryPath) const result = await binaryManager.isBinaryGood(binaryPath, goodVersions)
expect(result).to.be.true expect(result).to.be.true
expect(fsPathExistsStub.calledOnce).to.be.true expect(fsPathExistsStub.calledOnce).to.be.true