From eab1e13df267039423fb4f6317d2af14c55a36a4 Mon Sep 17 00:00:00 2001 From: Thomas Jensen Date: Fri, 5 Nov 2021 14:03:49 +0100 Subject: [PATCH] Fix a small bug when parsing the padding command line argument (-p) When an empty string was passed as padding spec, this was not properly flagged as an error. --- src/cmdline.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cmdline.c b/src/cmdline.c index cfdd8c1..5f390a7 100644 --- a/src/cmdline.c +++ b/src/cmdline.c @@ -344,10 +344,11 @@ static int killblank(opt_t *result, char *optarg) */ static int padding(opt_t *result, char *optarg) { - int errfl = 0; + int errfl = 1; char *p = optarg; while (*p) { + errfl = 0; if (p[1] == '\0') { errfl = 1; break; @@ -395,7 +396,7 @@ static int padding(opt_t *result, char *optarg) } } if (errfl) { - fprintf(stderr, "%s: invalid padding specification - %s\n", PROJECT, optarg); + bx_fprintf(stderr, "%s: invalid padding specification - %s\n", PROJECT, optarg); return 1; } return 0;