extern/bruno
1
0
Fork 1
mirror of https://github.com/usebruno/bruno.git synced 2024-11-22 07:53:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: validate docs links (#3122)

Browse Source 
* fix: validate docs links

* fix: only allow external urls, ignore filesystem paths

* fix: updates

* chore: revert spacing
This commit is contained in:
lohit 2024-09-18 17:02:39 +05:30 committed by GitHub
parent 938e0560a2
commit 07baa63e9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/bruno-app/src/components/MarkDown/index.jsx
View File

@ -2,6 +2,7 @@ import MarkdownIt from 'markdown-it';
import * as MarkdownItReplaceLink from 'markdown-it-replace-link'; import * as MarkdownItReplaceLink from 'markdown-it-replace-link';
import StyledWrapper from './StyledWrapper'; import StyledWrapper from './StyledWrapper';
import React from 'react'; import React from 'react';
import { isValidUrl } from 'utils/url/index';
const Markdown = ({ collectionPath, onDoubleClick, content }) => { const Markdown = ({ collectionPath, onDoubleClick, content }) => {
const markdownItOptions = { const markdownItOptions = {
@ -15,7 +16,7 @@ const Markdown = ({ collectionPath, onDoubleClick, content }) => {
if (target.tagName === 'A') { if (target.tagName === 'A') {
event.preventDefault(); event.preventDefault();
const href = target.getAttribute('href'); const href = target.getAttribute('href');
if (href) { if (href && isValidUrl(href)) {
window.open(href, '_blank'); window.open(href, '_blank');
return; return;
} }

11
packages/bruno-electron/src/index.js
View File

@ -129,8 +129,15 @@ app.on('ready', async () => {
} }
}); });
mainWindow.webContents.setWindowOpenHandler((details) => { mainWindow.webContents.setWindowOpenHandler(({ url }) => {
require('electron').shell.openExternal(details.url); try {
const { protocol } = new URL(url);
if (['https:', 'http:'].includes(protocol)) {
require('electron').shell.openExternal(url);
}
} catch (e) {
console.error(e);
}
return { action: 'deny' }; return { action: 'deny' };
}); });