extern/bruno
1
0
Fork 1
mirror of https://github.com/usebruno/bruno.git synced 2025-01-21 13:18:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3676 from pooja-bruno/fix/string-json-response

Browse Source 
fix: string json response error
This commit is contained in:
lohit 2024-12-27 16:30:32 +05:30 committed by GitHub
commit 1f2bee1f90
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/bruno-app/src/components/ResponsePane/QueryResult/index.js
View File

@ -20,14 +20,14 @@ const formatResponse = (data, mode, filter) => {
} }
if (data === null) { if (data === null) {
return data; return 'null';
} }
if (mode.includes('json')) { if (mode.includes('json')) {
let isValidJSON = false; let isValidJSON = false;
try { try {
isValidJSON = typeof JSON.parse(JSON.stringify(data)) === 'object'; isValidJSON = typeof JSON.parse(JSON.stringify(data)) === 'object'
} catch (error) { } catch (error) {
console.log('Error parsing JSON: ', error.message); console.log('Error parsing JSON: ', error.message);
} }

8
packages/bruno-electron/src/ipc/network/index.js
View File

@ -365,11 +365,15 @@ const parseDataFromResponse = (response, disableParsingResponseJson = false) =>
try { try {
// Filter out ZWNBSP character // Filter out ZWNBSP character
// https://gist.github.com/antic183/619f42b559b78028d1fe9e7ae8a1352d // https://gist.github.com/antic183/619f42b559b78028d1fe9e7ae8a1352d
// If the response is a string and starts and ends with double quotes, it's a stringified JSON and should not be parsed
data = data.replace(/^\uFEFF/, ''); data = data.replace(/^\uFEFF/, '');
if (!disableParsingResponseJson) { if ( !disableParsingResponseJson && ! (typeof data === 'string' && data.startsWith("\"") && data.endsWith("\""))) {
data = JSON.parse(data); data = JSON.parse(data);
} }
} catch { } } catch {
console.log('Failed to parse response data as JSON');
}
return { data, dataBuffer }; return { data, dataBuffer };
}; };