extern/bruno
1
0
Fork 1
mirror of https://github.com/usebruno/bruno.git synced 2025-06-27 23:41:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow empty values to be stored as timeout

Browse Source
This commit is contained in:
Anoop M D 2023-10-18 23:13:50 +05:30
parent 3f7ace8bdf
commit 1f6366f262
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/bruno-app/src/components/Preferences/General/index.js
View File

@ -12,10 +12,17 @@ const General = ({ close }) => {
const preferencesSchema = Yup.object().shape({ const preferencesSchema = Yup.object().shape({
sslVerification: Yup.boolean(), sslVerification: Yup.boolean(),
timeout: Yup.number('Request Timeout must be a number') timeout: Yup.mixed()
.positive('Request Timeout must be a positive number') .transform((value, originalValue) => {
.typeError('Request Timeout must be a number') return originalValue === '' ? undefined : value;
.optional() })
.nullable()
.test('isNumber', 'Request Timeout must be a number', (value) => {
return value === undefined || !isNaN(value);
})
.test('isValidTimeout', 'Request Timeout must be equal or greater than 0', (value) => {
return value === undefined || Number(value) >= 0;
})
}); });
const formik = useFormik({ const formik = useFormik({
@ -26,7 +33,7 @@ const General = ({ close }) => {
validationSchema: preferencesSchema, validationSchema: preferencesSchema,
onSubmit: async (values) => { onSubmit: async (values) => {
try { try {
const newPreferences = await proxySchema.validate(values, { abortEarly: true }); const newPreferences = await preferencesSchema.validate(values, { abortEarly: true });
handleSave(newPreferences); handleSave(newPreferences);
} catch (error) { } catch (error) {
console.error('Preferences validation error:', error.message); console.error('Preferences validation error:', error.message);