From 2e324238697c10a5eeb1cc1eb67123a5b4609940 Mon Sep 17 00:00:00 2001
From: Anoop M D <anoop.md1421@gmail.com>
Date: Sun, 29 Jan 2023 18:04:17 +0530
Subject: [PATCH] feat: better error messaging

---
 packages/bruno-app/package.json                              | 1 -
 .../src/components/ResponsePane/TestResults/index.js         | 4 ++--
 .../src/providers/ReduxStore/slices/collections/actions.js   | 5 ++---
 packages/bruno-app/src/utils/collections/index.js            | 4 ----
 packages/bruno-js/src/scripts/test-results.js                | 3 +++
 5 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/packages/bruno-app/package.json b/packages/bruno-app/package.json
index ab61a169d..53176ed9a 100644
--- a/packages/bruno-app/package.json
+++ b/packages/bruno-app/package.json
@@ -47,7 +47,6 @@
     "react-hot-toast": "^2.4.0",
     "react-redux": "^7.2.6",
     "react-tooltip": "^5.5.2",
-    "reckonjs": "^0.1.2",
     "sass": "^1.46.0",
     "split-on-first": "^3.0.0",
     "styled-components": "^5.3.3",
diff --git a/packages/bruno-app/src/components/ResponsePane/TestResults/index.js b/packages/bruno-app/src/components/ResponsePane/TestResults/index.js
index 7f66d7885..4dfa9cf40 100644
--- a/packages/bruno-app/src/components/ResponsePane/TestResults/index.js
+++ b/packages/bruno-app/src/components/ResponsePane/TestResults/index.js
@@ -19,8 +19,8 @@ const TestResults = ({ results }) => {
         Tests ({results.length}/{results.length}), Passed: {passedTests.length}, Failed: {failedTests.length}
       </div>
       <ul className="">
-        {results.map((result, index) => (
-          <li key={index} className="py-1">
+        {results.map((result) => (
+          <li key={result.uid} className="py-1">
             {result.status === 'pass' ? (
               <span className="test-success">
                 &#x2714;&nbsp; {result.description}
diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
index cdb7e1e9f..e92e1ccd7 100644
--- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
+++ b/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
@@ -1,5 +1,5 @@
 import path from 'path';
-import filter from 'lodash/filter';
+import toast from 'react-hot-toast';
 import trim from 'lodash/trim';
 import { uuid } from 'utils/common';
 import cloneDeep from 'lodash/cloneDeep';
@@ -17,7 +17,6 @@ import {
   isItemARequest,
   isItemAFolder,
   refreshUidsInItem,
-  interpolateEnvironmentVars
 } from 'utils/collections';
 import { collectionSchema, itemSchema, environmentSchema, environmentsSchema } from '@usebruno/schema';
 import { waitForNextTick } from 'utils/common';
@@ -131,7 +130,7 @@ export const sendRequest = (item, collectionUid) => (dispatch, getState) => {
         );
         console.log('>> sending request failed');
         console.log(err);
-        reject(err);
+        toast.error(err ? err.message : 'Something went wrong!');
       });
   });
 };
diff --git a/packages/bruno-app/src/utils/collections/index.js b/packages/bruno-app/src/utils/collections/index.js
index 55081ce5e..8628da56c 100644
--- a/packages/bruno-app/src/utils/collections/index.js
+++ b/packages/bruno-app/src/utils/collections/index.js
@@ -11,10 +11,6 @@ import cloneDeep from 'lodash/cloneDeep';
 import { uuid } from 'utils/common';
 import path from 'path';
 
-// although we are not using rekonjs directly
-// its populating the global string prototype with .reckon method
-import reckon from 'reckonjs';
-
 const replaceTabsWithSpaces = (str, numSpaces = 2) => {
   if (!str || !str.length || !isString(str)) {
     return '';
diff --git a/packages/bruno-js/src/scripts/test-results.js b/packages/bruno-js/src/scripts/test-results.js
index 17d35fe4f..6f65d9b74 100644
--- a/packages/bruno-js/src/scripts/test-results.js
+++ b/packages/bruno-js/src/scripts/test-results.js
@@ -1,9 +1,12 @@
+const {nanoid} = require('nanoid');
+
 class TestResults {
   constructor() {
     this.results = [];
   }
 
   addResult(result) {
+    result.uid = nanoid();
     this.results.push(result);
   }