extern/bruno
1
0
Fork 1
mirror of https://github.com/usebruno/bruno.git synced 2025-06-21 04:08:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: added some todo's for future code cleanup

Browse Source
This commit is contained in:
Anoop M D 2023-10-02 15:38:50 +05:30
parent ce77d08408
commit cbdd56e577
2 changed files with 37 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
packages/bruno-app/src/components/Sidebar/Collections/index.js
View File

@ -1,6 +1,12 @@
import React, { useState } from 'react'; import React, { useState } from 'react';
import { useDispatch, useSelector } from 'react-redux'; import { useDispatch, useSelector } from 'react-redux';
import { IconSearch, IconFolders, IconArrowsSort, IconSortAscendingLetters, IconSortDescendingLetters } from '@tabler/icons'; import {
IconSearch,
IconFolders,
IconArrowsSort,
IconSortAscendingLetters,
IconSortDescendingLetters
} from '@tabler/icons';
import Collection from '../Collections/Collection'; import Collection from '../Collections/Collection';
import CreateCollection from '../CreateCollection'; import CreateCollection from '../CreateCollection';
import StyledWrapper from './StyledWrapper'; import StyledWrapper from './StyledWrapper';
@ -9,44 +15,47 @@ import { DndProvider } from 'react-dnd';
import { HTML5Backend } from 'react-dnd-html5-backend'; import { HTML5Backend } from 'react-dnd-html5-backend';
import { sortCollections } from 'providers/ReduxStore/slices/collections/actions'; import { sortCollections } from 'providers/ReduxStore/slices/collections/actions';
// todo: move this to a separate folder
// the coding convention is to keep all the components in a folder named after the component
const CollectionsBadge = () => { const CollectionsBadge = () => {
const dispatch = useDispatch() const dispatch = useDispatch();
const { collections } = useSelector((state) => state.collections); const { collections } = useSelector((state) => state.collections);
const { collectionSortOrder } = useSelector((state) => state.collections); const { collectionSortOrder } = useSelector((state) => state.collections);
const sortCollectionOrder = () => { const sortCollectionOrder = () => {
let order; let order;
switch (collectionSortOrder) { switch (collectionSortOrder) {
case 'default': case 'default':
order = 'alphabetical' order = 'alphabetical';
break; break;
case 'alphabetical': case 'alphabetical':
order = 'reverseAlphabetical' order = 'reverseAlphabetical';
break; break;
case 'reverseAlphabetical': case 'reverseAlphabetical':
order = 'default' order = 'default';
break; break;
} }
dispatch(sortCollections({ order })) dispatch(sortCollections({ order }));
} };
return ( return (
<div className="items-center mt-2 relative"> <div className="items-center mt-2 relative">
<div className='collections-badge flex items-center justify-between px-2' > <div className="collections-badge flex items-center justify-between px-2">
<div className="flex items-center py-1 select-none"> <div className="flex items-center py-1 select-none">
<span className="mr-2"> <span className="mr-2">
<IconFolders size={18} strokeWidth={1.5} /> <IconFolders size={18} strokeWidth={1.5} />
</span> </span>
<span>Collections</span> <span>Collections</span>
</div> </div>
{ {collections.length >= 1 && (
collections.length >= 1 && <button onClick={() => sortCollectionOrder()} > <button onClick={() => sortCollectionOrder()}>
{ {collectionSortOrder == 'default' ? (
collectionSortOrder == 'default' ? <IconArrowsSort size={18} strokeWidth={1.5} /> : collectionSortOrder == 'alphabetical' ? <IconArrowsSort size={18} strokeWidth={1.5} />
<IconSortAscendingLetters size={18} strokeWidth={1.5} /> : <IconSortDescendingLetters size={18} strokeWidth={1.5} /> ) : collectionSortOrder == 'alphabetical' ? (
} <IconSortAscendingLetters size={18} strokeWidth={1.5} />
) : (
<IconSortDescendingLetters size={18} strokeWidth={1.5} />
)}
</button> </button>
} )}
</div> </div>
</div> </div>
); );

8
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
View File

@ -145,10 +145,12 @@ export const cancelRequest = (cancelTokenUid, item, collection) => (dispatch) =>
}) })
.catch((err) => console.log(err)); .catch((err) => console.log(err));
}; };
// todo: this can be directly put inside the collections/index.js file
// the coding convention is to put only actions that need ipc in this file
export const sortCollections = (order) => (dispatch) => { export const sortCollections = (order) => (dispatch) => {
console.log("working") dispatch(_sortCollections(order));
dispatch(_sortCollections(order)) };
}
export const runCollectionFolder = (collectionUid, folderUid, recursive) => (dispatch, getState) => { export const runCollectionFolder = (collectionUid, folderUid, recursive) => (dispatch, getState) => {
const state = getState(); const state = getState();
const collection = findCollectionByUid(state.collections.collections, collectionUid); const collection = findCollectionByUid(state.collections.collections, collectionUid);