diff --git a/package-lock.json b/package-lock.json index be8bc091c..67bfa6c95 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18862,4 +18862,4 @@ } } } -} \ No newline at end of file +} diff --git a/packages/bruno-app/src/components/CodeEditor/index.js b/packages/bruno-app/src/components/CodeEditor/index.js index df9103891..5998cf10a 100644 --- a/packages/bruno-app/src/components/CodeEditor/index.js +++ b/packages/bruno-app/src/components/CodeEditor/index.js @@ -55,6 +55,7 @@ if (!SERVER_RENDERED) { 'req.setMaxRedirects(maxRedirects)', 'req.getTimeout()', 'req.setTimeout(timeout)', + 'req.getExecutionMode()', 'bru', 'bru.cwd()', 'bru.getEnvName(key)', diff --git a/packages/bruno-app/src/components/CollectionSettings/Auth/AuthMode/index.js b/packages/bruno-app/src/components/CollectionSettings/Auth/AuthMode/index.js index c8e208acf..7dabb4c71 100644 --- a/packages/bruno-app/src/components/CollectionSettings/Auth/AuthMode/index.js +++ b/packages/bruno-app/src/components/CollectionSettings/Auth/AuthMode/index.js @@ -52,6 +52,15 @@ const AuthMode = ({ collection }) => { > Basic Auth +
{ + dropdownTippyRef.current.hide(); + onModeChange('wsse'); + }} + > + WSSE Auth +
{ diff --git a/packages/bruno-app/src/components/CollectionSettings/Auth/WsseAuth/StyledWrapper.js b/packages/bruno-app/src/components/CollectionSettings/Auth/WsseAuth/StyledWrapper.js new file mode 100644 index 000000000..c2bb5d207 --- /dev/null +++ b/packages/bruno-app/src/components/CollectionSettings/Auth/WsseAuth/StyledWrapper.js @@ -0,0 +1,16 @@ +import styled from 'styled-components'; + +const Wrapper = styled.div` + label { + font-size: 0.8125rem; + } + + .single-line-editor-wrapper { + padding: 0.15rem 0.4rem; + border-radius: 3px; + border: solid 1px ${(props) => props.theme.input.border}; + background-color: ${(props) => props.theme.input.bg}; + } +`; + +export default Wrapper; diff --git a/packages/bruno-app/src/components/CollectionSettings/Auth/WsseAuth/index.js b/packages/bruno-app/src/components/CollectionSettings/Auth/WsseAuth/index.js new file mode 100644 index 000000000..45efc7b1e --- /dev/null +++ b/packages/bruno-app/src/components/CollectionSettings/Auth/WsseAuth/index.js @@ -0,0 +1,71 @@ +import React from 'react'; +import get from 'lodash/get'; +import { useTheme } from 'providers/Theme'; +import { useDispatch } from 'react-redux'; +import SingleLineEditor from 'components/SingleLineEditor'; +import { updateCollectionAuth } from 'providers/ReduxStore/slices/collections'; +import { saveCollectionRoot } from 'providers/ReduxStore/slices/collections/actions'; +import StyledWrapper from './StyledWrapper'; + +const WsseAuth = ({ collection }) => { + const dispatch = useDispatch(); + const { storedTheme } = useTheme(); + + const wsseAuth = get(collection, 'root.request.auth.wsse', {}); + + const handleSave = () => dispatch(saveCollectionRoot(collection.uid)); + + const handleUserChange = (username) => { + dispatch( + updateCollectionAuth({ + mode: 'wsse', + collectionUid: collection.uid, + content: { + username, + password: wsseAuth.password + } + }) + ); + }; + + const handlePasswordChange = (password) => { + dispatch( + updateCollectionAuth({ + mode: 'wsse', + collectionUid: collection.uid, + content: { + username: wsseAuth.username, + password + } + }) + ); + }; + + return ( + + +
+ handleUserChange(val)} + collection={collection} + /> +
+ + +
+ handlePasswordChange(val)} + collection={collection} + /> +
+
+ ); +}; + +export default WsseAuth; diff --git a/packages/bruno-app/src/components/CollectionSettings/Auth/index.js b/packages/bruno-app/src/components/CollectionSettings/Auth/index.js index 85673782c..05efc17b2 100644 --- a/packages/bruno-app/src/components/CollectionSettings/Auth/index.js +++ b/packages/bruno-app/src/components/CollectionSettings/Auth/index.js @@ -6,6 +6,7 @@ import AwsV4Auth from './AwsV4Auth'; import BearerAuth from './BearerAuth'; import BasicAuth from './BasicAuth'; import DigestAuth from './DigestAuth'; +import WsseAuth from './WsseAuth'; import ApiKeyAuth from './ApiKeyAuth/'; import { saveCollectionRoot } from 'providers/ReduxStore/slices/collections/actions'; import StyledWrapper from './StyledWrapper'; @@ -34,6 +35,9 @@ const Auth = ({ collection }) => { case 'oauth2': { return ; } + case 'wsse': { + return ; + } case 'apikey': { return ; } diff --git a/packages/bruno-app/src/components/CollectionSettings/Vars/VarsTable/index.js b/packages/bruno-app/src/components/CollectionSettings/Vars/VarsTable/index.js index 950076b60..ebc6a2fe7 100644 --- a/packages/bruno-app/src/components/CollectionSettings/Vars/VarsTable/index.js +++ b/packages/bruno-app/src/components/CollectionSettings/Vars/VarsTable/index.js @@ -83,7 +83,6 @@ const VarsTable = ({ collection, vars, varType }) => {
Value -
) : ( diff --git a/packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js b/packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js index 05d9708b9..e45909c94 100644 --- a/packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js +++ b/packages/bruno-app/src/components/Environments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js @@ -88,7 +88,9 @@ const EnvironmentVariables = ({ environment, collection, setIsModified, original useEffect(() => { if (formik.dirty) { - addButtonRef.current?.scrollIntoView({ behavior: 'smooth' }); + // Smooth scrolling to the changed parameter is temporarily disabled + // due to UX issues when editing the first row in a long list of environment variables. + // addButtonRef.current?.scrollIntoView({ behavior: 'smooth' }); } }, [formik.values, formik.dirty]); diff --git a/packages/bruno-app/src/components/Environments/EnvironmentSettings/RenameEnvironment/index.js b/packages/bruno-app/src/components/Environments/EnvironmentSettings/RenameEnvironment/index.js index ac2d2623a..3ebcadca1 100644 --- a/packages/bruno-app/src/components/Environments/EnvironmentSettings/RenameEnvironment/index.js +++ b/packages/bruno-app/src/components/Environments/EnvironmentSettings/RenameEnvironment/index.js @@ -22,6 +22,9 @@ const RenameEnvironment = ({ onClose, environment, collection }) => { .required('name is required') }), onSubmit: (values) => { + if (values.name === environment.name) { + return; + } dispatch(renameEnvironment(values.name, environment.uid, collection.uid)) .then(() => { toast.success('Environment renamed successfully'); diff --git a/packages/bruno-app/src/components/FolderSettings/Vars/VarsTable/index.js b/packages/bruno-app/src/components/FolderSettings/Vars/VarsTable/index.js index d0a77de44..17d79629e 100644 --- a/packages/bruno-app/src/components/FolderSettings/Vars/VarsTable/index.js +++ b/packages/bruno-app/src/components/FolderSettings/Vars/VarsTable/index.js @@ -82,7 +82,6 @@ const VarsTable = ({ folder, collection, vars, varType }) => {
Value -
) : ( diff --git a/packages/bruno-app/src/components/Preferences/Font/StyledWrapper.js b/packages/bruno-app/src/components/Preferences/Display/Font/StyledWrapper.js similarity index 100% rename from packages/bruno-app/src/components/Preferences/Font/StyledWrapper.js rename to packages/bruno-app/src/components/Preferences/Display/Font/StyledWrapper.js diff --git a/packages/bruno-app/src/components/Preferences/Font/index.js b/packages/bruno-app/src/components/Preferences/Display/Font/index.js similarity index 93% rename from packages/bruno-app/src/components/Preferences/Font/index.js rename to packages/bruno-app/src/components/Preferences/Display/Font/index.js index ef6ac9f2f..622ea0817 100644 --- a/packages/bruno-app/src/components/Preferences/Font/index.js +++ b/packages/bruno-app/src/components/Preferences/Display/Font/index.js @@ -39,7 +39,7 @@ const Font = ({ close }) => {
- + { />
- + { + return ( +
+
+ + Theme + + +
+
+
+ +
+
+ ); +}; + +export default Display; diff --git a/packages/bruno-app/src/components/Preferences/General/index.js b/packages/bruno-app/src/components/Preferences/General/index.js index 9855c2747..0d26c955d 100644 --- a/packages/bruno-app/src/components/Preferences/General/index.js +++ b/packages/bruno-app/src/components/Preferences/General/index.js @@ -100,7 +100,7 @@ const General = ({ close }) => { return (
-
+
{ return ( -
+
diff --git a/packages/bruno-app/src/components/Preferences/StyledWrapper.js b/packages/bruno-app/src/components/Preferences/StyledWrapper.js index 9cb6e7f7e..f43047925 100644 --- a/packages/bruno-app/src/components/Preferences/StyledWrapper.js +++ b/packages/bruno-app/src/components/Preferences/StyledWrapper.js @@ -2,13 +2,12 @@ import styled from 'styled-components'; const StyledWrapper = styled.div` div.tabs { - margin-top: -0.5rem; - div.tab { - padding: 6px 0px; + width: 100%; + min-width: 120px; + padding: 7px 10px; border: none; border-bottom: solid 2px transparent; - margin-right: 1.25rem; color: var(--color-tab-inactive); cursor: pointer; @@ -22,8 +21,12 @@ const StyledWrapper = styled.div` } &.active { - color: ${(props) => props.theme.tabs.active.color} !important; - border-bottom: solid 2px ${(props) => props.theme.tabs.active.border} !important; + color: ${(props) => props.theme.sidebar.color} !important; + background: ${(props) => props.theme.sidebar.collection.item.bg}; + + &:hover { + background: ${(props) => props.theme.sidebar.collection.item.bg} !important; + } } } } diff --git a/packages/bruno-app/src/components/Preferences/index.js b/packages/bruno-app/src/components/Preferences/index.js index 843fd8228..03b1d9ef8 100644 --- a/packages/bruno-app/src/components/Preferences/index.js +++ b/packages/bruno-app/src/components/Preferences/index.js @@ -3,10 +3,9 @@ import classnames from 'classnames'; import React, { useState } from 'react'; import Support from './Support'; import General from './General'; -import Font from './Font'; -import Theme from './Theme'; import Proxy from './ProxySettings'; import StyledWrapper from './StyledWrapper'; +import Display from './Display/index'; const Preferences = ({ onClose }) => { const [tab, setTab] = useState('general'); @@ -27,41 +26,36 @@ const Preferences = ({ onClose }) => { return ; } - case 'theme': { - return ; + case 'display': { + return ; } case 'support': { return ; } - - case 'font': { - return ; - } } }; return ( -
-
setTab('general')}> - General -
-
setTab('theme')}> - Theme -
-
setTab('font')}> - Font -
-
setTab('proxy')}> - Proxy -
-
setTab('support')}> - Support +
+
+
setTab('general')}> + General +
+
setTab('display')}> + Display +
+
setTab('proxy')}> + Proxy +
+
setTab('support')}> + Support +
+
{getTabPanel(tab)}
-
{getTabPanel(tab)}
); diff --git a/packages/bruno-app/src/components/RequestPane/Auth/AuthMode/index.js b/packages/bruno-app/src/components/RequestPane/Auth/AuthMode/index.js index 9de35e5f2..dfbaba7fa 100644 --- a/packages/bruno-app/src/components/RequestPane/Auth/AuthMode/index.js +++ b/packages/bruno-app/src/components/RequestPane/Auth/AuthMode/index.js @@ -30,7 +30,6 @@ const AuthMode = ({ item, collection }) => { }) ); }; - return (
@@ -80,6 +79,15 @@ const AuthMode = ({ item, collection }) => { > OAuth 2.0
+
{ + dropdownTippyRef?.current?.hide(); + onModeChange('wsse'); + }} + > + WSSE Auth +
{ diff --git a/packages/bruno-app/src/components/RequestPane/Auth/WsseAuth/StyledWrapper.js b/packages/bruno-app/src/components/RequestPane/Auth/WsseAuth/StyledWrapper.js new file mode 100644 index 000000000..316d3a7c5 --- /dev/null +++ b/packages/bruno-app/src/components/RequestPane/Auth/WsseAuth/StyledWrapper.js @@ -0,0 +1,17 @@ +import styled from 'styled-components'; + +const Wrapper = styled.div` + label { + font-size: 0.8125rem; + } + + .single-line-editor-wrapper { + max-width: 400px; + padding: 0.15rem 0.4rem; + border-radius: 3px; + border: solid 1px ${(props) => props.theme.input.border}; + background-color: ${(props) => props.theme.input.bg}; + } +`; + +export default Wrapper; diff --git a/packages/bruno-app/src/components/RequestPane/Auth/WsseAuth/index.js b/packages/bruno-app/src/components/RequestPane/Auth/WsseAuth/index.js new file mode 100644 index 000000000..76a20e6f6 --- /dev/null +++ b/packages/bruno-app/src/components/RequestPane/Auth/WsseAuth/index.js @@ -0,0 +1,76 @@ +import React from 'react'; +import get from 'lodash/get'; +import { useTheme } from 'providers/Theme'; +import { useDispatch } from 'react-redux'; +import SingleLineEditor from 'components/SingleLineEditor'; +import { updateAuth } from 'providers/ReduxStore/slices/collections'; +import { sendRequest, saveRequest } from 'providers/ReduxStore/slices/collections/actions'; +import StyledWrapper from './StyledWrapper'; + +const WsseAuth = ({ item, collection }) => { + const dispatch = useDispatch(); + const { storedTheme } = useTheme(); + + const wsseAuth = item.draft ? get(item, 'draft.request.auth.wsse', {}) : get(item, 'request.auth.wsse', {}); + + const handleRun = () => dispatch(sendRequest(item, collection.uid)); + const handleSave = () => dispatch(saveRequest(item.uid, collection.uid)); + + const handleUserChange = (username) => { + dispatch( + updateAuth({ + mode: 'wsse', + collectionUid: collection.uid, + itemUid: item.uid, + content: { + username, + password: wsseAuth.password + } + }) + ); + }; + + const handlePasswordChange = (password) => { + dispatch( + updateAuth({ + mode: 'wsse', + collectionUid: collection.uid, + itemUid: item.uid, + content: { + username: wsseAuth.username, + password + } + }) + ); + }; + + return ( + + +
+ handleUserChange(val)} + onRun={handleRun} + collection={collection} + /> +
+ + +
+ handlePasswordChange(val)} + onRun={handleRun} + collection={collection} + /> +
+
+ ); +}; + +export default WsseAuth; diff --git a/packages/bruno-app/src/components/RequestPane/Auth/index.js b/packages/bruno-app/src/components/RequestPane/Auth/index.js index 2786f6d68..1515e5224 100644 --- a/packages/bruno-app/src/components/RequestPane/Auth/index.js +++ b/packages/bruno-app/src/components/RequestPane/Auth/index.js @@ -5,6 +5,7 @@ import AwsV4Auth from './AwsV4Auth'; import BearerAuth from './BearerAuth'; import BasicAuth from './BasicAuth'; import DigestAuth from './DigestAuth'; +import WsseAuth from './WsseAuth'; import ApiKeyAuth from './ApiKeyAuth'; import StyledWrapper from './StyledWrapper'; import { humanizeRequestAuthMode } from 'utils/collections/index'; @@ -33,6 +34,9 @@ const Auth = ({ item, collection }) => { case 'oauth2': { return ; } + case 'wsse': { + return ; + } case 'apikey': { return ; } diff --git a/packages/bruno-app/src/components/RequestPane/Vars/VarsTable/index.js b/packages/bruno-app/src/components/RequestPane/Vars/VarsTable/index.js index 84f040c6e..0f94f35bb 100644 --- a/packages/bruno-app/src/components/RequestPane/Vars/VarsTable/index.js +++ b/packages/bruno-app/src/components/RequestPane/Vars/VarsTable/index.js @@ -83,7 +83,6 @@ const VarsTable = ({ item, collection, vars, varType }) => {
Value -
) : ( diff --git a/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js b/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js index 557c828d2..76464e8b1 100644 --- a/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js +++ b/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js @@ -18,6 +18,7 @@ import CloneCollectionItem from 'components/Sidebar/Collections/Collection/Colle import NewRequest from 'components/Sidebar/NewRequest/index'; import CloseTabIcon from './CloseTabIcon'; import DraftTabIcon from './DraftTabIcon'; +import { flattenItems } from 'utils/collections/index'; const RequestTab = ({ tab, collection, tabIndex, collectionRequestTabs, folderUid }) => { const dispatch = useDispatch(); @@ -282,11 +283,10 @@ function RequestTabMenu({ onDropdownCreate, onCloseTabs, collectionRequestTabs, function handleCloseSavedTabs(event) { event.stopPropagation(); - const savedTabs = collectionRequestTabs.filter((tab) => { - const item = findItemInCollection(collection, tab.uid) - return item && !item.draft; - }); - onCloseTabs(savedTabs.map((tab) => tab.uid)); + const items = flattenItems(collection?.items); + const savedTabs = items?.filter?.((item) => !item.draft); + const savedTabIds = savedTabs?.map((item) => item.uid) || []; + onCloseTabs(savedTabIds); } function handleCloseAllTabs(event) { diff --git a/packages/bruno-app/src/components/RunnerResults/ResponsePane/index.js b/packages/bruno-app/src/components/RunnerResults/ResponsePane/index.js index 007d398c0..8fd8de9d9 100644 --- a/packages/bruno-app/src/components/RunnerResults/ResponsePane/index.js +++ b/packages/bruno-app/src/components/RunnerResults/ResponsePane/index.js @@ -15,7 +15,7 @@ import StyledWrapper from './StyledWrapper'; const ResponsePane = ({ rightPaneWidth, item, collection }) => { const [selectedTab, setSelectedTab] = useState('response'); - const { requestSent, responseReceived, testResults, assertionResults } = item; + const { requestSent, responseReceived, testResults, assertionResults, error } = item; const headers = get(item, 'responseReceived.headers', []); const status = get(item, 'responseReceived.status', 0); @@ -36,6 +36,7 @@ const ResponsePane = ({ rightPaneWidth, item, collection }) => { data={responseReceived.data} dataBuffer={responseReceived.dataBuffer} headers={responseReceived.headers} + error={error} key={item.filename} /> ); diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/CodeView/index.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/CodeView/index.js index 78977cabb..9d5648907 100644 --- a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/CodeView/index.js +++ b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/CodeView/index.js @@ -32,7 +32,10 @@ const CodeView = ({ language, item }) => { let snippet = ''; try { - snippet = new HTTPSnippet(buildHarRequest({ request: item.request, headers })).convert(target, client); + snippet = new HTTPSnippet(buildHarRequest({ request: item.request, headers, type: item.type })).convert( + target, + client + ); } catch (e) { console.error(e); snippet = 'Error generating code snippet'; diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/RenameCollectionItem/index.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/RenameCollectionItem/index.js index 5711cdbcd..6cf8cb21a 100644 --- a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/RenameCollectionItem/index.js +++ b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/RenameCollectionItem/index.js @@ -28,9 +28,12 @@ const RenameCollectionItem = ({ collection, item, onClose }) => { if (!isFolder && item.draft) { await dispatch(saveRequest(item.uid, collection.uid, true)); } + if (item.name === values.name) { + return; + } dispatch(renameItem(values.name, item.uid, collection.uid)) .then(() => { - toast.success('Request renamed!'); + toast.success('Request renamed'); onClose(); }) .catch((err) => { @@ -55,7 +58,7 @@ const RenameCollectionItem = ({ collection, item, onClose }) => { handleConfirm={onSubmit} handleCancel={onClose} > - e.preventDefault()}> + e.preventDefault()}>
)} - {!isFolder && item.type === 'http-request' && ( + {!isFolder && (item.type === 'http-request' || item.type === 'graphql-request') && (
{ diff --git a/packages/bruno-app/src/components/Sidebar/index.js b/packages/bruno-app/src/components/Sidebar/index.js index fd878521a..cc878bcc9 100644 --- a/packages/bruno-app/src/components/Sidebar/index.js +++ b/packages/bruno-app/src/components/Sidebar/index.js @@ -185,7 +185,7 @@ const Sidebar = () => { Star */}
-
v1.30.0
+
v1.30.1
diff --git a/packages/bruno-app/src/components/StopWatch/index.js b/packages/bruno-app/src/components/StopWatch/index.js index e2b069532..debba9cd8 100644 --- a/packages/bruno-app/src/components/StopWatch/index.js +++ b/packages/bruno-app/src/components/StopWatch/index.js @@ -1,25 +1,23 @@ import React, { useState, useEffect } from 'react'; -const StopWatch = ({ requestTimestamp }) => { +const StopWatch = () => { const [milliseconds, setMilliseconds] = useState(0); - const tickInterval = 200; + const tickInterval = 100; const tick = () => { - setMilliseconds(milliseconds + tickInterval); + setMilliseconds(_milliseconds => _milliseconds + tickInterval); }; useEffect(() => { - let timerID = setInterval(() => tick(), tickInterval); + let timerID = setInterval(() => { + tick() + }, tickInterval); return () => { - clearInterval(timerID); + clearTimeout(timerID); }; - }); + }, []); - useEffect(() => { - setMilliseconds(Date.now() - requestTimestamp); - }, [requestTimestamp]); - - if (milliseconds < 1000) { + if (milliseconds < 250) { return 'Loading...'; } @@ -27,4 +25,4 @@ const StopWatch = ({ requestTimestamp }) => { return {seconds.toFixed(1)}s; }; -export default StopWatch; +export default React.memo(StopWatch); diff --git a/packages/bruno-app/src/components/Welcome/index.js b/packages/bruno-app/src/components/Welcome/index.js index 0ec4c1245..64100224c 100644 --- a/packages/bruno-app/src/components/Welcome/index.js +++ b/packages/bruno-app/src/components/Welcome/index.js @@ -21,9 +21,7 @@ const Welcome = () => { const [importCollectionLocationModalOpen, setImportCollectionLocationModalOpen] = useState(false); const handleOpenCollection = () => { - dispatch(openCollection()).catch( - (err) => console.log(err) && toast.error(t('WELCOME.COLLECTION_OPEN_ERROR')) - ); + dispatch(openCollection()).catch((err) => console.log(err) && toast.error(t('WELCOME.COLLECTION_OPEN_ERROR'))); }; const handleImportCollection = ({ collection, translationLog }) => { @@ -64,7 +62,7 @@ const Welcome = () => { /> ) : null} -
+
bruno
@@ -72,40 +70,69 @@ const Welcome = () => {
{t('COMMON.COLLECTIONS')}
-
setCreateCollectionModalOpen(true)}> - +
-
- + + +
-
setImportCollectionModalOpen(true)}> - + + +
+
+
{t('WELCOME.LINKS')}
diff --git a/packages/bruno-app/src/providers/App/useTelemetry.js b/packages/bruno-app/src/providers/App/useTelemetry.js index cd69d08cc..55b0bbdad 100644 --- a/packages/bruno-app/src/providers/App/useTelemetry.js +++ b/packages/bruno-app/src/providers/App/useTelemetry.js @@ -60,7 +60,7 @@ const trackStart = () => { event: 'start', properties: { os: platformLib.os.family, - version: '1.30.0' + version: '1.30.1' } }); }; diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js index 054b4fbd4..777a194ab 100644 --- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js +++ b/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js @@ -43,6 +43,7 @@ import { resolveRequestFilename } from 'utils/common/platform'; import { parsePathParams, parseQueryParams, splitOnFirst } from 'utils/url/index'; import { sendCollectionOauth2Request as _sendCollectionOauth2Request } from 'utils/network/index'; import { name } from 'file-loader'; +import slash from 'utils/common/slash'; export const renameCollection = (newName, collectionUid) => (dispatch, getState) => { const state = getState(); @@ -401,7 +402,7 @@ export const renameItem = (newName, itemUid, collectionUid) => (dispatch, getSta } const { ipcRenderer } = window; - ipcRenderer.invoke('renderer:rename-item', item.pathname, newPathname, newName).then(resolve).catch(reject); + ipcRenderer.invoke('renderer:rename-item', slash(item.pathname), newPathname, newName).then(resolve).catch(reject); }); }; diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js index 34a6c6af9..b7ef2f86e 100644 --- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js +++ b/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js @@ -477,6 +477,10 @@ export const collectionsSlice = createSlice({ item.draft.request.auth.mode = 'oauth2'; item.draft.request.auth.oauth2 = action.payload.content; break; + case 'wsse': + item.draft.request.auth.mode = 'wsse'; + item.draft.request.auth.wsse = action.payload.content; + break; case 'apikey': item.draft.request.auth.mode = 'apikey'; item.draft.request.auth.apikey = action.payload.content; @@ -1141,6 +1145,9 @@ export const collectionsSlice = createSlice({ case 'oauth2': set(collection, 'root.request.auth.oauth2', action.payload.content); break; + case 'wsse': + set(collection, 'root.request.auth.wsse', action.payload.content); + break; case 'apikey': set(collection, 'root.request.auth.apikey', action.payload.content); break; diff --git a/packages/bruno-app/src/utils/codegenerator/har.js b/packages/bruno-app/src/utils/codegenerator/har.js index fa0738503..9bbd0eea9 100644 --- a/packages/bruno-app/src/utils/codegenerator/har.js +++ b/packages/bruno-app/src/utils/codegenerator/har.js @@ -31,6 +31,7 @@ const createHeaders = (request, headers) => { if (contentType !== '') { enabledHeaders.push({ name: 'content-type', value: contentType }); } + return enabledHeaders; }; @@ -43,7 +44,14 @@ const createQuery = (queryParams = []) => { })); }; -const createPostData = (body) => { +const createPostData = (body, type) => { + if (type === 'graphql-request') { + return { + mimeType: 'application/json', + text: JSON.stringify(body[body.mode]) + }; + } + const contentType = createContentType(body.mode); if (body.mode === 'formUrlEncoded' || body.mode === 'multipartForm') { return { @@ -64,7 +72,7 @@ const createPostData = (body) => { } }; -export const buildHarRequest = ({ request, headers }) => { +export const buildHarRequest = ({ request, headers, type }) => { return { method: request.method, url: encodeURI(request.url), @@ -72,7 +80,7 @@ export const buildHarRequest = ({ request, headers }) => { cookies: [], headers: createHeaders(request, headers), queryString: createQuery(request.params), - postData: createPostData(request.body), + postData: createPostData(request.body, type), headersSize: 0, bodySize: 0 }; diff --git a/packages/bruno-app/src/utils/collections/index.js b/packages/bruno-app/src/utils/collections/index.js index 99d9b269c..ea8712be5 100644 --- a/packages/bruno-app/src/utils/collections/index.js +++ b/packages/bruno-app/src/utils/collections/index.js @@ -379,7 +379,12 @@ export const transformCollectionToSaveToExportAsFile = (collection, options = {} placement: get(si.request, 'auth.apikey.placement', 'header') }; break; - + case 'wsse': + di.request.auth.wsse = { + username: get(si.request, 'auth.wsse.username', ''), + password: get(si.request, 'auth.wsse.password', '') + }; + break; default: break; } @@ -669,6 +674,10 @@ export const humanizeRequestAuthMode = (mode) => { label = 'OAuth 2.0'; break; } + case 'wsse': { + label = 'WSSE Auth'; + break; + } case 'apikey': { label = 'API Key'; break; diff --git a/packages/bruno-app/src/utils/importers/insomnia-collection.js b/packages/bruno-app/src/utils/importers/insomnia-collection.js index 0fec995ca..ae74f1613 100644 --- a/packages/bruno-app/src/utils/importers/insomnia-collection.js +++ b/packages/bruno-app/src/utils/importers/insomnia-collection.js @@ -174,7 +174,7 @@ const transformInsomniaRequestItem = (request, index, allRequests) => { } else if (mimeType === 'text/plain') { brunoRequestItem.request.body.mode = 'text'; brunoRequestItem.request.body.text = request.body.text; - } else if (mimeType === 'text/xml') { + } else if (mimeType === 'text/xml' || mimeType === 'application/xml') { brunoRequestItem.request.body.mode = 'xml'; brunoRequestItem.request.body.xml = request.body.text; } else if (mimeType === 'application/graphql') { diff --git a/packages/bruno-app/src/utils/importers/openapi-collection.js b/packages/bruno-app/src/utils/importers/openapi-collection.js index 3bfe8394f..fd25b7f51 100644 --- a/packages/bruno-app/src/utils/importers/openapi-collection.js +++ b/packages/bruno-app/src/utils/importers/openapi-collection.js @@ -32,7 +32,7 @@ const readFile = (files) => { const ensureUrl = (url) => { // emoving multiple slashes after the protocol if it exists, or after the beginning of the string otherwise - return url.replace(/(^\w+:|^)\/{2,}/, '$1/'); + return url.replace(/([^:])\/{2,}/g, '$1/'); }; const buildEmptyJsonBody = (bodySchema) => { diff --git a/packages/bruno-app/src/utils/importers/postman-collection.js b/packages/bruno-app/src/utils/importers/postman-collection.js index 4486e0efc..053a55723 100644 --- a/packages/bruno-app/src/utils/importers/postman-collection.js +++ b/packages/bruno-app/src/utils/importers/postman-collection.js @@ -54,13 +54,54 @@ const convertV21Auth = (array) => { }, {}); }; +const constructUrlFromParts = (url) => { + const { protocol = 'http', host, path, port, query, hash } = url || {}; + const hostStr = Array.isArray(host) ? host.filter(Boolean).join('.') : host || ''; + const pathStr = Array.isArray(path) ? path.filter(Boolean).join('/') : path || ''; + const portStr = port ? `:${port}` : ''; + const queryStr = + query && Array.isArray(query) && query.length > 0 + ? `?${query + .filter((q) => q.key) + .map((q) => `${q.key}=${q.value || ''}`) + .join('&')}` + : ''; + const urlStr = `${protocol}://${hostStr}${portStr}${pathStr ? `/${pathStr}` : ''}${queryStr}`; + return urlStr; +}; + +const constructUrl = (url) => { + if (!url) return ''; + + if (typeof url === 'string') { + return url; + } + + if (typeof url === 'object') { + const { raw } = url; + + if (raw && typeof raw === 'string') { + // If the raw URL contains url-fragments remove it + if (raw.includes('#')) { + return raw.split('#')[0]; // Returns the part of raw URL without the url-fragment part. + } + return raw; + } + + // If no raw value exists, construct the URL from parts + return constructUrlFromParts(url); + } + + return ''; +}; + let translationLog = {}; const importPostmanV2CollectionItem = (brunoParent, item, parentAuth, options) => { brunoParent.items = brunoParent.items || []; const folderMap = {}; const requestMap = {}; - + each(item, (i) => { if (isItemAFolder(i)) { const baseFolderName = i.name; @@ -86,20 +127,15 @@ const importPostmanV2CollectionItem = (brunoParent, item, parentAuth, options) = } else { if (i.request) { const baseRequestName = i.name; - let requestName = baseRequestName; + let requestName = baseRequestName; let count = 1; while (requestMap[requestName]) { requestName = `${baseRequestName}_${count}`; count++; } - - let url = ''; - if (typeof i.request.url === 'string') { - url = i.request.url; - } else { - url = get(i, 'request.url.raw') || ''; - } + + const url = constructUrl(i.request.url); const brunoRequestItem = { uid: uuid(), @@ -107,7 +143,7 @@ const importPostmanV2CollectionItem = (brunoParent, item, parentAuth, options) = type: 'http-request', request: { url: url, - method: i.request.method, + method: i?.request?.method?.toUpperCase(), auth: { mode: 'none', basic: null, @@ -313,12 +349,17 @@ const importPostmanV2CollectionItem = (brunoParent, item, parentAuth, options) = }); }); - each(get(i, 'request.url.variable'), (param) => { + each(get(i, 'request.url.variable', []), (param) => { + if (!param.key) { + // If no key, skip this iteration and discard the param + return; + } + brunoRequestItem.request.params.push({ uid: uuid(), name: param.key, - value: param.value, - description: param.description, + value: param.value ?? '', + description: param.description ?? '', type: 'path', enabled: true }); diff --git a/packages/bruno-cli/src/runner/interpolate-vars.js b/packages/bruno-cli/src/runner/interpolate-vars.js index c35456993..0253c10cd 100644 --- a/packages/bruno-cli/src/runner/interpolate-vars.js +++ b/packages/bruno-cli/src/runner/interpolate-vars.js @@ -1,5 +1,6 @@ const { interpolate } = require('@usebruno/common'); const { each, forOwn, cloneDeep, find } = require('lodash'); +const FormData = require('form-data'); const getContentType = (headers = {}) => { let contentType = ''; @@ -78,6 +79,14 @@ const interpolateVars = (request, envVars = {}, runtimeVariables = {}, processEn request.data = JSON.parse(parsed); } catch (err) {} } + } else if (contentType === 'multipart/form-data') { + if (typeof request.data === 'object' && !(request?.data instanceof FormData)) { + try { + let parsed = JSON.stringify(request.data); + parsed = _interpolate(parsed); + request.data = JSON.parse(parsed); + } catch (err) {} + } } else { request.data = _interpolate(request.data); } @@ -113,7 +122,8 @@ const interpolateVars = (request, envVars = {}, runtimeVariables = {}, processEn }) .join(''); - request.url = url.origin + interpolatedUrlPath + url.search; + const trailingSlash = url.pathname.endsWith('/') ? '/' : ''; + request.url = url.origin + interpolatedUrlPath + trailingSlash + url.search; } if (request.proxy) { diff --git a/packages/bruno-cli/src/runner/prepare-request.js b/packages/bruno-cli/src/runner/prepare-request.js index e30f8337f..d6688a1ff 100644 --- a/packages/bruno-cli/src/runner/prepare-request.js +++ b/packages/bruno-cli/src/runner/prepare-request.js @@ -2,6 +2,7 @@ const { get, each, filter } = require('lodash'); const fs = require('fs'); var JSONbig = require('json-bigint'); const decomment = require('decomment'); +const crypto = require('node:crypto'); const prepareRequest = (request, collectionRoot) => { const headers = {}; @@ -69,6 +70,24 @@ const prepareRequest = (request, collectionRoot) => { if (request.auth.mode === 'bearer') { axiosRequest.headers['Authorization'] = `Bearer ${get(request, 'auth.bearer.token')}`; } + + if (request.auth.mode === 'wsse') { + const username = get(request, 'auth.wsse.username', ''); + const password = get(request, 'auth.wsse.password', ''); + + const ts = new Date().toISOString(); + const nonce = crypto.randomBytes(16).toString('base64'); + + // Create the password digest using SHA-256 + const hash = crypto.createHash('sha256'); + hash.update(nonce + ts + password); + const digest = hash.digest('base64'); + + // Construct the WSSE header + axiosRequest.headers[ + 'X-WSSE' + ] = `UsernameToken Username="${username}", PasswordDigest="${digest}", Created="${ts}", Nonce="${nonce}"`; + } } request.body = request.body || {}; @@ -120,16 +139,10 @@ const prepareRequest = (request, collectionRoot) => { } if (request.body.mode === 'multipartForm') { + axiosRequest.headers['content-type'] = 'multipart/form-data'; const params = {}; const enabledParams = filter(request.body.multipartForm, (p) => p.enabled); - each(enabledParams, (p) => { - if (p.type === 'file') { - params[p.name] = p.value.map((path) => fs.createReadStream(path)); - } else { - params[p.name] = p.value; - } - }); - axiosRequest.headers['content-type'] = 'multipart/form-data'; + each(enabledParams, (p) => (params[p.name] = p.value)); axiosRequest.data = params; } diff --git a/packages/bruno-cli/src/runner/run-single-request.js b/packages/bruno-cli/src/runner/run-single-request.js index b260f6be9..cb59c78ba 100644 --- a/packages/bruno-cli/src/runner/run-single-request.js +++ b/packages/bruno-cli/src/runner/run-single-request.js @@ -19,6 +19,7 @@ const { makeAxiosInstance } = require('../utils/axios-instance'); const { addAwsV4Interceptor, resolveAwsV4Credentials } = require('./awsv4auth-helper'); const { shouldUseProxy, PatchedHttpsProxyAgent } = require('../utils/proxy-util'); const path = require('path'); +const { createFormData } = require('../utils/common'); const protocolRegex = /^([-+\w]{1,25})(:?\/\/|:)/; const onConsoleLog = (type, args) => { @@ -42,24 +43,11 @@ const runSingleRequest = async function ( request = prepareRequest(bruJson.request, collectionRoot); + request.__bruno__executionMode = 'cli'; + const scriptingConfig = get(brunoConfig, 'scripts', {}); scriptingConfig.runtime = runtime; - // make axios work in node using form data - // reference: https://github.com/axios/axios/issues/1006#issuecomment-320165427 - if (request.headers && request.headers['content-type'] === 'multipart/form-data') { - const form = new FormData(); - forOwn(request.data, (value, key) => { - if (value instanceof Array) { - each(value, (v) => form.append(key, v)); - } else { - form.append(key, value); - } - }); - extend(request.headers, form.getHeaders()); - request.data = form; - } - // run pre request script const requestScriptFile = compact([ get(collectionRoot, 'request.script.req'), @@ -195,6 +183,14 @@ const runSingleRequest = async function ( request.data = qs.stringify(request.data); } + if (request?.headers?.['content-type'] === 'multipart/form-data') { + if (!(request?.data instanceof FormData)) { + let form = createFormData(request.data, collectionPath); + request.data = form; + extend(request.headers, form.getHeaders()); + } + } + let response, responseTime; try { // run request diff --git a/packages/bruno-cli/src/utils/common.js b/packages/bruno-cli/src/utils/common.js index 704928022..16c2d1a7b 100644 --- a/packages/bruno-cli/src/utils/common.js +++ b/packages/bruno-cli/src/utils/common.js @@ -1,3 +1,8 @@ +const fs = require('fs'); +const FormData = require('form-data'); +const { forOwn } = require('lodash'); +const path = require('path'); + const lpad = (str, width) => { let paddedStr = str; while (paddedStr.length < width) { @@ -14,7 +19,33 @@ const rpad = (str, width) => { return paddedStr; }; +const createFormData = (datas, collectionPath) => { + // make axios work in node using form data + // reference: https://github.com/axios/axios/issues/1006#issuecomment-320165427 + const form = new FormData(); + forOwn(datas, (value, key) => { + if (typeof value == 'string') { + form.append(key, value); + return; + } + + const filePaths = value || []; + filePaths?.forEach?.((filePath) => { + let trimmedFilePath = filePath.trim(); + + if (!path.isAbsolute(trimmedFilePath)) { + trimmedFilePath = path.join(collectionPath, trimmedFilePath); + } + + form.append(key, fs.createReadStream(trimmedFilePath), path.basename(trimmedFilePath)); + }); + }); + return form; +}; + + module.exports = { lpad, - rpad + rpad, + createFormData }; diff --git a/packages/bruno-electron/package.json b/packages/bruno-electron/package.json index ad1b2c53f..b158989aa 100644 --- a/packages/bruno-electron/package.json +++ b/packages/bruno-electron/package.json @@ -1,5 +1,5 @@ { - "version": "v1.30.0", + "version": "v1.30.1", "name": "bruno", "description": "Opensource API Client for Exploring and Testing APIs", "homepage": "https://www.usebruno.com", diff --git a/packages/bruno-electron/src/ipc/collection.js b/packages/bruno-electron/src/ipc/collection.js index 945c21559..950902ece 100644 --- a/packages/bruno-electron/src/ipc/collection.js +++ b/packages/bruno-electron/src/ipc/collection.js @@ -16,6 +16,8 @@ const { sanitizeDirectoryName, isWSLPath, normalizeWslPath, + normalizeAndResolvePath, + safeToRename } = require('../utils/filesystem'); const { openCollectionDialog } = require('../app/collections'); const { generateUidBasedOnHash, stringifyJson, safeParseJSON, safeStringifyJSON } = require('../utils/common'); @@ -296,7 +298,7 @@ const registerRendererEventHandlers = (mainWindow, watcher, lastOpenedCollection } const newEnvFilePath = path.join(envDirPath, `${newName}.bru`); - if (fs.existsSync(newEnvFilePath)) { + if (!safeToRename(envFilePath, newEnvFilePath)) { throw new Error(`environment: ${newEnvFilePath} already exists`); } @@ -329,21 +331,18 @@ const registerRendererEventHandlers = (mainWindow, watcher, lastOpenedCollection ipcMain.handle('renderer:rename-item', async (event, oldPath, newPath, newName) => { try { // Normalize paths if they are WSL paths - if (isWSLPath(oldPath)) { - oldPath = normalizeWslPath(oldPath); - } - if (isWSLPath(newPath)) { - newPath = normalizeWslPath(newPath); - } + oldPath = isWSLPath(oldPath) ? normalizeWslPath(oldPath) : normalizeAndResolvePath(oldPath); + newPath = isWSLPath(newPath) ? normalizeWslPath(newPath) : normalizeAndResolvePath(newPath); + // Check if the old path exists if (!fs.existsSync(oldPath)) { throw new Error(`path: ${oldPath} does not exist`); } - if (fs.existsSync(newPath)) { - throw new Error(`path: ${oldPath} already exists`); + + if (!safeToRename(oldPath, newPath)) { + throw new Error(`path: ${newPath} already exists`); } - // if its directory, rename and return if (isDirectory(oldPath)) { const bruFilesAtSource = await searchForBruFiles(oldPath); @@ -364,12 +363,13 @@ const registerRendererEventHandlers = (mainWindow, watcher, lastOpenedCollection const jsonData = bruToJson(data); jsonData.name = newName; - moveRequestUid(oldPath, newPath); const content = jsonToBru(jsonData); - await writeFile(newPath, content); await fs.unlinkSync(oldPath); + await writeFile(newPath, content); + + return newPath; } catch (error) { return Promise.reject(error); } diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js index d7ed96d28..328232e31 100644 --- a/packages/bruno-electron/src/ipc/network/index.js +++ b/packages/bruno-electron/src/ipc/network/index.js @@ -9,7 +9,7 @@ const decomment = require('decomment'); const contentDispositionParser = require('content-disposition'); const mime = require('mime-types'); const { ipcMain } = require('electron'); -const { isUndefined, isNull, each, get, compact, cloneDeep } = require('lodash'); +const { isUndefined, isNull, each, get, compact, cloneDeep, forOwn, extend } = require('lodash'); const { VarsRuntime, AssertRuntime, ScriptRuntime, TestRuntime } = require('@usebruno/js'); const prepareRequest = require('./prepare-request'); const prepareCollectionRequest = require('./prepare-collection-request'); @@ -37,6 +37,8 @@ const { } = require('./oauth2-helper'); const Oauth2Store = require('../../store/oauth2'); const iconv = require('iconv-lite'); +const FormData = require('form-data'); +const { createFormData } = prepareRequest; const safeStringifyJSON = (data) => { try { @@ -423,6 +425,14 @@ const registerNetworkIpc = (mainWindow) => { request.data = qs.stringify(request.data); } + if (request.headers['content-type'] === 'multipart/form-data') { + if (!(request.data instanceof FormData)) { + let form = createFormData(request.data, collectionPath); + request.data = form; + extend(request.headers, form.getHeaders()); + } + } + return scriptResult; }; @@ -515,6 +525,7 @@ const registerNetworkIpc = (mainWindow) => { const collectionRoot = get(collection, 'root', {}); const request = prepareRequest(item, collection); + request.__bruno__executionMode = 'standalone'; const envVars = getEnvVars(environment); const processEnvVars = getProcessEnvVars(collectionUid); const brunoConfig = getBrunoConfig(collectionUid); @@ -707,6 +718,7 @@ const registerNetworkIpc = (mainWindow) => { const collectionRoot = get(collection, 'root', {}); const _request = collectionRoot?.request; const request = prepareCollectionRequest(_request, collectionRoot, collectionPath); + request.__bruno__executionMode = 'standalone'; const envVars = getEnvVars(environment); const processEnvVars = getProcessEnvVars(collectionUid); const brunoConfig = getBrunoConfig(collectionUid); @@ -950,6 +962,8 @@ const registerNetworkIpc = (mainWindow) => { }); const request = prepareRequest(item, collection); + request.__bruno__executionMode = 'runner'; + const requestUid = uuid(); const processEnvVars = getProcessEnvVars(collectionUid); diff --git a/packages/bruno-electron/src/ipc/network/interpolate-vars.js b/packages/bruno-electron/src/ipc/network/interpolate-vars.js index b6aeaa078..5ea2bf7f4 100644 --- a/packages/bruno-electron/src/ipc/network/interpolate-vars.js +++ b/packages/bruno-electron/src/ipc/network/interpolate-vars.js @@ -1,5 +1,6 @@ const { interpolate } = require('@usebruno/common'); const { each, forOwn, cloneDeep, find } = require('lodash'); +const FormData = require('form-data'); const getContentType = (headers = {}) => { let contentType = ''; @@ -76,6 +77,14 @@ const interpolateVars = (request, envVariables = {}, runtimeVariables = {}, proc request.data = JSON.parse(parsed); } catch (err) {} } + } else if (contentType === 'multipart/form-data') { + if (typeof request.data === 'object' && !(request.data instanceof FormData)) { + try { + let parsed = JSON.stringify(request.data); + parsed = _interpolate(parsed); + request.data = JSON.parse(parsed); + } catch (err) {} + } } else { request.data = _interpolate(request.data); } @@ -111,7 +120,8 @@ const interpolateVars = (request, envVariables = {}, runtimeVariables = {}, proc }) .join(''); - request.url = url.origin + urlPathnameInterpolatedWithPathParams + url.search; + const trailingSlash = url.pathname.endsWith('/') ? '/' : ''; + request.url = url.origin + urlPathnameInterpolatedWithPathParams + trailingSlash + url.search; } if (request.proxy) { @@ -206,6 +216,12 @@ const interpolateVars = (request, envVariables = {}, runtimeVariables = {}, proc request.digestConfig.password = _interpolate(request.digestConfig.password) || ''; } + // interpolate vars for wsse auth + if (request.wsse) { + request.wsse.username = _interpolate(request.wsse.username) || ''; + request.wsse.password = _interpolate(request.wsse.password) || ''; + } + return request; }; diff --git a/packages/bruno-electron/src/ipc/network/prepare-request.js b/packages/bruno-electron/src/ipc/network/prepare-request.js index 75b0f2c0e..0bac42af9 100644 --- a/packages/bruno-electron/src/ipc/network/prepare-request.js +++ b/packages/bruno-electron/src/ipc/network/prepare-request.js @@ -1,9 +1,10 @@ const os = require('os'); -const { get, each, filter, extend, compact } = require('lodash'); +const { get, each, filter, compact, forOwn } = require('lodash'); const decomment = require('decomment'); const FormData = require('form-data'); const fs = require('fs'); const path = require('path'); +const crypto = require('node:crypto'); const { getTreePathFromCollectionToItem } = require('../../utils/collection'); const { buildFormUrlEncodedPayload } = require('../../utils/common'); @@ -165,27 +166,26 @@ const mergeFolderLevelScripts = (request, requestTreePath, scriptFlow) => { } }; -const parseFormData = (datas, collectionPath) => { +const createFormData = (datas, collectionPath) => { // make axios work in node using form data // reference: https://github.com/axios/axios/issues/1006#issuecomment-320165427 const form = new FormData(); - datas.forEach((item) => { - const value = item.value; - const name = item.name; - if (item.type === 'file') { - const filePaths = value || []; - filePaths.forEach((filePath) => { - let trimmedFilePath = filePath.trim(); - - if (!path.isAbsolute(trimmedFilePath)) { - trimmedFilePath = path.join(collectionPath, trimmedFilePath); - } - - form.append(name, fs.createReadStream(trimmedFilePath), path.basename(trimmedFilePath)); - }); - } else { - form.append(name, value); + forOwn(datas, (value, key) => { + if (typeof value == 'string') { + form.append(key, value); + return; } + + const filePaths = value || []; + filePaths?.forEach?.((filePath) => { + let trimmedFilePath = filePath.trim(); + + if (!path.isAbsolute(trimmedFilePath)) { + trimmedFilePath = path.join(collectionPath, trimmedFilePath); + } + + form.append(key, fs.createReadStream(trimmedFilePath), path.basename(trimmedFilePath)); + }); }); return form; }; @@ -219,6 +219,23 @@ const setAuthHeaders = (axiosRequest, request, collectionRoot) => { password: get(collectionAuth, 'digest.password') }; break; + case 'wsse': + const username = get(request, 'auth.wsse.username', ''); + const password = get(request, 'auth.wsse.password', ''); + + const ts = new Date().toISOString(); + const nonce = crypto.randomBytes(16).toString('base64'); + + // Create the password digest using SHA-256 + const hash = crypto.createHash('sha256'); + hash.update(nonce + ts + password); + const digest = hash.digest('base64'); + + // Construct the WSSE header + axiosRequest.headers[ + 'X-WSSE' + ] = `UsernameToken Username="${username}", PasswordDigest="${digest}", Created="${ts}", Nonce="${nonce}"`; + break; case 'apikey': const apiKeyAuth = get(collectionAuth, 'apikey'); if (apiKeyAuth.placement === 'header') { @@ -296,6 +313,23 @@ const setAuthHeaders = (axiosRequest, request, collectionRoot) => { break; } break; + case 'wsse': + const username = get(request, 'auth.wsse.username', ''); + const password = get(request, 'auth.wsse.password', ''); + + const ts = new Date().toISOString(); + const nonce = crypto.randomBytes(16).toString('base64'); + + // Create the password digest using SHA-256 + const hash = crypto.createHash('sha256'); + hash.update(nonce + ts + password); + const digest = hash.digest('base64'); + + // Construct the WSSE header + axiosRequest.headers[ + 'X-WSSE' + ] = `UsernameToken Username="${username}", PasswordDigest="${digest}", Created="${ts}", Nonce="${nonce}"`; + break; case 'apikey': const apiKeyAuth = get(request, 'auth.apikey'); if (apiKeyAuth.placement === 'header') { @@ -400,10 +434,11 @@ const prepareRequest = (item, collection) => { } if (request.body.mode === 'multipartForm') { + axiosRequest.headers['content-type'] = 'multipart/form-data'; + const params = {}; const enabledParams = filter(request.body.multipartForm, (p) => p.enabled); - const form = parseFormData(enabledParams, collectionPath); - extend(axiosRequest.headers, form.getHeaders()); - axiosRequest.data = form; + each(enabledParams, (p) => (params[p.name] = p.value)); + axiosRequest.data = params; } if (request.body.mode === 'graphql') { @@ -433,3 +468,4 @@ const prepareRequest = (item, collection) => { module.exports = prepareRequest; module.exports.setAuthHeaders = setAuthHeaders; +module.exports.createFormData = createFormData; diff --git a/packages/bruno-electron/src/utils/filesystem.js b/packages/bruno-electron/src/utils/filesystem.js index 752cb339c..0263939ae 100644 --- a/packages/bruno-electron/src/utils/filesystem.js +++ b/packages/bruno-electron/src/utils/filesystem.js @@ -3,6 +3,7 @@ const fs = require('fs-extra'); const fsPromises = require('fs/promises'); const { dialog } = require('electron'); const isValidPathname = require('is-valid-path'); +const os = require('os'); const exists = async (p) => { try { @@ -155,12 +156,34 @@ const searchForBruFiles = (dir) => { return searchForFiles(dir, '.bru'); }; -// const isW - const sanitizeDirectoryName = (name) => { return name.replace(/[<>:"/\\|?*\x00-\x1F]+/g, '-'); }; +const safeToRename = (oldPath, newPath) => { + try { + // If the new path doesn't exist, it's safe to rename + if (!fs.existsSync(newPath)) { + return true; + } + + const oldStat = fs.statSync(oldPath); + const newStat = fs.statSync(newPath); + + if (os.platform() === 'win32') { + // Windows-specific comparison: + // Check if both files have the same birth time, size (Since, Win FAT-32 doesn't use inodes) + + return oldStat.birthtimeMs === newStat.birthtimeMs && oldStat.size === newStat.size; + } + // Unix/Linux/MacOS: Check inode to see if they are the same file + return oldStat.ino === newStat.ino; + } catch (error) { + console.error(`Error checking file rename safety for ${oldPath} and ${newPath}:`, error); + return false; + } +}; + module.exports = { isValidPathname, exists, @@ -180,5 +203,6 @@ module.exports = { chooseFileToSave, searchForFiles, searchForBruFiles, - sanitizeDirectoryName + sanitizeDirectoryName, + safeToRename }; diff --git a/packages/bruno-js/src/bruno-request.js b/packages/bruno-js/src/bruno-request.js index cf5f59aca..32e40c19e 100644 --- a/packages/bruno-js/src/bruno-request.js +++ b/packages/bruno-js/src/bruno-request.js @@ -43,7 +43,6 @@ class BrunoRequest { getMethod() { return this.req.method; } - getAuthMode() { if (this.req?.oauth2) { return 'oauth2'; @@ -55,6 +54,8 @@ class BrunoRequest { return 'awsv4'; } else if (this.req?.digestConfig) { return 'digest'; + } else if (this.headers?.['X-WSSE'] || this.req?.auth?.username) { + return 'wsse'; } else { return 'none'; } @@ -172,6 +173,10 @@ class BrunoRequest { disableParsingResponseJson() { this.req.__brunoDisableParsingResponseJson = true; } + + getExecutionMode() { + return this.req.__bruno__executionMode; + } } module.exports = BrunoRequest; diff --git a/packages/bruno-js/src/sandbox/quickjs/shims/bruno-request.js b/packages/bruno-js/src/sandbox/quickjs/shims/bruno-request.js index 1edfaaadb..e3f364fe7 100644 --- a/packages/bruno-js/src/sandbox/quickjs/shims/bruno-request.js +++ b/packages/bruno-js/src/sandbox/quickjs/shims/bruno-request.js @@ -111,6 +111,12 @@ const addBrunoRequestShimToContext = (vm, req) => { vm.setProp(reqObject, 'disableParsingResponseJson', disableParsingResponseJson); disableParsingResponseJson.dispose(); + let getExecutionMode = vm.newFunction('getExecutionMode', function () { + return marshallToVm(req.getExecutionMode(), vm); + }); + vm.setProp(reqObject, 'getExecutionMode', getExecutionMode); + getExecutionMode.dispose(); + vm.setProp(vm.global, 'req', reqObject); reqObject.dispose(); }; diff --git a/packages/bruno-lang/v2/src/bruToJson.js b/packages/bruno-lang/v2/src/bruToJson.js index 84890c92f..c84d36d07 100644 --- a/packages/bruno-lang/v2/src/bruToJson.js +++ b/packages/bruno-lang/v2/src/bruToJson.js @@ -23,7 +23,7 @@ const { outdentString } = require('../../v1/src/utils'); */ const grammar = ohm.grammar(`Bru { BruFile = (meta | http | query | params | headers | auths | bodies | varsandassert | script | tests | docs)* - auths = authawsv4 | authbasic | authbearer | authdigest | authOAuth2 | authapikey + auths = authawsv4 | authbasic | authbearer | authdigest | authOAuth2 | authwsse | authapikey bodies = bodyjson | bodytext | bodyxml | bodysparql | bodygraphql | bodygraphqlvars | bodyforms | body bodyforms = bodyformurlencoded | bodymultipart params = paramspath | paramsquery @@ -88,6 +88,7 @@ const grammar = ohm.grammar(`Bru { authbearer = "auth:bearer" dictionary authdigest = "auth:digest" dictionary authOAuth2 = "auth:oauth2" dictionary + authwsse = "auth:wsse" dictionary authapikey = "auth:apikey" dictionary body = "body" st* "{" nl* textblock tagend @@ -484,6 +485,23 @@ const sem = grammar.createSemantics().addAttribute('ast', { } }; }, + authwsse(_1, dictionary) { + const auth = mapPairListToKeyValPairs(dictionary.ast, false); + + const userKey = _.find(auth, { name: 'username' }); + const secretKey = _.find(auth, { name: 'password' }); + const username = userKey ? userKey.value : ''; + const password = secretKey ? secretKey.value : ''; + + return { + auth: { + wsse: { + username, + password + } + } + }; + }, authapikey(_1, dictionary) { const auth = mapPairListToKeyValPairs(dictionary.ast, false); diff --git a/packages/bruno-lang/v2/src/collectionBruToJson.js b/packages/bruno-lang/v2/src/collectionBruToJson.js index 513c4102d..5180f0193 100644 --- a/packages/bruno-lang/v2/src/collectionBruToJson.js +++ b/packages/bruno-lang/v2/src/collectionBruToJson.js @@ -4,7 +4,7 @@ const { outdentString } = require('../../v1/src/utils'); const grammar = ohm.grammar(`Bru { BruFile = (meta | query | headers | auth | auths | vars | script | tests | docs)* - auths = authawsv4 | authbasic | authbearer | authdigest | authOAuth2 | authapikey + auths = authawsv4 | authbasic | authbearer | authdigest | authOAuth2 | authwsse | authapikey nl = "\\r"? "\\n" st = " " | "\\t" @@ -43,6 +43,7 @@ const grammar = ohm.grammar(`Bru { authbearer = "auth:bearer" dictionary authdigest = "auth:digest" dictionary authOAuth2 = "auth:oauth2" dictionary + authwsse = "auth:wsse" dictionary authapikey = "auth:apikey" dictionary script = scriptreq | scriptres @@ -294,6 +295,21 @@ const sem = grammar.createSemantics().addAttribute('ast', { } }; }, + authwsse(_1, dictionary) { + const auth = mapPairListToKeyValPairs(dictionary.ast, false); + const userKey = _.find(auth, { name: 'username' }); + const secretKey = _.find(auth, { name: 'password' }); + const username = userKey ? userKey.value : ''; + const password = secretKey ? secretKey.value : ''; + return { + auth: { + wsse: { + username, + password + } + } + } + }, authapikey(_1, dictionary) { const auth = mapPairListToKeyValPairs(dictionary.ast, false); diff --git a/packages/bruno-lang/v2/src/jsonToBru.js b/packages/bruno-lang/v2/src/jsonToBru.js index 30bec13ef..8d3a5fdee 100644 --- a/packages/bruno-lang/v2/src/jsonToBru.js +++ b/packages/bruno-lang/v2/src/jsonToBru.js @@ -136,6 +136,15 @@ ${indentString(`username: ${auth?.basic?.username || ''}`)} ${indentString(`password: ${auth?.basic?.password || ''}`)} } +`; + } + + if (auth && auth.wsse) { + bru += `auth:wsse { +${indentString(`username: ${auth?.wsse?.username || ''}`)} +${indentString(`password: ${auth?.wsse?.password || ''}`)} +} + `; } diff --git a/packages/bruno-lang/v2/src/jsonToCollectionBru.js b/packages/bruno-lang/v2/src/jsonToCollectionBru.js index 6462efb3c..8b162b7a6 100644 --- a/packages/bruno-lang/v2/src/jsonToCollectionBru.js +++ b/packages/bruno-lang/v2/src/jsonToCollectionBru.js @@ -94,6 +94,15 @@ ${indentString(`username: ${auth.basic.username}`)} ${indentString(`password: ${auth.basic.password}`)} } +`; + } + + if (auth && auth.wsse) { + bru += `auth:wsse { +${indentString(`username: ${auth.wsse.username}`)} +${indentString(`password: ${auth.wsse.password}`)} +} + `; } diff --git a/packages/bruno-lang/v2/tests/fixtures/collection.bru b/packages/bruno-lang/v2/tests/fixtures/collection.bru index 44a66c8dc..f11954ebf 100644 --- a/packages/bruno-lang/v2/tests/fixtures/collection.bru +++ b/packages/bruno-lang/v2/tests/fixtures/collection.bru @@ -17,6 +17,11 @@ auth:basic { password: secret } +auth:wsse { + username: john + password: secret +} + auth:bearer { token: 123 } diff --git a/packages/bruno-lang/v2/tests/fixtures/collection.json b/packages/bruno-lang/v2/tests/fixtures/collection.json index 7bda2534d..102ee295c 100644 --- a/packages/bruno-lang/v2/tests/fixtures/collection.json +++ b/packages/bruno-lang/v2/tests/fixtures/collection.json @@ -31,6 +31,10 @@ "digest": { "username": "john", "password": "secret" + }, + "wsse": { + "username": "john", + "password": "secret" } }, "vars": { diff --git a/packages/bruno-lang/v2/tests/fixtures/request.bru b/packages/bruno-lang/v2/tests/fixtures/request.bru index c4ff61558..1a3efeab7 100644 --- a/packages/bruno-lang/v2/tests/fixtures/request.bru +++ b/packages/bruno-lang/v2/tests/fixtures/request.bru @@ -40,6 +40,11 @@ auth:basic { password: secret } +auth:wsse { + username: john + password: secret +} + auth:bearer { token: 123 } diff --git a/packages/bruno-lang/v2/tests/fixtures/request.json b/packages/bruno-lang/v2/tests/fixtures/request.json index d0bd996f6..24997a90c 100644 --- a/packages/bruno-lang/v2/tests/fixtures/request.json +++ b/packages/bruno-lang/v2/tests/fixtures/request.json @@ -83,6 +83,10 @@ "scope": "read write", "state": "807061d5f0be", "pkce": false + }, + "wsse": { + "username": "john", + "password": "secret" } }, "body": { diff --git a/packages/bruno-schema/src/collections/index.js b/packages/bruno-schema/src/collections/index.js index 2934a60d8..11561c528 100644 --- a/packages/bruno-schema/src/collections/index.js +++ b/packages/bruno-schema/src/collections/index.js @@ -106,6 +106,13 @@ const authBasicSchema = Yup.object({ .noUnknown(true) .strict(); +const authWsseSchema = Yup.object({ + username: Yup.string().nullable(), + password: Yup.string().nullable() +}) + .noUnknown(true) + .strict(); + const authBearerSchema = Yup.object({ token: Yup.string().nullable() }) @@ -119,6 +126,14 @@ const authDigestSchema = Yup.object({ .noUnknown(true) .strict(); +const authApiKeySchema = Yup.object({ + key: Yup.string().nullable(), + value: Yup.string().nullable(), + placement: Yup.string().oneOf(['header', 'queryparams']).nullable() +}) + .noUnknown(true) + .strict(); + const oauth2Schema = Yup.object({ grantType: Yup.string() .oneOf(['client_credentials', 'password', 'authorization_code']) @@ -177,21 +192,16 @@ const oauth2Schema = Yup.object({ .noUnknown(true) .strict(); -const authApiKeySchema = Yup.object({ - key: Yup.string().nullable(), - value: Yup.string().nullable(), - placement: Yup.string().oneOf(['header', 'queryparams']).nullable() -}); - const authSchema = Yup.object({ mode: Yup.string() - .oneOf(['inherit', 'none', 'awsv4', 'basic', 'bearer', 'digest', 'oauth2', 'apikey']) + .oneOf(['inherit', 'none', 'awsv4', 'basic', 'bearer', 'digest', 'oauth2', 'wsse', 'apikey']) .required('mode is required'), awsv4: authAwsV4Schema.nullable(), basic: authBasicSchema.nullable(), bearer: authBearerSchema.nullable(), digest: authDigestSchema.nullable(), oauth2: oauth2Schema.nullable(), + wsse: authWsseSchema.nullable(), apikey: authApiKeySchema.nullable() }) .noUnknown(true) diff --git a/packages/bruno-tests/collection/bruno.json b/packages/bruno-tests/collection/bruno.json index b6d437bbb..ada36145a 100644 --- a/packages/bruno-tests/collection/bruno.json +++ b/packages/bruno-tests/collection/bruno.json @@ -15,7 +15,7 @@ "bypassProxy": "" }, "scripts": { - "moduleWhitelist": ["crypto", "buffer"], + "moduleWhitelist": ["crypto", "buffer", "form-data"], "filesystemAccess": { "allow": true } diff --git a/packages/bruno-tests/collection/bruno.png b/packages/bruno-tests/collection/bruno.png new file mode 100644 index 000000000..c2a7f878f Binary files /dev/null and b/packages/bruno-tests/collection/bruno.png differ diff --git a/packages/bruno-tests/collection/echo/echo form-url-encoded.bru b/packages/bruno-tests/collection/echo/echo form-url-encoded.bru new file mode 100644 index 000000000..a0d2f0afb --- /dev/null +++ b/packages/bruno-tests/collection/echo/echo form-url-encoded.bru @@ -0,0 +1,23 @@ +meta { + name: echo form-url-encoded + type: http + seq: 9 +} + +post { + url: {{echo-host}} + body: formUrlEncoded + auth: none +} + +body:form-urlencoded { + form-data-key: {{form-data-key}} +} + +script:pre-request { + bru.setVar('form-data-key', 'form-data-value'); +} + +assert { + res.body: eq form-data-key=form-data-value +} diff --git a/packages/bruno-tests/collection/echo/echo multipart scripting.bru b/packages/bruno-tests/collection/echo/echo multipart scripting.bru new file mode 100644 index 000000000..13c1f2051 --- /dev/null +++ b/packages/bruno-tests/collection/echo/echo multipart scripting.bru @@ -0,0 +1,22 @@ +meta { + name: echo multipart via scripting + type: http + seq: 10 +} + +post { + url: {{echo-host}} + body: multipartForm + auth: none +} + +assert { + res.body: contains form-data-value +} + +script:pre-request { + const FormData = require("form-data"); + const form = new FormData(); + form.append('form-data-key', 'form-data-value'); + req.setBody(form); +} diff --git a/packages/bruno-tests/collection/echo/echo multipart.bru b/packages/bruno-tests/collection/echo/echo multipart.bru new file mode 100644 index 000000000..b8fd8abf7 --- /dev/null +++ b/packages/bruno-tests/collection/echo/echo multipart.bru @@ -0,0 +1,24 @@ +meta { + name: echo multipart + type: http + seq: 8 +} + +post { + url: {{echo-host}} + body: multipartForm + auth: none +} + +body:multipart-form { + foo: {{form-data-key}} + file: @file(bruno.png) +} + +assert { + res.body: contains form-data-value +} + +script:pre-request { + bru.setVar('form-data-key', 'form-data-value'); +} diff --git a/packages/bruno-tests/collection/environments/Prod.bru b/packages/bruno-tests/collection/environments/Prod.bru index 4bea1e77a..ce8fa60cc 100644 --- a/packages/bruno-tests/collection/environments/Prod.bru +++ b/packages/bruno-tests/collection/environments/Prod.bru @@ -7,4 +7,5 @@ vars { bark: {{process.env.PROC_ENV_VAR}} foo: bar testSetEnvVar: bruno-29653 + echo-host: https://echo.usebruno.com } diff --git a/packages/bruno-tests/src/auth/index.js b/packages/bruno-tests/src/auth/index.js index 6d6ebfb55..e26a65529 100644 --- a/packages/bruno-tests/src/auth/index.js +++ b/packages/bruno-tests/src/auth/index.js @@ -3,6 +3,7 @@ const router = express.Router(); const authBearer = require('./bearer'); const authBasic = require('./basic'); +const authWsse = require('./wsse'); const authCookie = require('./cookie'); const authOAuth2PasswordCredentials = require('./oauth2/passwordCredentials'); const authOAuth2AuthorizationCode = require('./oauth2/authorizationCode'); @@ -13,6 +14,7 @@ router.use('/oauth2/authorization_code', authOAuth2AuthorizationCode); router.use('/oauth2/client_credentials', authOAuth2ClientCredentials); router.use('/bearer', authBearer); router.use('/basic', authBasic); +router.use('/wsse', authWsse); router.use('/cookie', authCookie); module.exports = router; diff --git a/packages/bruno-tests/src/auth/wsse.js b/packages/bruno-tests/src/auth/wsse.js new file mode 100644 index 000000000..1af574a3d --- /dev/null +++ b/packages/bruno-tests/src/auth/wsse.js @@ -0,0 +1,70 @@ +'use strict'; + +const express = require('express'); +const router = express.Router(); +const crypto = require('crypto'); + +function sha256(data) { + return crypto.createHash('sha256').update(data).digest('base64'); +} + +function validateWSSE(req, res, next) { + const wsseHeader = req.headers['x-wsse']; + if (!wsseHeader) { + return unauthorized(res, 'WSSE header is missing'); + } + + const regex = /UsernameToken Username="(.+?)", PasswordDigest="(.+?)", (?:Nonce|nonce)="(.+?)", Created="(.+?)"/; + const matches = wsseHeader.match(regex); + + if (!matches) { + return unauthorized(res, 'Invalid WSSE header format'); + } + + const [_, username, passwordDigest, nonce, created] = matches; + const expectedPassword = 'bruno'; // Ideally store in a config or env variable + const expectedDigest = sha256(nonce + created + expectedPassword); + + if (passwordDigest !== expectedDigest) { + return unauthorized(res, 'Invalid credentials'); + } + + next(); +} + +// Helper to respond with an unauthorized SOAP fault +function unauthorized(res, message) { + const faultResponse = ` + + + + + soapenv:Client + ${message} + + + + `; + res.status(401).set('Content-Type', 'text/xml'); + res.send(faultResponse); +} + +const responses = { + success: ` + + + + + Success + + + + ` +}; + +router.post('/protected', validateWSSE, (req, res) => { + res.set('Content-Type', 'text/xml'); + res.send(responses.success); +}); + +module.exports = router;