christianlempa-boilerplates/ansible/installation/inst-vm-core.yaml

---
- name: install core packages for virtual machines
  hosts: "{{ my_hosts | d([]) }}"
  become: yes
  tasks:
  - name: install packages
    ansible.builtin.apt:
      name:
        - prometheus-node-exporter
        - nfs-common
        - qemu-guest-agent
      update_cache: yes
  - name: start guest qemu-guest-agent
    ansible.builtin.service:
      name: qemu-guest-agent
      state: started
      enabled: yes
ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00			`---`
			`- name: install core packages for virtual machines`
fix: ensure the `hosts` definition is always defined Ensure that the `hosts` definition is always defined, defaulting to an empty set. Due to the lack of an Ansible inventory file this is most likely meant to be set as an Ansible extra variable [1]. We also rename the variable named `hosts` to `my_hosts` because `hosts` is a reserved name in Ansible. Reserved names in Ansible are for example all class variable names of plays, roles, blocks, and tasks [2], and `hosts` for example is used by plays [3]. [1] https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#defining-variables-at-runtime [2] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/vars/reserved.py#L39 [3] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/playbook/play.py#L58 2024-02-23 12:19:48 +01:00			`hosts: "{{ my_hosts \| d([]) }}"`
ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00			`become: yes`
			`tasks:`
			`- name: install packages`
chore: consistently use Ansible FQCN in module calls In order to adhere to Ansible best practices, always use Fully Qualified Collection Names (FQCN) [1] when calling modules. Other than that, this commit doesn't apply any further changes except where needed as a module name has been updated. The module `ansible.builtin.systemd` has been renamed to `ansible.builtin.systemd_service` with `ansible.builtin.systemd` just being an alias [2] for reasons of backward compatibility. [1] https://docs.ansible.com/ansible/latest/tips_tricks/ansible_tips_tricks.html#use-fully-qualified-collection-names [2] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_service_module.html#synopsis 2024-02-24 11:56:25 +01:00			`ansible.builtin.apt:`
ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00			`name:`
			`- prometheus-node-exporter`
			`- nfs-common`
			`- qemu-guest-agent`
			`update_cache: yes`
			`- name: start guest qemu-guest-agent`
chore: consistently use Ansible FQCN in module calls In order to adhere to Ansible best practices, always use Fully Qualified Collection Names (FQCN) [1] when calling modules. Other than that, this commit doesn't apply any further changes except where needed as a module name has been updated. The module `ansible.builtin.systemd` has been renamed to `ansible.builtin.systemd_service` with `ansible.builtin.systemd` just being an alias [2] for reasons of backward compatibility. [1] https://docs.ansible.com/ansible/latest/tips_tricks/ansible_tips_tricks.html#use-fully-qualified-collection-names [2] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_service_module.html#synopsis 2024-02-24 11:56:25 +01:00			`ansible.builtin.service:`
ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00			`name: qemu-guest-agent`
			`state: started`
			`enabled: yes`