Commit Graph

10 Commits

Author SHA1 Message Date
Christoph Schug
38e065c218 fix: replace /var/run by /run
The use of `/var/run` was deprecated by FHS 3.0 nine years ago, so it's
time to finally get rid of it where possible. The canonical directory
for run-time variable data is `/run` nowadaya,s with `/var/run` just
being a symbolic link for backward compatibilty and to ease transition.
2024-06-04 11:55:20 +02:00
Christoph Schug
7983a7c85f fix: fix use of become/become_user
If `become_user` is being defined on a task level, also `become` should
be set on that very task. As there aren't any other tasks, the `become`
on the top-level becomes obsolete.
2024-03-03 17:54:55 +01:00
Christoph Schug
539b98d14b fix: fix Jinja2 spacing issues 2024-03-03 17:01:00 +01:00
Christoph Schug
bde2063ec9 fix: fix names which did not start with an uppercase letter 2024-03-03 16:54:47 +01:00
Christoph Schug
70a8bea0ed fix: add and remove blank lines
Add blank lines where it helps with readability (e.g., between each
task) but also remove needless one.
2024-03-03 16:34:29 +01:00
Christoph Schug
6e52db9cf6 fix: consistently use true/false as truthy values 2024-03-03 16:26:12 +01:00
Christoph Schug
706ac210f7 fix: fix YAML indentation issues 2024-03-03 16:10:27 +01:00
Christoph Schug
746aa1d06a fix: ensure the hosts definition is always defined
Ensure that the `hosts` definition is always defined, defaulting to an
empty set. Due to the lack of an Ansible inventory file this is most
likely meant to be set as an Ansible extra variable [1].

We also rename the variable named `hosts` to `my_hosts` because `hosts`
is a reserved name in Ansible. Reserved names in Ansible are for example
all class variable names of plays, roles, blocks, and tasks [2], and
`hosts` for example is used by plays [3].

[1] https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#defining-variables-at-runtime
[2] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/vars/reserved.py#L39
[3] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/playbook/play.py#L58
2024-03-03 15:36:11 +01:00
Christoph Schug
8a17193dd0 fix: add final newline character to text files
This makes text files compliant to POSIX which requires every line of a
text file to end with a newline character [1][2].

[1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_403
[2] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
2024-02-22 19:06:54 +01:00
Christian Lempa
c25d9a2fcd ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00