Commit Graph

21 Commits

Author SHA1 Message Date
Christoph Schug
0621aca3af fix: become methods should be fully-qualified 2024-03-03 17:03:06 +01:00
Christoph Schug
539b98d14b fix: fix Jinja2 spacing issues 2024-03-03 17:01:00 +01:00
Christoph Schug
bde2063ec9 fix: fix names which did not start with an uppercase letter 2024-03-03 16:54:47 +01:00
Christoph Schug
70a8bea0ed fix: add and remove blank lines
Add blank lines where it helps with readability (e.g., between each
task) but also remove needless one.
2024-03-03 16:34:29 +01:00
Christoph Schug
6e52db9cf6 fix: consistently use true/false as truthy values 2024-03-03 16:26:12 +01:00
Christoph Schug
706ac210f7 fix: fix YAML indentation issues 2024-03-03 16:10:27 +01:00
Christoph Schug
6943bf8fef fix: remove trailing whitespace 2024-03-03 15:59:49 +01:00
Christoph Schug
ba3bb6be85 fix: fix YAML document markers 2024-03-03 15:58:23 +01:00
Christoph Schug
746aa1d06a fix: ensure the hosts definition is always defined
Ensure that the `hosts` definition is always defined, defaulting to an
empty set. Due to the lack of an Ansible inventory file this is most
likely meant to be set as an Ansible extra variable [1].

We also rename the variable named `hosts` to `my_hosts` because `hosts`
is a reserved name in Ansible. Reserved names in Ansible are for example
all class variable names of plays, roles, blocks, and tasks [2], and
`hosts` for example is used by plays [3].

[1] https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#defining-variables-at-runtime
[2] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/vars/reserved.py#L39
[3] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/playbook/play.py#L58
2024-03-03 15:36:11 +01:00
Christoph Schug
49d4256a58 chore: consistently use Ansible FQCN in module calls
In order to adhere to Ansible best practices, always use Fully Qualified
Collection Names (FQCN) [1] when calling modules.

Other than that, this commit doesn't apply any further changes
except where needed as a module name has been updated.
The module `ansible.builtin.systemd` has been renamed to
`ansible.builtin.systemd_service` with `ansible.builtin.systemd` just
being an alias [2] for reasons of backward compatibility.

[1] https://docs.ansible.com/ansible/latest/tips_tricks/ansible_tips_tricks.html#use-fully-qualified-collection-names
[2] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_service_module.html#synopsis
2024-02-24 11:56:25 +01:00
Christian Lempa
32ffb5db59
Merge pull request #143 from cschug/fix_final_newline
fix: add final newline character to text files
2024-02-23 11:19:25 +01:00
Christoph Schug
3f4672e97c fix: fix file names
- Ansible playbooks should have an `.yaml` file extension

- all files related to installation should be consistently prefixed
  wth `inst-`
2024-02-22 23:45:19 +01:00
Christoph Schug
8a17193dd0 fix: add final newline character to text files
This makes text files compliant to POSIX which requires every line of a
text file to end with a newline character [1][2].

[1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_403
[2] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
2024-02-22 19:06:54 +01:00
Christian Lempa
cdbd9d60a1
Merge pull request #92 from gabegon8910/main
2 new ansible scripts
2023-09-12 11:09:09 +02:00
Christian Lempa
5d5dcdf2ac link update 2023-09-12 11:08:06 +02:00
Christian Lempa
6ab41e340b readme updates 2023-09-12 11:06:06 +02:00
NethunRanasinghe
c42461184a Install K8s 2023-09-06 15:17:48 +05:30
Gabe
3d93d27b28 Added a ansible scripts to install qemu-agent and a script to update linux based on package manager apt or yum 2023-07-13 09:45:28 -04:00
Christian Lempa
128adf9ce3 removed old docker installation, added new one for ubuntu 2023-06-24 18:50:41 +02:00
Ahmed Elzagh
a5378bc268 Refactor user permissions task to use Ansible user module 2023-06-15 22:08:16 +03:00
Christian Lempa
c25d9a2fcd ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00