Commit Graph

46 Commits

Author SHA1 Message Date
Christoph Schug
aa786b1b1d fix: tell Ansible about the idempotency of this task
This shell command doesn't change state on the system, therefore
it is safe to set `changed_when` to `false`, and we can also
set `check_mode` to `false` here to allow execution when run in
check mode.
2024-03-03 17:57:02 +01:00
Christoph Schug
7983a7c85f fix: fix use of become/become_user
If `become_user` is being defined on a task level, also `become` should
be set on that very task. As there aren't any other tasks, the `become`
on the top-level becomes obsolete.
2024-03-03 17:54:55 +01:00
Christoph Schug
7ceb755f35 fix: set pipefail flag in shell commands using pipes
Without `pipefail` Ansible cannot detect if there is an error executing
the command before the pipe as the return code of the shell only
reflects the return code of the last command. As not all shells support
`pipefail` (e.g., `ash`, `dash`) we also enfore the use of `bash` in
this case.
2024-03-03 17:49:31 +01:00
Christoph Schug
11ece4a070 fix: remove bogus task which does nothing
The command doesn't change anything on the system, and the registered
variable `disk_usage` is never being used, moreover it gets overwritten
by the next task.
2024-03-03 17:38:41 +01:00
Christoph Schug
abe4bbcc85 fix: add exception to ignore Ansible Lint rule package-latest 2024-03-03 17:36:01 +01:00
Christoph Schug
d06aab167e fix: replace shell commands by Ansible modules 2024-03-03 17:35:14 +01:00
Christoph Schug
b46f18d437 fix: fix insecure file permission and ownership 2024-03-03 17:17:19 +01:00
Christoph Schug
0621aca3af fix: become methods should be fully-qualified 2024-03-03 17:03:06 +01:00
Christoph Schug
539b98d14b fix: fix Jinja2 spacing issues 2024-03-03 17:01:00 +01:00
Christoph Schug
bde2063ec9 fix: fix names which did not start with an uppercase letter 2024-03-03 16:54:47 +01:00
Christoph Schug
24b0819e7f fix: add missing names
Any play or task should have a name.
2024-03-03 16:43:55 +01:00
Christoph Schug
70a8bea0ed fix: add and remove blank lines
Add blank lines where it helps with readability (e.g., between each
task) but also remove needless one.
2024-03-03 16:34:29 +01:00
Christoph Schug
6e52db9cf6 fix: consistently use true/false as truthy values 2024-03-03 16:26:12 +01:00
Christoph Schug
706ac210f7 fix: fix YAML indentation issues 2024-03-03 16:10:27 +01:00
Christoph Schug
6943bf8fef fix: remove trailing whitespace 2024-03-03 15:59:49 +01:00
Christoph Schug
ba3bb6be85 fix: fix YAML document markers 2024-03-03 15:58:23 +01:00
Christoph Schug
746aa1d06a fix: ensure the hosts definition is always defined
Ensure that the `hosts` definition is always defined, defaulting to an
empty set. Due to the lack of an Ansible inventory file this is most
likely meant to be set as an Ansible extra variable [1].

We also rename the variable named `hosts` to `my_hosts` because `hosts`
is a reserved name in Ansible. Reserved names in Ansible are for example
all class variable names of plays, roles, blocks, and tasks [2], and
`hosts` for example is used by plays [3].

[1] https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#defining-variables-at-runtime
[2] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/vars/reserved.py#L39
[3] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/playbook/play.py#L58
2024-03-03 15:36:11 +01:00
Christoph Schug
d0fed19232
Merge branch 'main' into feat_improve_discord_notification 2024-02-27 13:52:32 +01:00
Christoph Schug
17601ec532 feat: use the community.general.discord Ansible module
This should provide a more robust solution for sending notifications to
Discord rather than using plain `ansible.builtin.uri` for that task.

Additionally add some comments which should hopefully give better
guidance what to do.

Fixes #82.
2024-02-25 19:25:03 +01:00
Christoph Schug
49d4256a58 chore: consistently use Ansible FQCN in module calls
In order to adhere to Ansible best practices, always use Fully Qualified
Collection Names (FQCN) [1] when calling modules.

Other than that, this commit doesn't apply any further changes
except where needed as a module name has been updated.
The module `ansible.builtin.systemd` has been renamed to
`ansible.builtin.systemd_service` with `ansible.builtin.systemd` just
being an alias [2] for reasons of backward compatibility.

[1] https://docs.ansible.com/ansible/latest/tips_tricks/ansible_tips_tricks.html#use-fully-qualified-collection-names
[2] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_service_module.html#synopsis
2024-02-24 11:56:25 +01:00
Christian Lempa
d24dfac89f
Merge branch 'main' into fix_issue_137 2024-02-23 11:26:23 +01:00
Christian Lempa
78b4a3a6dd rename file 2024-02-23 11:25:26 +01:00
Christian Lempa
32ffb5db59
Merge pull request #143 from cschug/fix_final_newline
fix: add final newline character to text files
2024-02-23 11:19:25 +01:00
Christoph Schug
65b172436f fix: enforce output of df to be single-lined per file system
This change forces `df(1)` to output each file system on a single
line by setting the `-P` flag (POSIX output format). Without it,
some versions of `df(1)` split the output into multiple lines if the
length of some fields like "Filesystem" exceeds a certain limit. As a
consequence, the `awk(1)` expression might fail to catch the correct
fields.

Please note that this fixes a file which is also wrongly named, which is
being addressed in PR #151.

Relates to PR #151.
Fixes issue #137.
2024-02-23 00:20:34 +01:00
Christoph Schug
3f4672e97c fix: fix file names
- Ansible playbooks should have an `.yaml` file extension

- all files related to installation should be consistently prefixed
  wth `inst-`
2024-02-22 23:45:19 +01:00
Christoph Schug
8a17193dd0 fix: add final newline character to text files
This makes text files compliant to POSIX which requires every line of a
text file to end with a newline character [1][2].

[1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_403
[2] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
2024-02-22 19:06:54 +01:00
Christian Lempa
cdbd9d60a1
Merge pull request #92 from gabegon8910/main
2 new ansible scripts
2023-09-12 11:09:09 +02:00
Christian Lempa
5d5dcdf2ac link update 2023-09-12 11:08:06 +02:00
Christian Lempa
6ab41e340b readme updates 2023-09-12 11:06:06 +02:00
NethunRanasinghe
c42461184a Install K8s 2023-09-06 15:17:48 +05:30
Gabe
3d93d27b28 Added a ansible scripts to install qemu-agent and a script to update linux based on package manager apt or yum 2023-07-13 09:45:28 -04:00
Christian Lempa
128adf9ce3 removed old docker installation, added new one for ubuntu 2023-06-24 18:50:41 +02:00
Ahmed Elzagh
a5378bc268 Refactor user permissions task to use Ansible user module 2023-06-15 22:08:16 +03:00
Christian Lempa
c25d9a2fcd ansiblesemaphore-udpate 2023-05-25 13:48:38 +02:00
Christian Lempa
c09a4fce47 delete readmes 2022-11-17 09:40:38 +01:00
Christian Lempa
9d44fabd64 docker fixes and nextcloud update 2022-11-16 17:09:17 +01:00
Christian Lempa
626cf6d47f ansible new structure 2022-09-04 09:35:11 +02:00
sh3b0
cf0ba18092 Update install-docker.yaml 2022-06-16 03:47:52 +03:00
sh3b0
1e9999fe5c Update install-docker.yaml 2022-06-16 03:40:46 +03:00
Ahmed Nouralla
6bbd357570
Update install-docker.yaml
Use ansible_env fact instead of lookup plugin as it queries controller instead of remote
2022-06-16 03:03:36 +03:00
Christian
356872bbc5 portainer and traefik ansible playbooks 2022-03-11 16:53:17 +01:00
Christian
cb98a83a49
Merge pull request #25 from agrestic1/patch-2
Rename sshd-default.conf to debian-sshd-default.conf
2022-01-21 09:31:33 +01:00
agrestic1
e86f43085c
Rename sshd-default.conf to debian-sshd-default.conf
as referred in protect-sshd.yaml
2022-01-20 14:03:27 +01:00
agrestic1
847f5c0c0e
container_name -> name
container_name is not supportet by ansible module community.docker.docker_volume anymore. Changed to name
2022-01-20 10:13:13 +01:00
xcad2k
af765e7b93 monitoring 2021-09-17 14:12:39 +02:00
xcad2k
0ea81cf7c2 initial deployment 2021-06-11 15:01:45 +02:00