Christoph Schug
|
d06aab167e
|
fix: replace shell commands by Ansible modules
|
2024-03-03 17:35:14 +01:00 |
|
Christoph Schug
|
539b98d14b
|
fix: fix Jinja2 spacing issues
|
2024-03-03 17:01:00 +01:00 |
|
Christoph Schug
|
bde2063ec9
|
fix: fix names which did not start with an uppercase letter
|
2024-03-03 16:54:47 +01:00 |
|
Christoph Schug
|
70a8bea0ed
|
fix: add and remove blank lines
Add blank lines where it helps with readability (e.g., between each
task) but also remove needless one.
|
2024-03-03 16:34:29 +01:00 |
|
Christoph Schug
|
6e52db9cf6
|
fix: consistently use true/false as truthy values
|
2024-03-03 16:26:12 +01:00 |
|
Christoph Schug
|
746aa1d06a
|
fix: ensure the hosts definition is always defined
Ensure that the `hosts` definition is always defined, defaulting to an
empty set. Due to the lack of an Ansible inventory file this is most
likely meant to be set as an Ansible extra variable [1].
We also rename the variable named `hosts` to `my_hosts` because `hosts`
is a reserved name in Ansible. Reserved names in Ansible are for example
all class variable names of plays, roles, blocks, and tasks [2], and
`hosts` for example is used by plays [3].
[1] https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#defining-variables-at-runtime
[2] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/vars/reserved.py#L39
[3] https://github.com/ansible/ansible/blob/v2.16.4/lib/ansible/playbook/play.py#L58
|
2024-03-03 15:36:11 +01:00 |
|
Christoph Schug
|
49d4256a58
|
chore: consistently use Ansible FQCN in module calls
In order to adhere to Ansible best practices, always use Fully Qualified
Collection Names (FQCN) [1] when calling modules.
Other than that, this commit doesn't apply any further changes
except where needed as a module name has been updated.
The module `ansible.builtin.systemd` has been renamed to
`ansible.builtin.systemd_service` with `ansible.builtin.systemd` just
being an alias [2] for reasons of backward compatibility.
[1] https://docs.ansible.com/ansible/latest/tips_tricks/ansible_tips_tricks.html#use-fully-qualified-collection-names
[2] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_service_module.html#synopsis
|
2024-02-24 11:56:25 +01:00 |
|
Christian Lempa
|
c25d9a2fcd
|
ansiblesemaphore-udpate
|
2023-05-25 13:48:38 +02:00 |
|