From 79dbe5406750eb8395613a37d0e1932fd071e861 Mon Sep 17 00:00:00 2001
From: lucatortiglione <52408341+lucatortiglione@users.noreply.github.com>
Date: Wed, 23 Apr 2025 16:38:34 +0200
Subject: [PATCH] Fixes and adds of Cisco devices (#3035)

* Update A9K-MPA-20X1GE.yaml

* Update A9K-MPA-20X1GE.yaml

Fix ports from 0 - 20 to 0-19

* Update ASR-9006.yaml

Added some informations weight and airflow

* Fixes and adds
---
 device-types/Cisco/ASR-9006.yaml       |  3 ++
 device-types/Cisco/NCS-5504.yaml       | 32 ++++++++++++
 device-types/Cisco/NCS-5508.yaml       |  3 +-
 device-types/Cisco/NCS-5516.yaml       | 68 ++++++++++++++++++++++++++
 module-types/Cisco/A9K-MPA-20X1GE.yaml |  2 -
 5 files changed, 105 insertions(+), 3 deletions(-)
 create mode 100644 device-types/Cisco/NCS-5504.yaml
 create mode 100644 device-types/Cisco/NCS-5516.yaml

diff --git a/device-types/Cisco/ASR-9006.yaml b/device-types/Cisco/ASR-9006.yaml
index d168a244b..53c084e18 100644
--- a/device-types/Cisco/ASR-9006.yaml
+++ b/device-types/Cisco/ASR-9006.yaml
@@ -3,6 +3,9 @@ manufacturer: Cisco
 model: ASR-9006
 slug: cisco-asr-9006
 part_number: ASR-9006
+weight: 59.65
+weight_unit: kg
+airflow: front-to-rear
 u_height: 10
 is_full_depth: true
 comments: '[Cisco ASR 9000 Series Aggregation Services Routers Data Sheet](https://www.cisco.com/c/en/us/products/collateral/routers/asr-9000-series-aggregation-services-routers/data_sheet_c78-501767.html)'
diff --git a/device-types/Cisco/NCS-5504.yaml b/device-types/Cisco/NCS-5504.yaml
new file mode 100644
index 000000000..adc7ca25b
--- /dev/null
+++ b/device-types/Cisco/NCS-5504.yaml
@@ -0,0 +1,32 @@
+---
+manufacturer: Cisco
+model: NCS-5504
+slug: cisco-ncs-5504
+part_number: NCS-5504
+u_height: 7
+is_full_depth: true
+airflow: front-to-rear
+weight: 38.2
+weight_unit: kg
+comments: '[Hardware Installation Guide for Cisco NCS 5500 Series Modular Routers](https://www.cisco.com/c/en/us/td/docs/iosxr/ncs5500/hardware-install/b-ncs5500-hardware-installation-guide.html)'
+module-bays:
+  - name: RP0
+    position: '0'
+  - name: RP1
+    position: '1'
+  - name: LC0
+    position: '0'
+  - name: LC1
+    position: '1'
+  - name: LC2
+    position: '2'
+  - name: LC3
+    position: '3'
+  - name: PM0
+    position: '0'
+  - name: PM1
+    position: '1'
+  - name: PM2
+    position: '2'
+  - name: PM3
+    position: '3'
diff --git a/device-types/Cisco/NCS-5508.yaml b/device-types/Cisco/NCS-5508.yaml
index 94884eb91..e658dd8e8 100644
--- a/device-types/Cisco/NCS-5508.yaml
+++ b/device-types/Cisco/NCS-5508.yaml
@@ -6,8 +6,9 @@ part_number: NCS-5508
 u_height: 13
 is_full_depth: true
 airflow: front-to-rear
-weight: 68
+weight: 68.2
 weight_unit: kg
+comments: '[Hardware Installation Guide for Cisco NCS 5500 Series Modular Routers](https://www.cisco.com/c/en/us/td/docs/iosxr/ncs5500/hardware-install/b-ncs5500-hardware-installation-guide.html)'
 module-bays:
   - name: RP0
     position: '0'
diff --git a/device-types/Cisco/NCS-5516.yaml b/device-types/Cisco/NCS-5516.yaml
new file mode 100644
index 000000000..9b85dd90c
--- /dev/null
+++ b/device-types/Cisco/NCS-5516.yaml
@@ -0,0 +1,68 @@
+---
+manufacturer: Cisco
+model: NCS-5516
+slug: cisco-ncs-5516
+part_number: NCS-5516
+u_height: 21
+is_full_depth: true
+airflow: front-to-rear
+weight: 87.3
+weight_unit: kg
+comments: '[Hardware Installation Guide for Cisco NCS 5500 Series Modular Routers](https://www.cisco.com/c/en/us/td/docs/iosxr/ncs5500/hardware-install/b-ncs5500-hardware-installation-guide.html)'
+module-bays:
+  - name: RP0
+    position: '0'
+  - name: RP1
+    position: '1'
+  - name: LC0
+    position: '0'
+  - name: LC1
+    position: '1'
+  - name: LC2
+    position: '2'
+  - name: LC3
+    position: '3'
+  - name: LC4
+    position: '4'
+  - name: LC5
+    position: '5'
+  - name: LC6
+    position: '6'
+  - name: LC7
+    position: '7'
+  - name: LC8
+    position: '8'
+  - name: LC9
+    position: '9'
+  - name: LC10
+    position: '10'
+  - name: LC11
+    position: '11'
+  - name: LC12
+    position: '12'
+  - name: LC13
+    position: '13'
+  - name: LC14
+    position: '14'
+  - name: LC15
+    position: '15'
+  - name: PM0
+    position: '0'
+  - name: PM1
+    position: '1'
+  - name: PM2
+    position: '2'
+  - name: PM3
+    position: '3'
+  - name: PM4
+    position: '4'
+  - name: PM5
+    position: '5'
+  - name: PM6
+    position: '6'
+  - name: PM7
+    position: '7'
+  - name: PM8
+    position: '8'
+  - name: PM9
+    position: '9'
diff --git a/module-types/Cisco/A9K-MPA-20X1GE.yaml b/module-types/Cisco/A9K-MPA-20X1GE.yaml
index 5fc4a727c..78ff1d169 100644
--- a/module-types/Cisco/A9K-MPA-20X1GE.yaml
+++ b/module-types/Cisco/A9K-MPA-20X1GE.yaml
@@ -43,5 +43,3 @@ interfaces:
     type: 1000base-x-sfp
   - name: GigabitEthernet{module}/19
     type: 1000base-x-sfp
-  - name: GigabitEthernet{module}/20
-    type: 1000base-x-sfp