Extend Allied Telesis devices with bays and modules (#738)

* Added module bays to x930, x950 and x908Gen2

* Added XEM2 (SB908GEN2 platform) and x930 modules

* Fix numeric-only positions to be treated as string

* Renamed "Bay" to "Slot" to comply with ATI naming

device-types/Allied Telesis/x908Gen2.yaml

@@ -19,3 +19,20 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Slot 1
+    position: '1'
+  - name: Slot 2
+    position: '2'
+  - name: Slot 3
+    position: '3'
+  - name: Slot 4
+    position: '4'
+  - name: Slot 5
+    position: '5'
+  - name: Slot 6
+    position: '6'
+  - name: Slot 7
+    position: '7'
+  - name: Slot 8
+    position: '8'

device-types/Allied Telesis/x930-28GPX.yaml

@@ -103,3 +103,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Rear Slot
+    position: '1'

device-types/Allied Telesis/x930-28GSTX.yaml

@@ -104,3 +104,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Rear Slot
+    position: '1'

device-types/Allied Telesis/x930-28GTX.yaml

@@ -103,3 +103,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Rear Slot
+    position: '1'

device-types/Allied Telesis/x930-52GPX.yaml

@@ -175,3 +175,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Rear Slot
+    position: '1'

device-types/Allied Telesis/x930-52GTX.yaml

@@ -175,3 +175,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Rear Slot
+    position: '1'

device-types/Allied Telesis/x950-28XSQ.yaml

@@ -103,3 +103,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Slot 1
+    position: '1'

device-types/Allied Telesis/x950-28XTQm.yaml

@@ -103,3 +103,6 @@ interfaces:
   - name: eth0
     type: 1000base-t
     mgmt_only: true
+module-bays:
+  - name: Slot 1
+    position: '1'

module-types/Allied Telesis/StackQS.yaml

@@ -0,0 +1,9 @@
+---
+manufacturer: Allied Telesis
+model: StackQS
+part_number: AT-StackQS
+interfaces:
+  - name: port1.{module}.1
+    type: 40gbase-x-qsfpp
+  - name: port1.{module}.2
+    type: 40gbase-x-qsfpp

module-types/Allied Telesis/XEM2-12XSv2.yaml

@@ -0,0 +1,29 @@
+---
+manufacturer: Allied Telesis
+model: XEM2-12XSv2
+part_number: AT-XEM2-12XSv2
+interfaces:
+  - name: port1.{module}.1
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.2
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.3
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.4
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.5
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.6
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.7
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.8
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.9
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.10
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.11
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.12
+    type: 10gbase-x-sfpp

module-types/Allied Telesis/XEM2-12XT.yaml

@@ -0,0 +1,29 @@
+---
+manufacturer: Allied Telesis
+model: XEM2-12XT
+part_number: AT-XEM2-12XT
+interfaces:
+  - name: port1.{module}.1
+    type: 10gbase-t
+  - name: port1.{module}.2
+    type: 10gbase-t
+  - name: port1.{module}.3
+    type: 10gbase-t
+  - name: port1.{module}.4
+    type: 10gbase-t
+  - name: port1.{module}.5
+    type: 10gbase-t
+  - name: port1.{module}.6
+    type: 10gbase-t
+  - name: port1.{module}.7
+    type: 10gbase-t
+  - name: port1.{module}.8
+    type: 10gbase-t
+  - name: port1.{module}.9
+    type: 10gbase-t
+  - name: port1.{module}.10
+    type: 10gbase-t
+  - name: port1.{module}.11
+    type: 10gbase-t
+  - name: port1.{module}.12
+    type: 10gbase-t

module-types/Allied Telesis/XEM2-12XTm.yaml

@@ -0,0 +1,29 @@
+---
+manufacturer: Allied Telesis
+model: XEM2-12XTm
+part_number: AT-XEM2-12XTm
+interfaces:
+  - name: port1.{module}.1
+    type: 10gbase-t
+  - name: port1.{module}.2
+    type: 10gbase-t
+  - name: port1.{module}.3
+    type: 10gbase-t
+  - name: port1.{module}.4
+    type: 10gbase-t
+  - name: port1.{module}.5
+    type: 10gbase-t
+  - name: port1.{module}.6
+    type: 10gbase-t
+  - name: port1.{module}.7
+    type: 10gbase-t
+  - name: port1.{module}.8
+    type: 10gbase-t
+  - name: port1.{module}.9
+    type: 10gbase-t
+  - name: port1.{module}.10
+    type: 10gbase-t
+  - name: port1.{module}.11
+    type: 10gbase-t
+  - name: port1.{module}.12
+    type: 10gbase-t

module-types/Allied Telesis/XEM2-1CQ.yaml

@@ -0,0 +1,7 @@
+---
+manufacturer: Allied Telesis
+model: XEM2-1CQ
+part_number: AT-XEM2-1CQ
+interfaces:
+  - name: port1.{module}.1
+    type: 100gbase-x-qsfp28

module-types/Allied Telesis/XEM2-4QS.yaml

@@ -0,0 +1,13 @@
+---
+manufacturer: Allied Telesis
+model: XEM2-4QS
+part_number: AT-XEM2-4QS
+interfaces:
+  - name: port1.{module}.1
+    type: 40gbase-x-qsfpp
+  - name: port1.{module}.2
+    type: 40gbase-x-qsfpp
+  - name: port1.{module}.3
+    type: 40gbase-x-qsfpp
+  - name: port1.{module}.4
+    type: 40gbase-x-qsfpp

module-types/Allied Telesis/XEM2-8XSTm.yaml

@@ -0,0 +1,21 @@
+---
+manufacturer: Allied Telesis
+model: XEM2-8XSTm
+part_number: AT-XEM2-8XSTm
+interfaces:
+  - name: port1.{module}.1
+    type: 10gbase-t
+  - name: port1.{module}.2
+    type: 10gbase-t
+  - name: port1.{module}.3
+    type: 10gbase-t
+  - name: port1.{module}.4
+    type: 10gbase-t
+  - name: port1.{module}.5
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.6
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.7
+    type: 10gbase-x-sfpp
+  - name: port1.{module}.8
+    type: 10gbase-x-sfpp

module-types/Allied Telesis/x9EM-XT4.yaml

@@ -0,0 +1,13 @@
+---
+manufacturer: Allied Telesis
+model: x9EM/XT4
+part_number: AT-x9EM/XT4
+interfaces:
+  - name: port1.{module}.1
+    type: 10gbase-t
+  - name: port1.{module}.2
+    type: 10gbase-t
+  - name: port1.{module}.3
+    type: 10gbase-t
+  - name: port1.{module}.4
+    type: 10gbase-t