From 03599f462b4f4d2f0f0fc9186ee36e2d9a222c60 Mon Sep 17 00:00:00 2001 From: Garret Wassermann Date: Fri, 15 Dec 2017 20:28:39 -0500 Subject: [PATCH] Catch exception when someone enters a non-integer text into the public ticket view form, #576 --- helpdesk/views/public.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/helpdesk/views/public.py b/helpdesk/views/public.py index 23b3ff85..9227e83d 100644 --- a/helpdesk/views/public.py +++ b/helpdesk/views/public.py @@ -43,11 +43,15 @@ def homepage(request): return render(request, template_name='helpdesk/public_spam.html') else: ticket = form.save() - return HttpResponseRedirect('%s?ticket=%s&email=%s' % ( - reverse('helpdesk:public_view'), - ticket.ticket_for_url, - urlquote(ticket.submitter_email)) - ) + try: + return HttpResponseRedirect('%s?ticket=%s&email=%s' % ( + reverse('helpdesk:public_view'), + ticket.ticket_for_url, + urlquote(ticket.submitter_email)) + ) + except ValueError: + # if someone enters a non-int string for the ticket + return HttpResponseRedirect(reverse('helpdesk:home')) else: try: queue = Queue.objects.get(slug=request.GET.get('queue', None))