Merge pull request #1277 from bhargav1002/feat/ticket-hold-followup-change-tracking

Prevent Ticket.title being changed and instead add follow-up creation and change tracking on ticket hold status with the FollowUp.title reflecting the hold state.

helpdesk/views/staff.py

@@ -71,6 +71,7 @@ from helpdesk.models import (
     SavedSearch,
     Ticket,
     TicketCC,
+    TicketChange,
     TicketCustomFieldValue,
     TicketDependency,
     UserSettings,
@@ -89,6 +90,7 @@ import re
 from rest_framework import status
 from rest_framework.decorators import api_view
 import typing
+from django.utils.timezone import now
 
 
 if helpdesk_settings.HELPDESK_KB_ENABLED:
@@ -1384,21 +1386,28 @@ def hold_ticket(request, ticket_id, unhold=False):
 
     if unhold:
         ticket.on_hold = False
-        title = _("Ticket taken off hold")
+        followup_title = _("Ticket taken off hold")
     else:
         ticket.on_hold = True
-        title = _("Ticket placed on hold")
+        followup_title = _("Ticket placed on hold")
-
-    f = update_ticket(
-        user=request.user,
-        ticket=ticket,
-        title=title,
-        public=True,
-    )
-    f.save()
 
     ticket.save()
 
+    followup = FollowUp.objects.create(
+        ticket=ticket,
+        title=followup_title,
+        date=now(),
+        public=True,
+        user=request.user,
+    )
+
+    TicketChange.objects.create(
+        followup=followup,
+        field=_("On Hold"),
+        old_value=str(not ticket.on_hold),
+        new_value=str(ticket.on_hold),
+    )
+
     return HttpResponseRedirect(ticket.get_absolute_url())
 
 

setup.py

@@ -7,7 +7,7 @@ from setuptools import find_packages, setup
 import sys
 
 
-version = "1.5.1"
+version = "1.6.0"
 
 
 # Provided as an attribute, so you can append to these instead