From 54502ac3ea879885a01175e5f47e2ae913715404 Mon Sep 17 00:00:00 2001 From: Dane Kennedy Date: Wed, 28 May 2025 17:21:50 +0200 Subject: [PATCH 1/6] Make title length in form consistent with title length in model. --- helpdesk/forms.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/helpdesk/forms.py b/helpdesk/forms.py index 69c1da46..a05e40a9 100644 --- a/helpdesk/forms.py +++ b/helpdesk/forms.py @@ -129,8 +129,8 @@ class EditTicketForm(CustomFieldMixin, forms.ModelForm): # Since title is max 100 characters limit it in editing if "title" in self.fields: - self.fields["title"].max_length = 100 - self.fields["title"].widget.attrs["maxlength"] = 100 + self.fields["title"].max_length = 200 + self.fields["title"].widget.attrs["maxlength"] = 200 # Disable and add help_text to the merged_to field on this form self.fields["merged_to"].disabled = True @@ -272,7 +272,7 @@ class AbstractTicketForm(CustomFieldMixin, forms.Form): ) title = forms.CharField( - max_length=100, + max_length=200, required=True, widget=forms.TextInput(attrs={"class": "form-control"}), label=_("Summary of the problem"), From 606c3a3ee5109c6dfecb97839d2b99e50f44371c Mon Sep 17 00:00:00 2001 From: Dane Kennedy Date: Fri, 30 May 2025 10:41:40 +0200 Subject: [PATCH 2/6] Update title length --- helpdesk/models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helpdesk/models.py b/helpdesk/models.py index 8a54b242..9efc47b8 100644 --- a/helpdesk/models.py +++ b/helpdesk/models.py @@ -1161,7 +1161,7 @@ class TicketChange(models.Model): field = models.CharField( _("Field"), - max_length=100, + max_length=200, ) old_value = models.TextField( From 193ae98e825c6f44a7057c8c71164ee9180eacd5 Mon Sep 17 00:00:00 2001 From: Dane Kennedy Date: Fri, 30 May 2025 10:46:00 +0200 Subject: [PATCH 3/6] Get length from model --- helpdesk/forms.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helpdesk/forms.py b/helpdesk/forms.py index a05e40a9..5523aec9 100644 --- a/helpdesk/forms.py +++ b/helpdesk/forms.py @@ -129,8 +129,8 @@ class EditTicketForm(CustomFieldMixin, forms.ModelForm): # Since title is max 100 characters limit it in editing if "title" in self.fields: - self.fields["title"].max_length = 200 - self.fields["title"].widget.attrs["maxlength"] = 200 + self.fields["title"].max_length = Ticket._meta.get_field("title").max_length + self.fields["title"].widget.attrs["maxlength"] = Ticket._meta.get_field("title").max_length # Disable and add help_text to the merged_to field on this form self.fields["merged_to"].disabled = True From 13ca69c7b80aa44d6691c1b7da000f2e319797f2 Mon Sep 17 00:00:00 2001 From: Dane Kennedy Date: Fri, 30 May 2025 10:46:18 +0200 Subject: [PATCH 4/6] Update to version 1.5.1 --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index be16b5f0..fa00dba5 100644 --- a/setup.py +++ b/setup.py @@ -7,7 +7,7 @@ from setuptools import find_packages, setup import sys -version = "1.5.0" +version = "1.5.1" # Provided as an attribute, so you can append to these instead From aab7dfa78fad557140a94c5a718b1a9d2d33e274 Mon Sep 17 00:00:00 2001 From: Dane Kennedy Date: Mon, 2 Jun 2025 11:57:50 +0200 Subject: [PATCH 5/6] Add migration for updated TicketChange model (increase max_length to 200 from 100) --- .../0039_alter_ticketchange_field.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 helpdesk/migrations/0039_alter_ticketchange_field.py diff --git a/helpdesk/migrations/0039_alter_ticketchange_field.py b/helpdesk/migrations/0039_alter_ticketchange_field.py new file mode 100644 index 00000000..2dee94da --- /dev/null +++ b/helpdesk/migrations/0039_alter_ticketchange_field.py @@ -0,0 +1,18 @@ +# Generated by Django 5.2.1 on 2025-06-02 09:56 + +from django.db import migrations, models + + +class Migration(migrations.Migration): + + dependencies = [ + ('helpdesk', '0038_checklist_checklisttemplate_checklisttask'), + ] + + operations = [ + migrations.AlterField( + model_name='ticketchange', + name='field', + field=models.CharField(max_length=200, verbose_name='Field'), + ), + ] From 77b58ef2410e2da3c4531cfe76cf5e064f54a9e1 Mon Sep 17 00:00:00 2001 From: Dane Kennedy Date: Mon, 2 Jun 2025 14:48:17 +0200 Subject: [PATCH 6/6] format fixes --- helpdesk/forms.py | 4 +++- helpdesk/migrations/0039_alter_ticketchange_field.py | 9 ++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/helpdesk/forms.py b/helpdesk/forms.py index 5523aec9..0733828c 100644 --- a/helpdesk/forms.py +++ b/helpdesk/forms.py @@ -130,7 +130,9 @@ class EditTicketForm(CustomFieldMixin, forms.ModelForm): # Since title is max 100 characters limit it in editing if "title" in self.fields: self.fields["title"].max_length = Ticket._meta.get_field("title").max_length - self.fields["title"].widget.attrs["maxlength"] = Ticket._meta.get_field("title").max_length + self.fields["title"].widget.attrs["maxlength"] = Ticket._meta.get_field( + "title" + ).max_length # Disable and add help_text to the merged_to field on this form self.fields["merged_to"].disabled = True diff --git a/helpdesk/migrations/0039_alter_ticketchange_field.py b/helpdesk/migrations/0039_alter_ticketchange_field.py index 2dee94da..7bd1fb9f 100644 --- a/helpdesk/migrations/0039_alter_ticketchange_field.py +++ b/helpdesk/migrations/0039_alter_ticketchange_field.py @@ -4,15 +4,14 @@ from django.db import migrations, models class Migration(migrations.Migration): - dependencies = [ - ('helpdesk', '0038_checklist_checklisttemplate_checklisttask'), + ("helpdesk", "0038_checklist_checklisttemplate_checklisttask"), ] operations = [ migrations.AlterField( - model_name='ticketchange', - name='field', - field=models.CharField(max_length=200, verbose_name='Field'), + model_name="ticketchange", + name="field", + field=models.CharField(max_length=200, verbose_name="Field"), ), ]