extern/django-helpdesk
1
0
Fork 1
mirror of https://github.com/django-helpdesk/django-helpdesk.git synced 2025-06-19 17:18:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add required POST params to tests - update uses better form validation.

Browse Source
This commit is contained in:
Christopher Broderick 2025-04-09 07:36:13 +01:00
parent 6925aaaf38
commit 7288845e92
4 changed files with 36 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
helpdesk/tests/test_checklist.py
View File

@ -17,8 +17,14 @@ class TicketChecklistTestCase(TestCase):
self.client.login(username="User", password="pass")
self.ticket = Ticket.objects.create(
queue=Queue.objects.create(title="Queue", slug="queue")
queue=Queue.objects.create(title="Queue", slug="queue"),
title="Test Queue"
)
self.default_update_post_data = {
"queue": self.ticket.queue_id,
"title": self.ticket.title,
"priority": self.ticket.priority,
}
def test_create_checklist(self):
self.assertEqual(self.ticket.checklists.count(), 0)
@ -141,7 +147,10 @@ class TicketChecklistTestCase(TestCase):
response = self.client.post(
reverse("helpdesk:update", kwargs={"ticket_id": self.ticket.id}),
data={f"checklist-{checklist.id}": task.id},
data={
f"checklist-{checklist.id}": task.id,
**self.default_update_post_data,
},
follow=True,
)
self.assertEqual(response.status_code, 200)
@ -166,7 +175,12 @@ class TicketChecklistTestCase(TestCase):
self.assertEqual(self.ticket.followup_set.count(), 0)
response = self.client.post(
reverse("helpdesk:update", kwargs={"ticket_id": self.ticket.id}),
reverse("helpdesk:update",
kwargs={"ticket_id": self.ticket.id}),
data={
**self.default_update_post_data
},
follow=True,
)
self.assertEqual(response.status_code, 200)

4
helpdesk/tests/test_navigation.py
View File

@ -279,7 +279,7 @@ class ReturnToTicketTestCase(TestCase):
user = get_staff_user()
ticket = create_ticket()
response = return_to_ticket(user, helpdesk_settings, ticket)
response = return_to_ticket(user, ticket)
self.assertEqual(response["location"], ticket.get_absolute_url())
def test_non_staff_user(self):
@ -291,5 +291,5 @@ class ReturnToTicketTestCase(TestCase):
email="wensleydale@example.com",
)
ticket = create_ticket()
response = return_to_ticket(user, helpdesk_settings, ticket)
response = return_to_ticket(user, ticket)
self.assertEqual(response["location"], ticket.ticket_url)

15
helpdesk/tests/test_ticket_actions.py
View File

@ -119,9 +119,15 @@ class TicketActionsTestCase(TestCase):
ticket = Ticket.objects.create(**initial_data)
ticket_id = ticket.id
default_post_data = {
"title": ticket.title,
"priority": ticket.priority,
"queue": ticket.queue_id,
}
# assign new owner
post_data = {
"owner": self.user2.id,
**default_post_data,
}
response = self.client.post(
reverse("helpdesk:update", kwargs={"ticket_id": ticket_id}),
@ -139,7 +145,11 @@ class TicketActionsTestCase(TestCase):
self.user2.save()
self.user.email = "user1@test.com"
self.user.save()
post_data = {"new_status": Ticket.CLOSED_STATUS, "public": True}
post_data = {
"new_status": Ticket.CLOSED_STATUS,
"public": True,
**default_post_data,
}
# do this also to a newly assigned user (different from logged in one)
ticket.assigned_to = self.user
@ -153,6 +163,7 @@ class TicketActionsTestCase(TestCase):
"new_status": Ticket.OPEN_STATUS,
"owner": self.user2.id,
"public": True,
**default_post_data,
}
response = self.client.post(
reverse("helpdesk:update", kwargs={"ticket_id": ticket_id}),
@ -363,6 +374,8 @@ class TicketActionsTestCase(TestCase):
slug="newqueue",
)
post_data = {
"title": ticket.title,
"priority": ticket.priority,
"comment": "first follow-up in new queue",
"queue": str(new_queue.id),
}

3
helpdesk/tests/test_time_spent_auto.py
View File

@ -416,6 +416,7 @@ class TimeSpentAutoTestCase(TestCase):
"created": datetime.strptime(
"2024-04-09T08:00:00+00:00", "%Y-%m-%dT%H:%M:%S%z"
),
"description": "ollowup time spent auto exclude queues"
}
ticket = Ticket.objects.create(**initial_data)
@ -427,6 +428,8 @@ class TimeSpentAutoTestCase(TestCase):
post_data = {
"comment": "ticket in queue {}".format(queue),
"queue": queues[queue].id,
"title": ticket.title,
"priority": ticket.priority,
}
self.client.post(
reverse("helpdesk:update", kwargs={"ticket_id": ticket.id}), post_data