From 84b57f5c60986338a4794d9c4a95d813d6782923 Mon Sep 17 00:00:00 2001 From: Christopher Broderick Date: Mon, 31 Mar 2025 13:09:37 +0100 Subject: [PATCH] Change assert to use the IsNone/IsNotNone shortcut --- helpdesk/tests/test_get_email.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/helpdesk/tests/test_get_email.py b/helpdesk/tests/test_get_email.py index 835c7406..35d8bf43 100644 --- a/helpdesk/tests/test_get_email.py +++ b/helpdesk/tests/test_get_email.py @@ -501,7 +501,7 @@ class GetEmailCommonTests(TestCase): ticket = helpdesk.email.extract_email_metadata( message.as_string(), self.queue_public, self.logger ) - self.assertTrue(ticket is not None, "Ticket not created when it should be.") + self.assertIsNotNone(ticket, "Ticket not created when it should be.") @override_settings(QUEUE_EMAIL_BOX_UPDATE_ONLY=True) def test_email_for_no_new_ticket_when_setting_only_allows_update(self): @@ -512,8 +512,7 @@ class GetEmailCommonTests(TestCase): ticket = helpdesk.email.extract_email_metadata( message.as_string(), self.queue_public, self.logger ) - self.assertTrue( - ticket is None, f"Ticket was created when it should not be: {ticket}" + self.assertIsNone(ticket, f"Ticket was created when it should not be: {ticket}" )