extern/django-helpdesk
1
0
Fork 1
mirror of https://github.com/django-helpdesk/django-helpdesk.git synced 2025-06-21 18:11:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add get_and_set_ticket_status helper

Browse Source 
Extracts some futher code from `update_ticket`
This commit is contained in:
Martin Whitehouse 2022-07-25 03:11:30 +02:00
parent ecefd5e407
commit 9294eca5d6
No known key found for this signature in database
GPG Key ID: 3FCE1D3E9DEC09C1
1 changed files with 33 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
helpdesk/views/staff.py
View File

@ -561,6 +561,38 @@ def get_due_date_from_request_or_ticket(
return due_date return due_date
def get_and_set_ticket_status(
new_status: str,
ticket: Ticket,
follow_up: FollowUp
) -> tuple[str, str]:
"""Performs comparision on previous status to new status,
updating the title as required.
Returns:
The old status as a display string, old status code string
"""
old_status_str = ticket.get_status_display()
old_status = ticket.status
if new_status != ticket.status:
ticket.status = new_status
ticket.save()
follow_up.new_status = new_status
if follow_up.title:
follow_up.title += ' and %s' % ticket.get_status_display()
else:
follow_up.title = '%s' % ticket.get_status_display()
if not follow_up.title:
if follow_up.comment:
follow_up.title = _('Comment')
else:
follow_up.title = _('Updated')
follow_up.save()
return (old_status_str, old_status)
def update_ticket(request, ticket_id, public=False): def update_ticket(request, ticket_id, public=False):
ticket = get_ticket_from_request_with_authorisation(request, ticket_id, public) ticket = get_ticket_from_request_with_authorisation(request, ticket_id, public)
@ -640,24 +672,7 @@ def update_ticket(request, ticket_id, public=False):
f.title = _('Unassigned') f.title = _('Unassigned')
ticket.assigned_to = None ticket.assigned_to = None
old_status_str = ticket.get_status_display() old_status_str, old_status = get_and_set_ticket_status(new_status, ticket, f)
old_status = ticket.status
if new_status != ticket.status:
ticket.status = new_status
ticket.save()
f.new_status = new_status
if f.title:
f.title += ' and %s' % ticket.get_status_display()
else:
f.title = '%s' % ticket.get_status_display()
if not f.title:
if f.comment:
f.title = _('Comment')
else:
f.title = _('Updated')
f.save()
files = [] files = []
if request.FILES: if request.FILES: