extern/django-helpdesk
1
0
Fork 1
mirror of https://github.com/django-helpdesk/django-helpdesk.git synced 2025-08-19 04:06:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

You can now turn off file attachment filtering, fixes #1162

Browse Source
This commit is contained in:
Timothy Hobbs
2024-02-20 22:57:39 +01:00
parent b1b83cd593
commit 9a353bf4a5
5 changed files with 34 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
helpdesk/tests/test_get_email.py
View File

@@ -200,12 +200,11 @@ class GetEmailCommonTests(TestCase):
# The extractor prepends a part identifier so compare the ending
self.assertTrue(sent_file.name.endswith(filename), f"Filename extracted does not match: {sent_file.name}")
@override_settings(VALID_EXTENSIONS=['.png'])
def test_wrong_extension_attachment(self):
"""
Tests if an attachment with a wrong extension doesn't stop the email process
"""
message, _, _ = utils.generate_multipart_email(type_list=['plain', 'image'])
message, _, _ = utils.generate_multipart_email(type_list=['plain', 'executable'])
self.assertEqual(len(mail.outbox), 0) # @UndefinedVariable
@@ -213,7 +212,7 @@ class GetEmailCommonTests(TestCase):
extract_email_metadata(message.as_string(), self.queue_public, self.logger)
self.assertIn(
"ERROR:helpdesk:['Unsupported file extension: .jpg']",
"ERROR:helpdesk:['Unsupported file extension: .exe']",
cm.output
)
@@ -237,12 +236,11 @@ class GetEmailCommonTests(TestCase):
followup = ticket.followup_set.get()
self.assertEqual(2, followup.followupattachment_set.count())
@override_settings(VALID_EXTENSIONS=['.txt'])
def test_multiple_attachments_with_wrong_extension(self):
"""
Tests that a wrong extension won't stop from saving other valid attachment
"""
message, _, _ = utils.generate_multipart_email(type_list=['plain', 'image', 'file', 'image'])
message, _, _ = utils.generate_multipart_email(type_list=['plain', 'executable', 'file', 'executable'])
self.assertEqual(len(mail.outbox), 0) # @UndefinedVariable
@@ -250,7 +248,7 @@ class GetEmailCommonTests(TestCase):
extract_email_metadata(message.as_string(), self.queue_public, self.logger)
self.assertIn(
"ERROR:helpdesk:['Unsupported file extension: .jpg']",
"ERROR:helpdesk:['Unsupported file extension: .exe']",
cm.output
)