From 71dcfb6f37adbc5fa1d7fddfdf98b39e8cc32296 Mon Sep 17 00:00:00 2001
From: Stefano Brentegani <sbrentegani@gmail.com>
Date: Fri, 20 Apr 2012 00:02:28 +0200
Subject: [PATCH 1/2] Replacing undocumented ADMIN_URL setting

---
 helpdesk/templates/helpdesk/system_settings.html | 14 +++++++-------
 helpdesk/urls.py                                 | 13 ++++---------
 2 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/helpdesk/templates/helpdesk/system_settings.html b/helpdesk/templates/helpdesk/system_settings.html
index 44d52f74..22f8f47a 100644
--- a/helpdesk/templates/helpdesk/system_settings.html
+++ b/helpdesk/templates/helpdesk/system_settings.html
@@ -8,12 +8,12 @@
 <p>The following items can be maintained by you or other superusers:</p>{% endblocktrans %}
 
 <ul>
-    <li><a href='../ignore/'>{% trans "E-Mail Ignore list" %}</a></li>
-    <li><a href='{{ ADMIN_URL }}helpdesk/queue/'>{% trans "Maintain Queues" %}</a></li>
-    <li><a href='{{ ADMIN_URL }}helpdesk/presetreply/'>{% trans "Maintain Pre-Set Replies" %}</a></li>
-    <li><a href='{{ ADMIN_URL }}helpdesk/kbcategory/'>{% trans "Maintain Knowledgebase Categories" %}</a></li>
-    <li><a href='{{ ADMIN_URL }}helpdesk/kbitem/'>{% trans "Maintain Knowledgebase Items" %}</a></li>
-    <li><a href='{{ ADMIN_URL }}helpdesk/emailtemplate/'>{% trans "Maintain E-Mail Templates" %}</a></li>
-    <li><a href='{{ ADMIN_URL }}auth/user/'>{% trans "Maintain Users" %}</a></li>
+    <li><a href='{% url helpdesk_email_ignore %}'>{% trans "E-Mail Ignore list" %}</a></li>
+    <li><a href='{% url admin:helpdesk_queue_changelist %}'>{% trans "Maintain Queues" %}</a></li>
+    <li><a href='{% url admin:helpdesk_presetreply_changelist %}'>{% trans "Maintain Pre-Set Replies" %}</a></li>
+    <li><a href='{% url admin:helpdesk_kbcategory_changelist %}'>{% trans "Maintain Knowledgebase Categories" %}</a></li>
+    <li><a href='{% url admin:helpdesk_kbitem_changelist %}'>{% trans "Maintain Knowledgebase Items" %}</a></li>
+    <li><a href='{% url admin:helpdesk_emailtemplate_changelist %}'>{% trans "Maintain E-Mail Templates" %}</a></li>
+    <li><a href='{% url admin:auth_user_changelist %}'>{% trans "Maintain Users" %}</a></li>
 </ul>
 {% endblock %}
diff --git a/helpdesk/urls.py b/helpdesk/urls.py
index 7c059be4..c61774e4 100644
--- a/helpdesk/urls.py
+++ b/helpdesk/urls.py
@@ -80,7 +80,7 @@ urlpatterns = patterns('helpdesk.views.staff',
     url(r'^tickets/(?P<ticket_id>[0-9]+)/dependency/delete/(?P<dependency_id>[0-9]+)/$',
         'ticket_dependency_del',
         name='helpdesk_ticket_dependency_del'),
-        
+
     url(r'^tickets/(?P<ticket_id>[0-9]+)/attachment_delete/(?P<attachment_id>[0-9]+)/$',
         'attachment_del',
         name='helpdesk_attachment_del'),
@@ -137,7 +137,7 @@ urlpatterns += patterns('helpdesk.views.public',
 
     url(r'^change_language/$',
         'change_language',
-        name='helpdesk_public_change_language'),        
+        name='helpdesk_public_change_language'),
 )
 
 urlpatterns += patterns('',
@@ -165,7 +165,7 @@ if helpdesk_settings.HELPDESK_KB_ENABLED:
     urlpatterns += patterns('helpdesk.views.kb',
         url(r'^kb/$',
             'index', name='helpdesk_kb_index'),
-        
+
         url(r'^kb/(?P<item>[0-9]+)/$',
             'item', name='helpdesk_kb_item'),
 
@@ -189,11 +189,6 @@ urlpatterns += patterns('',
 
     url(r'^system_settings/$',
         'django.views.generic.simple.direct_to_template',
-        {
-            'template': 'helpdesk/system_settings.html',
-            'extra_context': {
-                'ADMIN_URL': getattr(settings, 'ADMIN_URL', '/admin/'),
-            },
-        },
+        {'template': 'helpdesk/system_settings.html',},
         name='helpdesk_system_settings'),
 )

From 04112a109dc9f93846647e846730b172794c5edd Mon Sep 17 00:00:00 2001
From: Stefano Brentegani <sbrentegani@gmail.com>
Date: Mon, 21 Jul 2014 21:43:29 +0200
Subject: [PATCH 2/2] fix unquoted urls in template

---
 helpdesk/templates/helpdesk/system_settings.html | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/helpdesk/templates/helpdesk/system_settings.html b/helpdesk/templates/helpdesk/system_settings.html
index 66b1e341..f2c2c1cb 100644
--- a/helpdesk/templates/helpdesk/system_settings.html
+++ b/helpdesk/templates/helpdesk/system_settings.html
@@ -8,12 +8,12 @@
 <p>The following items can be maintained by you or other superusers:</p>{% endblocktrans %}
 
 <ul>
-    <li><a href='{% url helpdesk_email_ignore %}'>{% trans "E-Mail Ignore list" %}</a></li>
-    <li><a href='{% url admin:helpdesk_queue_changelist %}'>{% trans "Maintain Queues" %}</a></li>
-    <li><a href='{% url admin:helpdesk_presetreply_changelist %}'>{% trans "Maintain Pre-Set Replies" %}</a></li>
-    <li><a href='{% url admin:helpdesk_kbcategory_changelist %}'>{% trans "Maintain Knowledgebase Categories" %}</a></li>
-    <li><a href='{% url admin:helpdesk_kbitem_changelist %}'>{% trans "Maintain Knowledgebase Items" %}</a></li>
-    <li><a href='{% url admin:helpdesk_emailtemplate_changelist %}'>{% trans "Maintain E-Mail Templates" %}</a></li>
-    <li><a href='{% url admin:auth_user_changelist %}'>{% trans "Maintain Users" %}</a></li>
+    <li><a href='{% url 'helpdesk_email_ignore' %}'>{% trans "E-Mail Ignore list" %}</a></li>
+    <li><a href='{% url 'admin:helpdesk_queue_changelist' %}'>{% trans "Maintain Queues" %}</a></li>
+    <li><a href='{% url 'admin:helpdesk_presetreply_changelist' %}'>{% trans "Maintain Pre-Set Replies" %}</a></li>
+    <li><a href='{% url 'admin:helpdesk_kbcategory_changelist' %}'>{% trans "Maintain Knowledgebase Categories" %}</a></li>
+    <li><a href='{% url 'admin:helpdesk_kbitem_changelist' %}'>{% trans "Maintain Knowledgebase Items" %}</a></li>
+    <li><a href='{% url 'admin:helpdesk_emailtemplate_changelist' %}'>{% trans "Maintain E-Mail Templates" %}</a></li>
+    <li><a href='{% url 'admin:auth_user_changelist' %}'>{% trans "Maintain Users" %}</a></li>
 </ul>
 {% endblock %}