extern/django-helpdesk
1
0
Fork 1
mirror of https://github.com/django-helpdesk/django-helpdesk.git synced 2025-05-03 17:14:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

simplifying if-case branches on CustomFieldMixin

Browse Source
This commit is contained in:
Alex Barcelo 2016-10-30 20:53:18 +01:00
parent cce12181f0
commit abd6fdcebe
1 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
helpdesk/forms.py
View File

@ -30,6 +30,18 @@ from helpdesk import settings as helpdesk_settings
User = get_user_model() User = get_user_model()
CUSTOMFIELD_TO_FIELD_DICT = {
# Store the immediate equivalences here
'boolean': forms.BooleanField,
'date': forms.DateField,
'time': forms.TimeField,
'datetime': forms.DateTimeField,
'email': forms.EmailField,
'url': forms.URLField,
'ipaddress': forms.GenericIPAddressField,
'slug': forms.SlugField,
}
class CustomFieldMixin(object): class CustomFieldMixin(object):
""" """
@ -37,6 +49,7 @@ class CustomFieldMixin(object):
""" """
def customfield_to_field(self, field, instanceargs): def customfield_to_field(self, field, instanceargs):
# if-elif branches start with special cases
if field.data_type == 'varchar': if field.data_type == 'varchar':
fieldclass = forms.CharField fieldclass = forms.CharField
instanceargs['max_length'] = field.max_length instanceargs['max_length'] = field.max_length
@ -56,23 +69,12 @@ class CustomFieldMixin(object):
if field.empty_selection_list: if field.empty_selection_list:
choices.insert(0, ('', '---------')) choices.insert(0, ('', '---------'))
instanceargs['choices'] = choices instanceargs['choices'] = choices
elif field.data_type == 'boolean':
fieldclass = forms.BooleanField
elif field.data_type == 'date':
fieldclass = forms.DateField
elif field.data_type == 'time':
fieldclass = forms.TimeField
elif field.data_type == 'datetime':
fieldclass = forms.DateTimeField
elif field.data_type == 'email':
fieldclass = forms.EmailField
elif field.data_type == 'url':
fieldclass = forms.URLField
elif field.data_type == 'ipaddress':
fieldclass = forms.GenericIPAddressField
elif field.data_type == 'slug':
fieldclass = forms.SlugField
else: else:
# Try to use the immediate equivalences dictionary
try:
fieldclass = CUSTOMFIELD_TO_FIELD_DICT[field.data_type]
except KeyError:
# The data_type was not found anywhere
raise NameError("Unrecognized data_type %s" % field.data_type) raise NameError("Unrecognized data_type %s" % field.data_type)
self.fields['custom_%s' % field.name] = fieldclass(**instanceargs) self.fields['custom_%s' % field.name] = fieldclass(**instanceargs)