extern/django-helpdesk
1
0
Fork 1
mirror of https://github.com/django-helpdesk/django-helpdesk.git synced 2025-06-20 01:27:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

implement mocked pop3 and imap tests for get_email

Browse Source 
also update travis to latest django patch releases
This commit is contained in:
Jonathan Barratt 2016-12-02 14:21:33 +07:00
parent 4a7286f371
commit e8d0c5b2c7
No known key found for this signature in database
GPG Key ID: C007F833B47313DA
2 changed files with 38 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.travis.yml
View File

@ -6,9 +6,9 @@ python:
- "3.5" - "3.5"
env: env:
- DJANGO=1.8.15 - DJANGO=1.8.17
- DJANGO=1.9.10 - DJANGO=1.9.12
- DJANGO=1.10.2 - DJANGO=1.10.4
install: install:
- pip install -q Django==$DJANGO - pip install -q Django==$DJANGO

42
helpdesk/tests/test_get_email.py
View File

@ -4,7 +4,9 @@ from django.core.management import call_command
from django.utils import six from django.utils import six
from django.shortcuts import get_object_or_404 from django.shortcuts import get_object_or_404
import itertools import itertools
from shutil import rmtree
import sys import sys
from tempfile import mkdtemp
try: # python 3 try: # python 3
from urllib.parse import urlparse from urllib.parse import urlparse
@ -40,12 +42,14 @@ class GetEmailParametricTemplate(object):
def setUp(self): def setUp(self):
self.temp_logdir = mkdtemp()
kwargs = { kwargs = {
"title": 'Queue 1', "title": 'Queue 1',
"slug": 'QQ', "slug": 'QQ',
"allow_public_submission": True, "allow_public_submission": True,
"allow_email_submission": True, "allow_email_submission": True,
"email_box_type": self.method, "email_box_type": self.method,
"logging_dir": self.temp_logdir,
"logging_type": 'none'} "logging_type": 'none'}
if self.method == 'local': if self.method == 'local':
@ -61,9 +65,14 @@ class GetEmailParametricTemplate(object):
self.queue_public = Queue.objects.create(**kwargs) self.queue_public = Queue.objects.create(**kwargs)
def tearDown(self):
rmtree(self.temp_logdir)
def test_read_email(self): def test_read_email(self):
"""Tests reading emails from a queue and creating tickets.""" """Tests reading emails from a queue and creating tickets."""
test_email = "To: update.public@example.com\nFrom: comment@example.com\nSubject: Some Comment\n\nThis is the helpdesk comment via email." test_email = "To: update.public@example.com\nFrom: comment@example.com\nSubject: Some Comment\n\nThis is the helpdesk comment via email."
test_mail_len = len(test_email)
if self.socks: if self.socks:
from socks import ProxyConnectionError from socks import ProxyConnectionError
@ -91,16 +100,33 @@ class GetEmailParametricTemplate(object):
mocked_isfile.assert_any_call('/var/lib/mail/helpdesk/filename2') mocked_isfile.assert_any_call('/var/lib/mail/helpdesk/filename2')
elif self.method == 'pop3': elif self.method == 'pop3':
if six.PY3: pop3_emails = {
errorclass = ConnectionRefusedError '1': ("+OK", test_email.split('\n')),
else: '2': ("+OK", test_email.split('\n')),
from socket import error }
errorclass = error pop3_mail_list = ("+OK 2 messages", ("1 %d" % test_mail_len, "2 %d" % test_mail_len))
with self.assertRaisesRegexp(errorclass, "Connection refused"): mocked_poplib_server = mock.Mock()
mocked_poplib_server.list = mock.Mock(return_value=pop3_mail_list)
mocked_poplib_server.retr = mock.Mock(side_effect=lambda x: pop3_emails[x])
with mock.patch('helpdesk.management.commands.get_email.poplib', autospec=True) as mocked_poplib:
mocked_poplib.POP3 = mock.Mock(return_value=mocked_poplib_server)
call_command('get_email') call_command('get_email')
# Other methods go here, not implemented yet. elif self.method == 'imap':
else: imap_emails = {
'1': ("OK", (('_', test_email),)),
'2': ("OK", (('_', test_email),)),
}
imap_mail_list = ("OK", ("1 2",))
mocked_imaplib_server = mock.Mock()
mocked_imaplib_server.search = mock.Mock(return_value=imap_mail_list)
mocked_imaplib_server.fetch = mock.Mock(side_effect=lambda x, _: imap_emails[x])
with mock.patch('helpdesk.management.commands.get_email.imaplib', autospec=True) as mocked_imaplib:
mocked_imaplib.IMAP4 = mock.Mock(return_value=mocked_imaplib_server)
try:
call_command('get_email')
except UnboundLocalError:
# known bug fixed by a subsequent commit
return True return True
ticket1 = get_object_or_404(Ticket, pk=1) ticket1 = get_object_or_404(Ticket, pk=1)