Commit Graph

1601 Commits

Author SHA1 Message Date
Sam Splunks
5ae1c1fdcb Forcing POST urls for votes 2024-12-06 10:16:14 +00:00
Sam Splunks
9ab10b93e1 Removing Test Client 2024-12-06 10:11:29 +00:00
Sam Splunks
93f6123545 Reverting to TestCase client 2024-12-06 10:07:08 +00:00
Sam Splunks
f7ca446bc9 Fixed url pattern 2024-12-06 10:03:57 +00:00
Sam Splunks
af2fac038c Update votes with POST method and CSRF token 2024-12-06 09:19:06 +00:00
Sam Splunks
8d2b09bb11 Update kb vote function 2024-12-05 09:47:23 +00:00
Sam Splunks
f710c07927 Escape html entities for followup title in ticket view 2024-12-05 09:35:26 +00:00
Sam Splunks
e0a04b5040 Javascript escape of html entities in ticket title for the My Tickets view 2024-12-05 09:33:17 +00:00
Benbb96
2c24fa9cae
Improve help texts 2024-10-19 16:50:17 +02:00
Benbb96
0a1e73918d
Refactor custom commands with modern syntax 2024-10-19 00:57:44 +02:00
Luca Buoncristiani
a7b3177944 DUPLICATE_STATUS Tickets moved to closed & resolved ones 2024-09-16 10:26:58 +02:00
Sam Splunks
2ec9f01f00 Cleaned EditTicketCustomFieldForm 2024-07-26 11:12:10 +00:00
Sam Splunks
f31f3eb233 Filter custom fields according to settings list 2024-07-26 11:04:54 +00:00
Sam Splunks
8eb883e19e Adding HELPDESK_SHOW_CUSTOM_FIELDS_FOLLOW_UP_LIST to settings 2024-07-26 10:49:36 +00:00
Sam Splunks
c7b60267eb Handle case where update_ticket doesn't handle customfields_form 2024-07-26 10:31:22 +00:00
Sam Splunks
9ee0207c3c Save custom fields in a followup 2024-07-26 10:02:05 +00:00
Sam Splunks
8901086a80 If title cannot be retrieved from POST, default should be ticket.title 2024-07-26 09:08:10 +00:00
Sam Splunks
f8cccbcf0a Display custom fields in Follow-up form 2024-07-26 08:46:26 +00:00
Christopher Broderick
0a2ceca8dd
Merge branch 'main' into time_spent 2024-07-22 11:01:52 +01:00
Sam Splunks
df46695bb1 Moving python time_spent calculation to database aggregation 2024-07-10 10:54:17 +00:00
Sam Splunks
f7c697ade5 delete_query view is expecting a pk field 2024-07-09 14:04:28 +00:00
Georg Lehner
66ba2d076a
Merge branch 'django-helpdesk:main' into attachment-enable-setting 2024-06-14 18:33:19 +02:00
Georg Lehner
9228c7fbd0 Fix Fix: correct variable name and test 2024-06-12 15:04:23 +02:00
Georg Lehner
80ae20d1ac Fix: Saving tickets with attachments disabled raises error
Exclude code where followups add their attachments to a new ticket.
Make helper function _attach_files_to_follow_up() more robust.
2024-06-12 14:58:00 +02:00
Georg Lehner
665e4008e7 Cleanup Dependency/Resolves form code 2024-06-10 17:33:08 +02:00
Georg Lehner
0b38f1d5bd Remove superfluous use of Value() in When clause 2024-06-10 17:27:43 +02:00
Georg Lehner
20cd08fe28 Do not show attachments in public tickets if not enabled, fix attachment upload if enabled
Attachments in followups were still shown (if they existed) even if
HELPDESK_ENABLE_ATTACHMENT was set to False.

If attachments were enabled it was not possible to upload them because
the JavaScript code for uploading attachments to public was not loaded
in the template.
2024-06-10 12:47:13 +02:00
Georg Lehner
78cf89ca9b Exclude related JavaScript function from staff Ticket view when attachments are not enabled 2024-06-10 11:24:00 +02:00
Georg Lehner
54864b2c1e Rewrite dependency tickets ordering, using Case annotation 2024-06-10 10:08:07 +02:00
Georg Lehner
ec603347c7 Improve code quality 2024-06-08 22:32:05 +02:00
Georg Lehner
2cb9d382cb Only show open ticket as dependency/parent candidates
It makes no sense to make a ticket depend on an already closed
ticket, or to make a closed ticket depend on another.

The only case I can think of is to create such a relationship in
hindsight for documentation purposes.  This can be implemented by
adding an admin interface or giving the administrator more choices.
2024-06-08 18:49:53 +02:00
Georg Lehner
7bf21685b3 Fix: remove unused and undefined context variable 2024-06-08 12:52:10 +02:00
Georg Lehner
bc764b50c1 Fix: itertools are superseded by NotIn ORM operator 2024-06-08 12:12:56 +02:00
Georg Lehner
25c36a6f5c Restrict ticket selection for dependencies and parents
When adding a dependent or parent ticket, the choice field in the
ticket selection form excludes:

- All existing dependencies of the current ticket.
- All existing parent tickets of the current ticket.
- The current ticket itself.

The first two prevent immediate circular references: A dependency
cannot be a parent and vice versa.  Deeper circular references are
not covered by this: a ticket can still be its own grandchild.

They also prevent current behavior of throwing an `IntegrityException`
when selecting a dependency or parent.

The third one prevents also a quirky behavior: until now, specifying the
ticket itself as parent or dependency just does not save the
dependency and does not issue a warning either.
2024-06-08 12:11:01 +02:00
Georg Lehner
b52ab69c42 Order dependend ticket with NotIn ORM operator instead of itertools 2024-06-08 12:00:43 +02:00
Georg Lehner
3dcbdad638 Fix: helpdesk settings are imported as settings 2024-06-07 18:04:05 +02:00
Georg Lehner
a2f944b475 Enable attachments by default
In order to not break existing django-helpdesk installations
upon upgrade.
2024-06-07 17:58:41 +02:00
Georg Lehner
cc1b125d53 Disable email attachment processing and email saving if attachments are not enabled.
Caution: untested
2024-06-06 15:58:27 +02:00
Georg Lehner
dd4c04945a Add HELPDESK_ENABLE_ATTACHMENTS setting and make it show/hide attachment related UI
Default setting is false. This is not backward compatible.
The rationale is: attachments contain most likely sensitive information.
By default they are served without access control.  Currently there is
no simple feature to configure access control.  To avoid unintentional
disclosure attachments should be an opt in: you have been warned.
2024-06-06 15:47:50 +02:00
Georg Lehner
887483a6d6 Remove status from ticket heading, since it is now shown in the description table 2024-06-06 00:34:28 +02:00
Georg Lehner
d7afcb6578 Reformat Resolves/Depends lists into tables. Allow adding/deleting of parent tickets 2024-06-06 00:28:36 +02:00
Georg Lehner
5b2441b994 Add list of 'parent' tickets to ticket description table
'parent' tickets are all tickets on which the current ticket depends.

The parent tickets can only be resolved if the current tickets is closed.

This patch splits the current |Dependencies|Total time spent| table row
in two rows.  The table layout is now

    |Status |Total time spent|
    |Depends|Resolves        |

Status and Total time only have one line.  Status was chosen as filler
field, because I believe it should be moved out of the title to reduce
visual distraction.

Depends and Resolve will have a variable number of lines and are closely
related.

Depends was chosen instead of "Dependencies", to indicate directly what
the listed tickets do and because it is shorter.

The commit also simplifies the wording of the tooltips and harmonizes with
the other tooltips in the same table: It indicates directly what happens
when the button is clicked (or touched!).

Notes:

- The complete row could be omitted if now Depends or Resolves exists for
  a ticket.  This would reduce visual distraction but was not implemented
  because it could lead to misled expectations.
- No button for removing/adding parent tickets was added. If considered
  important this can be added any time.  Currently a user has to go to
  the parent ticket and delete the dependency (easy) or remember the ticket
  id/title, search for the parent and add the ticket as dependency (difficult)
2024-05-17 12:34:40 +02:00
Georg Lehner
95755125fb Add datatables error message to error pop up 2024-05-14 21:46:18 +02:00
Georg Lehner
25f338cfc5 Pop up a nice error message when an AJAX request fails. 2024-05-11 16:41:01 +02:00
Benbb96
306a01a8b4
add login again button and reformat logged_out.html 2024-05-08 16:25:49 +02:00
Benbb96
ef5a43a3e2
remove unused import 2024-05-08 16:05:22 +02:00
Benbb96
485ac1294c
remove next_page parameter and show how to set LOGOUT_REDIRECT_URL in settings 2024-05-08 15:47:14 +02:00
Benbb96
b1316214c7
replace hardcoded path ../ to reverse_lazy URL 2024-05-07 15:50:51 +02:00
Benbb96
2d561d15c8
fix design on login/logout button when not staff 2024-05-07 15:43:12 +02:00
Benbb96
6fe5f1681f
fix logout in Django 5 with POST action instead of GET 2024-05-07 14:54:05 +02:00