From 261b10487567df59fc94e8e9f43e7d0049f3fcc6 Mon Sep 17 00:00:00 2001 From: nathan Date: Mon, 20 Jun 2022 11:18:15 -0600 Subject: [PATCH] Looks like SearchMixin no longer needs special handling for change event and it was not working with onchange attribute in some cases. --- api/js/etemplate/Et2Select/SearchMixin.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/api/js/etemplate/Et2Select/SearchMixin.ts b/api/js/etemplate/Et2Select/SearchMixin.ts index c0221710c5..b88cef16a6 100644 --- a/api/js/etemplate/Et2Select/SearchMixin.ts +++ b/api/js/etemplate/Et2Select/SearchMixin.ts @@ -441,13 +441,6 @@ export const Et2WithSearchMixin = >(superclass this.addEventListener("sl-blur", this._handleSearchAbort); this.addEventListener("sl-select", this._handleSelect); this.addEventListener("sl-clear", this._handleClear) - if(this._oldChange) - { - // Search messes up event order somehow, selecting an option fires the change event before - // the widget is finished adjusting, losing the value - // This is not optimal, but we need to get that change event - this.removeEventListener("change", this._oldChange); - } this._searchButtonNode.addEventListener("click", this._handleSearchButtonClick); } @@ -457,7 +450,7 @@ export const Et2WithSearchMixin = >(superclass this.removeEventListener("sl-blur", this._handleSearchAbort); this.removeEventListener("sl-select", this._handleSelect); this.removeEventListener("sl-clear", this._handleClear) - this.removeEventListener("change", this._handleChange); + this._searchButtonNode.removeEventListener("click", this._handleSearchButtonClick); }