speed improvements sugested by thomas ebeling

This commit is contained in:
Cornelius Weiß 2006-12-07 08:12:19 +00:00
parent be0bce8b40
commit 279148ccf6
2 changed files with 2 additions and 7 deletions

View File

@ -25,7 +25,6 @@ class bo_acl
var $query = ''; var $query = '';
var $sort = ''; var $sort = '';
var $total = 0; var $total = 0;
var $accounts;
var $cats; var $cats;
var $debug; var $debug;
@ -39,7 +38,6 @@ class bo_acl
$this->permissions = $GLOBALS['egw']->acl->get_all_location_rights($GLOBALS['egw_info']['user']['account_id'],'resources',true); $this->permissions = $GLOBALS['egw']->acl->get_all_location_rights($GLOBALS['egw_info']['user']['account_id'],'resources',true);
$this->egw_cats =& CreateObject('phpgwapi.categories','','resources'); $this->egw_cats =& CreateObject('phpgwapi.categories','','resources');
$this->accounts = $GLOBALS['egw']->accounts->get_list();
$this->debug = False; $this->debug = False;
//all this is only needed when called from uiacl. //all this is only needed when called from uiacl.
@ -192,7 +190,7 @@ class bo_acl
$GLOBALS['egw']->acl->delete_repository('resources','L' . $cat_id,false); $GLOBALS['egw']->acl->delete_repository('resources','L' . $cat_id,false);
foreach($this->accounts as $num => $account) foreach($GLOBALS['egw']->accounts->get_list() as $num => $account)
{ {
$account_id = $account['account_id']; $account_id = $account['account_id'];
$rights = false; $rights = false;

View File

@ -20,7 +20,6 @@ class ui_acl
var $sort = ''; var $sort = '';
var $order = ''; var $order = '';
var $bo; var $bo;
var $accounts;
var $nextmatchs = ''; var $nextmatchs = '';
var $rights; var $rights;
var $public_functions = array( var $public_functions = array(
@ -30,7 +29,6 @@ class ui_acl
function ui_acl() function ui_acl()
{ {
$this->bo =& createobject('resources.bo_acl',True); $this->bo =& createobject('resources.bo_acl',True);
$this->accounts = $GLOBALS['egw']->accounts->get_list();
$this->nextmatchs =& createobject('phpgwapi.nextmatchs'); $this->nextmatchs =& createobject('phpgwapi.nextmatchs');
$this->start = $this->bo->start; $this->start = $this->bo->start;
$this->query = $this->bo->query; $this->query = $this->bo->query;
@ -116,8 +114,7 @@ class ui_acl
function selectlist($right,$users_only=false) function selectlist($right,$users_only=false)
{ {
reset($this->bo->accounts); foreach ($GLOBALS['egw']->accounts->get_list() as $num => $account)
while (list($null,$account) = each($this->bo->accounts))
{ {
if(!($users_only && $account['account_lastname'] == 'Group')) if(!($users_only && $account['account_lastname'] == 'Group'))
{ {