From 3d97fccb61b9a42b34279e81c06dc0c6c5ca2323 Mon Sep 17 00:00:00 2001
From: ralf <rb@egroupware.org>
Date: Thu, 11 Aug 2022 14:14:20 +0200
Subject: [PATCH] only rows > 1 switches on multiple in some places we have
 rows="1", which des nothing at all previously, removing it now fixes errors
 e.g. in AB where the category filter returned [] (empty array) for "All
 addressbooks" causing a server-side PHP 8 error (Invalid index)

---
 api/etemplate.php | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/api/etemplate.php b/api/etemplate.php
index 59e5377884..e03d7df784 100644
--- a/api/etemplate.php
+++ b/api/etemplate.php
@@ -248,10 +248,14 @@ function send_template()
 				unset($attrs['expand_multiple_rows']);
 			}
 			// <select rows="N" (to show N rows) previously also switched multiple on
-			if (!empty($attrs['rows']))
+			if (!empty($attrs['rows']) && (int)$attrs['rows'] > 1)
 			{
 				$attrs['multiple'] = true;
 			}
+			else
+			{
+				unset($attrs['rows']);
+			}
 			// automatic convert empty_label for multiple=true to a placeholder
 			if (!empty($attrs['empty_label']) && !empty($attrs['multiple']))
 			{