* All apps: some favorites could not be deleted (reappeared after reload/next login)

phpgwapi/inc/class.egw_favorites.inc.php

@@ -189,7 +189,7 @@ class egw_favorites
 	{
 		// Only use alphanumeric for preference name, so it can be used directly as DOM ID
 		$name = strip_tags($_name);
-		$pref_name = "favorite_".preg_replace('/[^A-Za-z0-9-_]/','_',$name);
+		$pref_name = "favorite_".$name;
 
 		// older group-favorites have just true as their group and are not deletable, if we dont find correct group
 		if ($group === true || $group === '1')

phpgwapi/js/jsapi/app_base.js

@@ -614,7 +614,7 @@ var AppJS = Class.extend(
 						self.egw.jsonq(self.appname+'.egw_framework.ajax_set_favorite.template',
 							[
 								self.appname,
-								name.val(),
+								safe_name,
 								"add",
 								self.favorite_popup.group.get_value(),
 								self.favorite_popup.state