extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-26 00:29:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix Scrutinizer bug: remove non-static usage as it gives a PHP Fatal anyway, since Config::save_value() is declared static

Browse Source
This commit is contained in:
Ralf Becker 2016-08-28 12:10:10 +02:00
parent 9082a799e2
commit 52ca45a228
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
api/src/Config.php
View File

@ -117,21 +117,16 @@ class Config
* *
* @param string $name name of the config-value * @param string $name name of the config-value
* @param mixed $value content, empty or null values are not saved, but deleted * @param mixed $value content, empty or null values are not saved, but deleted
* @param string $app app-name (depreacted to use default of $this->appname set via the constructor!) * @param string $app app-name
* @param boolean $update_cache =true update instance cache and for phpgwapi invalidate session-cache * @param boolean $update_cache =true update instance cache and for phpgwapi invalidate session-cache
* @throws Exception\WrongParameter if no $app parameter given for static call * @throws Exception\WrongParameter if no $app parameter given for static call
* @return boolean|int true if no change, else number of affected rows * @return boolean|int true if no change, else number of affected rows
*/ */
static function save_value($name, $value, $app, $update_cache=true) static function save_value($name, $value, $app, $update_cache=true)
{ {
if (!$app && (!isset($this) || !is_a($this,__CLASS__))) if (!$app)
{ {
throw new Exception\WrongParameter('$app parameter required for static call of Config::save_value($name,$value,$app)!'); throw new Exception\WrongParameter('$app parameter required for static Config::save_value($name, $value, $app)!');
}
if (!$app || isset($this) && is_a($this,__CLASS__) && $app == $this->appname)
{
$app = $this->appname;
$this->config_data[$name] = $value;
} }
if (!isset(self::$configs)) if (!isset(self::$configs))
{ {