extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-26 00:29:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Move reading of favorites into a separate function from rendering list

Browse Source
This commit is contained in:
Nathan Gray 2014-02-20 17:44:53 +00:00
parent b2aabac6f9
commit 5949016faa
1 changed files with 38 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
phpgwapi/inc/class.egw_favorites.inc.php
View File

@ -56,27 +56,10 @@ class egw_favorites
'state' => array(),
'group' => true
)
);
) + self::get_favorites($app);
$is_admin = $GLOBALS['egw_info']['user']['apps']['admin'];
$html = "<span id='$target' class='ui-helper-clearfix sidebox-favorites'><ul class='ui-menu ui-widget-content ui-corner-all favorites' role='listbox'>\n";
foreach($GLOBALS['egw_info']['user']['preferences'][$app] as $pref_name => $pref)
{
if(strpos($pref_name, $pref_prefix) === 0)
{
if(!is_array($pref)) // old favorite
{
if (!($pref = unserialize($pref))) continue;
$pref = array(
'name' => substr($pref_name,strlen($pref_prefix)),
'group' => !isset($GLOBALS['egw']->preferences->user[$app][$pref_name]),
'state' => $pref,
);
//error_log(__METHOD__."() old favorite '$pref_name' converted to ".array2string($pref));
}
//else error_log(__METHOD__."() new favorite '$pref_name' ".array2string($pref));
$filters[(string)substr($pref_name,strlen($pref_prefix))] = $pref;
}
}
$default_filter = $GLOBALS['egw_info']['user']['preferences'][$app][$default];
if(!isset($default_filter) || !isset($filters[$default_filter])) $default_filter = "blank";
@ -113,6 +96,42 @@ class egw_favorites
);
}
/**
* Get a list of actual user favorites
* The default 'Blank' favorite is not included here
*
* @param string $app Current application
*
* @return array Favorite information
*/
public static function get_favorites($app)
{
$favorites = array();
$pref_prefix = 'favorite_';
// Look through all preferences & pull out favorites
foreach($GLOBALS['egw_info']['user']['preferences'][$app] as $pref_name => $pref)
{
if(strpos($pref_name, $pref_prefix) === 0)
{
if(!is_array($pref)) // old favorite
{
if (!($pref = unserialize($pref))) continue;
$pref = array(
'name' => substr($pref_name,strlen($pref_prefix)),
'group' => !isset($GLOBALS['egw']->preferences->user[$app][$pref_name]),
'state' => $pref,
);
//error_log(__METHOD__."() old favorite '$pref_name' converted to ".array2string($pref));
}
//else error_log(__METHOD__."() new favorite '$pref_name' ".array2string($pref));
$favorites[(string)substr($pref_name,strlen($pref_prefix))] = $pref;
}
}
return $favorites;
}
/**
* Create or delete a favorite for multiple users
*